)]}'
{"api-ref/source/servers.inc":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"37e217a0bc11a90b33d74fc8622ec275aee95889","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  - ``uuid`` (New in version 2.72)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"- For admin user, whitelist includes all filter keys mentioned in"},{"line_number":177,"context_line":"  :ref:`list-server-request` Section."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":".. note:: Starting with microversion 2.69 if server details cannot be loaded"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"5fc1f717_b25c487d","line":176,"range":{"start_line":176,"start_character":2,"end_line":176,"end_character":52},"updated":"2019-03-27 16:17:41.000000000","message":"If anything, we should update this doc to explain that this is not only for admin users anymore and that it can be configured using the \"os_compute_api:servers:allow_all_filters\" policy rule.","commit_id":"f2f2c56a5f1fd93c317af716b66d8ddb4fbced72"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6bc6e2b73521cb40c6cf86274e1164ab4cd2781b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"There is whitelist for valid filter keys. Any filter key other than from"},{"line_number":154,"context_line":"whitelist will be silently ignored."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- For non-admin users, whitelist is different from admin users whitelist."},{"line_number":157,"context_line":"  Valid whitelist for non-admin users includes"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  - ``all_tenants``"},{"line_number":160,"context_line":"  - ``changes-since``"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5fc1f717_8955ac52","line":157,"range":{"start_line":156,"start_character":2,"end_line":157,"end_character":46},"updated":"2019-04-05 23:09:14.000000000","message":"It\u0027s kind of weird to mention non-admin here, and then admin but \"oh by the way for non-admins you can also configure...\" below. Seems like it would be better to say something like:\n\nThe valid whitelist can be configured using the \"os_compute_api:servers:allow_all_filters\" policy rule. By default, the valid whitelist for non-admin users includes:...\n\nI\u0027m also not sure if we should mention this is only available since the Stein release - I tend to want to avoid mentioning release-specific things in the API reference if they aren\u0027t related to a microversion and policy is a weird middle ground.\n\nLet\u0027s see what others think.","commit_id":"a656a71759f5cfd284437894d1ece896be0774ce"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"65fd5cdb7235fca5d4cd9943fb1ab478e6b217cb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"There is whitelist for valid filter keys. Any filter key other than from"},{"line_number":154,"context_line":"whitelist will be silently ignored."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- For non-admin users, whitelist is different from admin users whitelist."},{"line_number":157,"context_line":"  Valid whitelist for non-admin users includes"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  - ``all_tenants``"},{"line_number":160,"context_line":"  - ``changes-since``"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"dfbec78f_363dcf2a","line":157,"range":{"start_line":156,"start_character":2,"end_line":157,"end_character":46},"in_reply_to":"5fc1f717_8955ac52","updated":"2019-05-15 00:01:34.000000000","message":"Yeah, current proposing explanation can make readers confused because the separated descriptions for the same non-admin users.\n\n The valid whitelist can be configured using the \"os_compute_api:servers:allow_all_filters\" policy rule. By default, the valid whitelist for non-admin users includes:...\n\nseems a good idea for me.\n\n\u003e I\u0027m also not sure if we should mention this is only available since the Stein release - I tend to want to avoid mentioning release-specific things in the API reference if they aren\u0027t related to a microversion and policy is a weird middle ground.\n\nWe are mentioning which filter keys are available on which microversion on the following. That still is a good middle ground.","commit_id":"a656a71759f5cfd284437894d1ece896be0774ce"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"09f2da8bbbb70ed87d94685241a9af525e1aa373","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- For non-admin users, whitelist is different from admin users whitelist."},{"line_number":157,"context_line":"  The valid whitelist can be configured using the"},{"line_number":158,"context_line":"  \"os_compute_api:servers:allow_all_filters\" policy rule. By default,"},{"line_number":159,"context_line":"  the valid whitelist for non-admin users includes"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  - ``all_tenants``"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"bfb3d3c7_1287d0d9","line":158,"range":{"start_line":158,"start_character":2,"end_line":158,"end_character":44},"updated":"2019-05-22 20:56:26.000000000","message":"Let\u0027s change the formatting to use double-backticks:\n\n``os_compute_api:servers:allow_all_filters``","commit_id":"10a07f2b180cfc2ea2c3d1ac518338810bc19d50"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"change_message_id":"bb3a28d9530873f825d5d4df852c2d793d56b8ce","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"    def _get_server_search_options(self, req):"},{"line_number":1215,"context_line":"        \"\"\"Return server search options allowed by non-admin.\"\"\""},{"line_number":1216,"context_line":"        opt_list \u003d (\u0027reservation_id\u0027, \u0027name\u0027, \u0027status\u0027, \u0027image\u0027, \u0027flavor\u0027,"},{"line_number":1217,"context_line":"                    \u0027ip\u0027, \u0027changes-since\u0027, \u0027all_tenants\u0027, \u0027uuid\u0027)"},{"line_number":1218,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.5\u0027):"},{"line_number":1219,"context_line":"            opt_list +\u003d (\u0027ip6\u0027,)"},{"line_number":1220,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.26\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_1e8534cf","line":1217,"range":{"start_line":1217,"start_character":58,"end_line":1217,"end_character":64},"updated":"2019-03-15 03:11:11.000000000","message":"I think you\u0027d better add it like \"changes-before\" and add info to api_version_request.","commit_id":"9f38dee5404046b0a1252109d0a0e90483898bed"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"change_message_id":"bb3a28d9530873f825d5d4df852c2d793d56b8ce","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"            self.assertEqual(search_opts[\u0027uuid\u0027],"},{"line_number":1490,"context_line":"                             \u002700000000-0000-0000-0000-000000000000\u0027)"},{"line_number":1491,"context_line":"            return objects.InstanceList("},{"line_number":1492,"context_line":"                objects\u003d[fakes.stub_instance_obj(100, uuid\u003duuids.fake)])"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"        self.mock_get_all.side_effect \u003d fake_get_all"},{"line_number":1495,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_fecf0826","line":1492,"range":{"start_line":1492,"start_character":59,"end_line":1492,"end_character":69},"updated":"2019-03-15 03:11:11.000000000","message":"search_opts[\u0027uuid\u0027]","commit_id":"9f38dee5404046b0a1252109d0a0e90483898bed"},{"author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"change_message_id":"bb3a28d9530873f825d5d4df852c2d793d56b8ce","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"        servers \u003d self.controller.index(req)[\u0027servers\u0027]"},{"line_number":1499,"context_line":""},{"line_number":1500,"context_line":"        self.assertEqual(1, len(servers))"},{"line_number":1501,"context_line":"        self.assertEqual(uuids.fake, servers[0][\u0027id\u0027])"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"    def test_get_servers_allows_ip(self):"},{"line_number":1504,"context_line":"        \"\"\"Test getting servers by ip.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_1ed3f4d6","line":1501,"range":{"start_line":1501,"start_character":24,"end_line":1501,"end_character":35},"updated":"2019-03-15 03:11:11.000000000","message":"ditto.","commit_id":"9f38dee5404046b0a1252109d0a0e90483898bed"}]}