)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e4a7a23c8a5b7c6a9adc80dadeed80c8891abd98","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"        :param block_device_info: Instance block device"},{"line_number":1116,"context_line":"            information."},{"line_number":1117,"context_line":"        :param power_on: True if the instance should be powered on, False"},{"line_number":1118,"context_line":"                         otherwise"},{"line_number":1119,"context_line":"        \"\"\""},{"line_number":1120,"context_line":"        LOG.debug(\u0027Spawn called for instance\u0027, instance\u003dinstance)"},{"line_number":1121,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_636cd8cd","line":1118,"updated":"2019-03-15 12:17:30.000000000","message":"could include \"not used by this driver\" here and elsewhere","commit_id":"fc737e009f556ee6fed3d55f32cc6440ffa1b528"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e4a7a23c8a5b7c6a9adc80dadeed80c8891abd98","unresolved":false,"context_lines":[{"line_number":3199,"context_line":"        if power_on:"},{"line_number":3200,"context_line":"            timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_for_boot)"},{"line_number":3201,"context_line":"            timer.start(interval\u003d0.5).wait()"},{"line_number":3202,"context_line":"        else:"},{"line_number":3203,"context_line":"            LOG.info(\"Instance spawned successfully.\", instance\u003dinstance)"},{"line_number":3204,"context_line":""},{"line_number":3205,"context_line":"    def _get_console_output_file(self, instance, console_log):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_435d1c13","line":3202,"range":{"start_line":3202,"start_character":8,"end_line":3202,"end_character":12},"updated":"2019-03-15 12:17:30.000000000","message":"why don\u0027t you want to log if you booted?","commit_id":"fc737e009f556ee6fed3d55f32cc6440ffa1b528"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4cfb2410e3600efe215ac570abd0266c5424954","unresolved":false,"context_lines":[{"line_number":3230,"context_line":"            post_xml_callback\u003dgen_confdrive,"},{"line_number":3231,"context_line":"            destroy_disks_on_failure\u003dTrue,"},{"line_number":3232,"context_line":"            power_on\u003dpower_on)"},{"line_number":3233,"context_line":"        LOG.debug(\"Guest created on hypervisor\", instance\u003dinstance)"},{"line_number":3234,"context_line":""},{"line_number":3235,"context_line":"        def _wait_for_boot():"},{"line_number":3236,"context_line":"            \"\"\"Called at an interval until the VM is running.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"7faddb67_8652a6dd","line":3233,"range":{"start_line":3233,"start_character":19,"end_line":3233,"end_character":24},"updated":"2019-08-28 13:53:04.000000000","message":"totally unrelated, but this should probably say \"Instance\"","commit_id":"a958dc5fcc738b47e2f4d1687e27d5ddc6d06ec1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4cfb2410e3600efe215ac570abd0266c5424954","unresolved":false,"context_lines":[{"line_number":3244,"context_line":"            timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_for_boot)"},{"line_number":3245,"context_line":"            timer.start(interval\u003d0.5).wait()"},{"line_number":3246,"context_line":"        else:"},{"line_number":3247,"context_line":"            LOG.info(\"Instance spawned successfully.\", instance\u003dinstance)"},{"line_number":3248,"context_line":""},{"line_number":3249,"context_line":"    def _get_console_output_file(self, instance, console_log):"},{"line_number":3250,"context_line":"        bytes_to_read \u003d MAX_CONSOLE_BYTES"}],"source_content_type":"text/x-python","patch_set":30,"id":"7faddb67_6661aaa8","line":3247,"range":{"start_line":3247,"start_character":0,"end_line":3247,"end_character":73},"updated":"2019-08-28 13:53:04.000000000","message":"Would it be useful to log this always? (i.e. drop the \u0027else\u0027 and bring this back into the main block)","commit_id":"a958dc5fcc738b47e2f4d1687e27d5ddc6d06ec1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"99d3e8c573038b4f741c257634cca819f868b5fe","unresolved":false,"context_lines":[{"line_number":3244,"context_line":"            timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_for_boot)"},{"line_number":3245,"context_line":"            timer.start(interval\u003d0.5).wait()"},{"line_number":3246,"context_line":"        else:"},{"line_number":3247,"context_line":"            LOG.info(\"Instance spawned successfully.\", instance\u003dinstance)"},{"line_number":3248,"context_line":""},{"line_number":3249,"context_line":"    def _get_console_output_file(self, instance, console_log):"},{"line_number":3250,"context_line":"        bytes_to_read \u003d MAX_CONSOLE_BYTES"}],"source_content_type":"text/x-python","patch_set":30,"id":"7faddb67_e6dfda35","line":3247,"range":{"start_line":3247,"start_character":0,"end_line":3247,"end_character":73},"in_reply_to":"7faddb67_6661aaa8","updated":"2019-08-28 13:55:16.000000000","message":"See L3240.","commit_id":"a958dc5fcc738b47e2f4d1687e27d5ddc6d06ec1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"35286fd41044e6bb0fee51df1582db19373a371e","unresolved":false,"context_lines":[{"line_number":3244,"context_line":"            timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_for_boot)"},{"line_number":3245,"context_line":"            timer.start(interval\u003d0.5).wait()"},{"line_number":3246,"context_line":"        else:"},{"line_number":3247,"context_line":"            LOG.info(\"Instance spawned successfully.\", instance\u003dinstance)"},{"line_number":3248,"context_line":""},{"line_number":3249,"context_line":"    def _get_console_output_file(self, instance, console_log):"},{"line_number":3250,"context_line":"        bytes_to_read \u003d MAX_CONSOLE_BYTES"}],"source_content_type":"text/x-python","patch_set":30,"id":"7faddb67_015540fa","line":3247,"range":{"start_line":3247,"start_character":0,"end_line":3247,"end_character":73},"in_reply_to":"7faddb67_e6dfda35","updated":"2019-08-28 14:27:00.000000000","message":"Oh yeah /o\\\n\nCould probably drop that and do above. I assume it won\u0027t trigger is the thing times out (assuming it would eventually)","commit_id":"a958dc5fcc738b47e2f4d1687e27d5ddc6d06ec1"}]}