)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a0455441b88ef368c693697b6a9404309b001649","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cache images of lvm imagebackend are always raw format. So that, we"},{"line_number":11,"context_line":"never need to convert the format here."},{"line_number":12,"context_line":"So we remove the calling function of \u0027convert_image_unsafe\u0027 now."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b7a4ce56c697e8806b4595dfebbdebe07ec45ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_4b7494fe","line":13,"updated":"2019-03-12 19:18:14.000000000","message":"Related-Bug: #1816686  ?","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"293ac1fed6896ec7a47d13999fda173ac4d7cbae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cache images of lvm imagebackend are always raw format. So that, we"},{"line_number":11,"context_line":"never need to convert the format here."},{"line_number":12,"context_line":"So we remove the calling function of \u0027convert_image_unsafe\u0027 now."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b7a4ce56c697e8806b4595dfebbdebe07ec45ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_de97b139","line":13,"in_reply_to":"5fc1f717_157e8aae","updated":"2019-03-14 20:01:21.000000000","message":"okay","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"a24b171b805c6a6f71c225f86ec10deb4873253a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cache images of lvm imagebackend are always raw format. So that, we"},{"line_number":11,"context_line":"never need to convert the format here."},{"line_number":12,"context_line":"So we remove the calling function of \u0027convert_image_unsafe\u0027 now."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b7a4ce56c697e8806b4595dfebbdebe07ec45ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_157e8aae","line":13,"in_reply_to":"5fc1f717_4b7494fe","updated":"2019-03-14 09:33:20.000000000","message":"I do not think so. Although the patch is related with patch https://review.openstack.org/#/c/640271/.\nBut without this patch, it will also not have the same issue of https://launchpad.net/bugs/1816686.\nSo it is just to fix the unsafe convert issue.","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"}],"nova/tests/unit/virt/libvirt/test_imagebackend.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da459c62d50289de0739b6d1834665c57e1fc0f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fc1f717_094e9c96","updated":"2019-03-12 19:17:41.000000000","message":"Wondering if (at least one of) these should instead keep the convert_image mock and assert_not_called.","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"}],"nova/virt/images.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da459c62d50289de0739b6d1834665c57e1fc0f1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                   compress\u003dcompress)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def convert_image_unsafe(source, dest, out_format, run_as_root\u003dFalse):"},{"line_number":109,"context_line":"    \"\"\"Convert image to other format, doing unsafe automatic input format"},{"line_number":110,"context_line":"    detection. Do not call this function."},{"line_number":111,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_ebad409b","side":"PARENT","line":108,"updated":"2019-03-12 19:17:41.000000000","message":"\\o/","commit_id":"605b0f50e33102ab85e701ebe2e4ccb10cee7672"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da459c62d50289de0739b6d1834665c57e1fc0f1","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        if self.image_backend.backend().REQUIRES_RAW_IMPORT:"},{"line_number":576,"context_line":"            if not CONF.force_raw_images:"},{"line_number":577,"context_line":"                msg \u003d _(\"\u0027[DEFAULT]/force_raw_images \u003d False\u0027 is not \""},{"line_number":578,"context_line":"                        \"compatible with \u0027[libvirt]/images_type \u003d rbd or lvm\u0027.\""},{"line_number":579,"context_line":"                        \"Please check the two configs and if you really \""},{"line_number":580,"context_line":"                        \"do want to use rbd as images_type, set \""},{"line_number":581,"context_line":"                        \"force_raw_images to True. At last, you need to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_8b7fdc13","line":578,"range":{"start_line":578,"start_character":25,"end_line":578,"end_character":35},"updated":"2019-03-12 19:17:41.000000000","message":"allowed","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"a24b171b805c6a6f71c225f86ec10deb4873253a","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        if self.image_backend.backend().REQUIRES_RAW_IMPORT:"},{"line_number":576,"context_line":"            if not CONF.force_raw_images:"},{"line_number":577,"context_line":"                msg \u003d _(\"\u0027[DEFAULT]/force_raw_images \u003d False\u0027 is not \""},{"line_number":578,"context_line":"                        \"compatible with \u0027[libvirt]/images_type \u003d rbd or lvm\u0027.\""},{"line_number":579,"context_line":"                        \"Please check the two configs and if you really \""},{"line_number":580,"context_line":"                        \"do want to use rbd as images_type, set \""},{"line_number":581,"context_line":"                        \"force_raw_images to True. At last, you need to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_f552de3a","line":578,"range":{"start_line":578,"start_character":25,"end_line":578,"end_character":35},"in_reply_to":"5fc1f717_8b7fdc13","updated":"2019-03-14 09:33:20.000000000","message":"Done","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e8baee4a9120659da9d3adf851aca6b575ace552","unresolved":false,"context_lines":[{"line_number":751,"context_line":"                                         size, sparse\u003dself.sparse)"},{"line_number":752,"context_line":"            if self.ephemeral_key_uuid is not None:"},{"line_number":753,"context_line":"                encrypt_lvm_image()"},{"line_number":754,"context_line":"            # NOTE: by calling convert_image_unsafe here we\u0027re"},{"line_number":755,"context_line":"            # telling qemu-img convert to do format detection on the input,"},{"line_number":756,"context_line":"            # because we don\u0027t know what the format is. For example,"},{"line_number":757,"context_line":"            # we might have downloaded a qcow2 image, or created an"},{"line_number":758,"context_line":"            # ephemeral filesystem locally, we just don\u0027t know here. Having"},{"line_number":759,"context_line":"            # audited this, all current sources have been sanity checked,"},{"line_number":760,"context_line":"            # either because they\u0027re locally generated, or because they have"},{"line_number":761,"context_line":"            # come from images.fetch_to_raw. However, this is major code smell."},{"line_number":762,"context_line":"            images.convert_image_unsafe(base, self.path, self.driver_format,"},{"line_number":763,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":764,"context_line":"            if resize:"},{"line_number":765,"context_line":"                disk.resize2fs(self.path, run_as_root\u003dTrue)"},{"line_number":766,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_b9c99659","side":"PARENT","line":763,"range":{"start_line":754,"start_character":0,"end_line":763,"end_character":57},"updated":"2019-05-30 10:17:22.000000000","message":"Coming to the review late but couldn\u0027t we check the format first and then call images.convert_image, avoiding any upgrade impact etc?","commit_id":"d6a699ca1df88cc5e8b18417e97c886938588732"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e8baee4a9120659da9d3adf851aca6b575ace552","unresolved":false,"context_lines":[{"line_number":731,"context_line":"    def _can_fallocate(self):"},{"line_number":732,"context_line":"        return False"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    @staticmethod"},{"line_number":735,"context_line":"    def _remove_non_raw_cache_image(base):"},{"line_number":736,"context_line":"        # NOTE(boxiang): If the cache image file exists, we will check"},{"line_number":737,"context_line":"        # the format of it. Only raw format image is compatible for"},{"line_number":738,"context_line":"        # LVM image backend. If format is not raw, we will remove it"},{"line_number":739,"context_line":"        # at first. We limit force_raw_images to True this time. So"},{"line_number":740,"context_line":"        # the format of new cache image must be raw."},{"line_number":741,"context_line":"        # We can remove this in \u0027U\u0027 version later."},{"line_number":742,"context_line":"        if not os.path.exists(base):"},{"line_number":743,"context_line":"            return True"},{"line_number":744,"context_line":"        image_format \u003d images.qemu_img_info(base)"},{"line_number":745,"context_line":"        if image_format.file_format !\u003d \u0027raw\u0027:"},{"line_number":746,"context_line":"            try:"},{"line_number":747,"context_line":"                os.remove(base)"},{"line_number":748,"context_line":"            except OSError as e:"},{"line_number":749,"context_line":"                LOG.warning(\"Ignoring failure to remove %(path)s: \""},{"line_number":750,"context_line":"                            \"%(error)s\", {\u0027path\u0027: base, \u0027error\u0027: e})"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def create_image(self, prepare_template, base, size, *args, **kwargs):"},{"line_number":753,"context_line":"        def encrypt_lvm_image():"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_b9f7568b","line":750,"range":{"start_line":734,"start_character":0,"end_line":750,"end_character":68},"updated":"2019-05-30 10:17:22.000000000","message":"Everything ends up as RAW so this isn\u0027t going to break anything but it seems like overkill if all we need to do to remove the call to convert_image_unsafe is use the same qemu_img_info call we are using here to confirm the format.","commit_id":"4c6f168d96673886acf8b34f8914406a4ae5df2e"}],"releasenotes/notes/remove-unsafe-convert-of-lvm-imagebackend-218ffd18e20c832d.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da459c62d50289de0739b6d1834665c57e1fc0f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_cb8084c2","line":1,"updated":"2019-03-12 19:17:41.000000000","message":"I think actually this should just be an edit of reno bug-1816686-77060eb8f8bd4092.yaml\n\nIf you can convince me otherwise, it, like the above, should mention that we\u0027re deleting non-raw images now if force_raw_images\u003dTrue.","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"a24b171b805c6a6f71c225f86ec10deb4873253a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_b80beb21","line":1,"in_reply_to":"5fc1f717_cb8084c2","updated":"2019-03-14 09:33:20.000000000","message":"Not that.\nFisrt, the LVM imagebackend does not meet the same issue on master like RBD imagebackend.\nSecond, on the base of REQUIRES_RAW_IMPORT for imagebackend, we can remove the unsafe convert of LVM imagebackend.\nBut I agree with you that we should note people that we are deleting non-raw images now here too.","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da459c62d50289de0739b6d1834665c57e1fc0f1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True. Based"},{"line_number":7,"context_line":"    on the above conditions, the cache images of LVM imagebackend are always"},{"line_number":8,"context_line":"    raw format. So we can remove the unsafe convert here."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_0b8c4c34","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":57},"updated":"2019-03-12 19:17:41.000000000","message":"strike (implementation detail not relevant in reno)","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"a24b171b805c6a6f71c225f86ec10deb4873253a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True. Based"},{"line_number":7,"context_line":"    on the above conditions, the cache images of LVM imagebackend are always"},{"line_number":8,"context_line":"    raw format. So we can remove the unsafe convert here."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_b548d686","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":57},"in_reply_to":"5fc1f717_0b8c4c34","updated":"2019-03-14 09:33:20.000000000","message":"Done","commit_id":"d18c071008334fb061482e5fe537d9cdf8615ac9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5b4401053ec0ee79c9d9d5d6aa2149aaa94e4c35","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_e1beb2ac","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"updated":"2019-03-25 17:10:23.000000000","message":"``[DEFAULT] force_raw_images``","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5b4401053ec0ee79c9d9d5d6aa2149aaa94e4c35","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_81dd6e15","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":63},"updated":"2019-03-25 17:10:23.000000000","message":"``literal``","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"3686c5b4299d5518ae5fb35ef2ec6966fb83a478","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_1986caba","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":63},"in_reply_to":"5fc1f717_81dd6e15","updated":"2019-03-26 07:41:48.000000000","message":"Done","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"3686c5b4299d5518ae5fb35ef2ec6966fb83a478","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_b98e96ce","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"5fc1f717_e1beb2ac","updated":"2019-03-26 07:41:48.000000000","message":"Done","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5b4401053ec0ee79c9d9d5d6aa2149aaa94e4c35","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_41e306d9","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":21},"updated":"2019-03-25 17:10:23.000000000","message":"``literal``","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5b4401053ec0ee79c9d9d5d6aa2149aaa94e4c35","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_61e882b2","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":34},"updated":"2019-03-25 17:10:23.000000000","message":"``literal``","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"3686c5b4299d5518ae5fb35ef2ec6966fb83a478","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_d98b62bd","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":21},"in_reply_to":"5fc1f717_41e306d9","updated":"2019-03-26 07:41:48.000000000","message":"Done","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"3686c5b4299d5518ae5fb35ef2ec6966fb83a478","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_79beee65","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":34},"in_reply_to":"5fc1f717_61e882b2","updated":"2019-03-26 07:41:48.000000000","message":"Done","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5b4401053ec0ee79c9d9d5d6aa2149aaa94e4c35","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"},{"line_number":9,"context_line":"    force_raw_images \u003d True and images_type \u003d lvm now."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_01d17efb","line":6,"range":{"start_line":6,"start_character":41,"end_line":6,"end_character":64},"updated":"2019-03-25 17:10:23.000000000","message":"``literal``","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"3686c5b4299d5518ae5fb35ef2ec6966fb83a478","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The libvirt driver\u0027s LVM imagebackend no longer supports setting"},{"line_number":4,"context_line":"    force_raw_images to False. Setting force_raw_images \u003d False and"},{"line_number":5,"context_line":"    images_type \u003d lvm in nova.conf will cause the nova compute service"},{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"},{"line_number":9,"context_line":"    force_raw_images \u003d True and images_type \u003d lvm now."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_99c39aed","line":6,"range":{"start_line":6,"start_character":41,"end_line":6,"end_character":64},"in_reply_to":"5fc1f717_01d17efb","updated":"2019-03-26 07:41:48.000000000","message":"Done","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5b4401053ec0ee79c9d9d5d6aa2149aaa94e4c35","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"},{"line_number":9,"context_line":"    force_raw_images \u003d True and images_type \u003d lvm now."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_c1d616f3","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":49},"updated":"2019-03-25 17:10:23.000000000","message":"``literal``","commit_id":"09f66e49ea43093564114a1add58772927c357b1"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"3686c5b4299d5518ae5fb35ef2ec6966fb83a478","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    to refuse to start. To fix this, set force_raw_images \u003d True."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Note that non-raw cache image files will be removed if you set"},{"line_number":9,"context_line":"    force_raw_images \u003d True and images_type \u003d lvm now."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_59b9b276","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":49},"in_reply_to":"5fc1f717_c1d616f3","updated":"2019-03-26 07:41:48.000000000","message":"Done","commit_id":"09f66e49ea43093564114a1add58772927c357b1"}]}