)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"9f748b936729473164016c7c19cf84b2c4504ef0","unresolved":false,"context_lines":[{"line_number":5949,"context_line":"                    # NOTE(danms): Libvirt is exposing a guest arch that nova"},{"line_number":5950,"context_line":"                    # does not even know about. Avoid aborting here and"},{"line_number":5951,"context_line":"                    # continue to process the rest."},{"line_number":5952,"context_line":"                    pass"},{"line_number":5953,"context_line":""},{"line_number":5954,"context_line":"        return instance_caps"},{"line_number":5955,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_44be90b4","line":5952,"range":{"start_line":5952,"start_character":20,"end_line":5952,"end_character":24},"updated":"2019-03-14 22:06:31.000000000","message":"What about LOG.info() with architecture name? In case when it would be something to implement.\n\nCould be handy for people adding support for new (sub)architectures.","commit_id":"71df650d0a390d2b6b19928db4379e723e9f5cde"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c073e7ff4799ae1ec205788278efcfdca1b6f70c","unresolved":false,"context_lines":[{"line_number":5949,"context_line":"                    # NOTE(danms): Libvirt is exposing a guest arch that nova"},{"line_number":5950,"context_line":"                    # does not even know about. Avoid aborting here and"},{"line_number":5951,"context_line":"                    # continue to process the rest."},{"line_number":5952,"context_line":"                    pass"},{"line_number":5953,"context_line":""},{"line_number":5954,"context_line":"        return instance_caps"},{"line_number":5955,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_cf3e19b7","line":5952,"range":{"start_line":5952,"start_character":20,"end_line":5952,"end_character":24},"in_reply_to":"5fc1f717_242ee4fa","updated":"2019-03-14 22:46:42.000000000","message":"I disagree that this is a thing we need to warn (even once) about. Libvirt has tons of features we don\u0027t support (yet, or ever) and we don\u0027t log about them. Further, someone who installs a new patched libvirt or even qemu in order to get some new feature, which starts to expose an arch we don\u0027t yet support would start getting a warning (even once) in their logs.\n\nIf this had been written this way from the beginning, we wouldn\u0027t have thought about it. We\u0027re really not covering something up here, we\u0027re just avoiding a naive list of things we assume was never going to change.","commit_id":"71df650d0a390d2b6b19928db4379e723e9f5cde"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f3fea3e1cbcd605a4c72fbd3b51b974db1b77e8f","unresolved":false,"context_lines":[{"line_number":5949,"context_line":"                    # NOTE(danms): Libvirt is exposing a guest arch that nova"},{"line_number":5950,"context_line":"                    # does not even know about. Avoid aborting here and"},{"line_number":5951,"context_line":"                    # continue to process the rest."},{"line_number":5952,"context_line":"                    pass"},{"line_number":5953,"context_line":""},{"line_number":5954,"context_line":"        return instance_caps"},{"line_number":5955,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_242ee4fa","line":5952,"range":{"start_line":5952,"start_character":20,"end_line":5952,"end_character":24},"in_reply_to":"5fc1f717_44be90b4","updated":"2019-03-14 22:15:59.000000000","message":"Dan notes why no log in the commit message. However, I agree we shouldn\u0027t be silent about it. How about (icky but effective):\n\n if not self.invalid_arch_warned:\n     LOG.warning(...)\n     self.invalid_arch_warned \u003d True","commit_id":"71df650d0a390d2b6b19928db4379e723e9f5cde"}]}