)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"ec59543c55b7aa190ff6a6572ac70bdffc3913fe","unresolved":false,"context_lines":[{"line_number":29,"context_line":"entry point. However, due to a few explicit uses of eventlet in the"},{"line_number":30,"context_line":"code it might just be simpler to do it at the top level."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Extra credit: do we have anything in place to write tightly-scoped"},{"line_number":33,"context_line":"tests for this? Neither functional or unit seem to be candidates, as"},{"line_number":34,"context_line":"both share interpreters and functional does its own monkey patching."},{"line_number":35,"context_line":"With the addition of these assertions tempest is now testing this for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_2ccd5830","line":32,"updated":"2019-03-15 18:35:17.000000000","message":"I don\u0027t know if this helps you, but in oslo.concurrency we had a similar problem and conditionalized the monkey-patching so we could run two completely separate test commands, one with and one without eventlet: https://github.com/openstack/oslo.concurrency/blob/master/tox.ini#L13\n\nThat may not work as well for Nova since your unit tests take so long, but maybe a subset could be run?","commit_id":"27d53e2d28f9f48c3f3c4de5cf1b9eed34c78b46"}],"nova/__init__.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4f77d582f352b9df7c62e93a2ee505a5d4b15fc2","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import os"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# NOTE(rpodolyaka): import oslo_service first, so that it makes eventlet hub"},{"line_number":31,"context_line":"# use a monotonic clock to avoid issues with drifts of system time (see"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_46f76a5a","side":"PARENT","line":28,"updated":"2019-03-15 13:33:42.000000000","message":"This is moved to monkey_patch because it\u0027s only relevant when monkey patching.","commit_id":"7705a55ffe107d139e3f70abe8516fbebe3d8c9b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4f77d582f352b9df7c62e93a2ee505a5d4b15fc2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(rpodolyaka): import oslo_service first, so that it makes eventlet hub"},{"line_number":31,"context_line":"# use a monotonic clock to avoid issues with drifts of system time (see"},{"line_number":32,"context_line":"# LP 1510234 for details)"},{"line_number":33,"context_line":"import oslo_service  # noqa"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"import eventlet  # noqa"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e6c0d6e3","side":"PARENT","line":33,"updated":"2019-03-15 13:33:42.000000000","message":"This issue was fixed in upstream eventlet 0.21.0, so is no longer required. I bumped our minimum eventlet version for this. Latest is 0.24.1, so this shouldn\u0027t be an issue.\n\nCheck eventlet changelog here: https://eventlet.net/doc/changelog.html\n\nI\u0027ve removed it here rather than separately because it imports a bunch of things, including oslo_context.context.","commit_id":"7705a55ffe107d139e3f70abe8516fbebe3d8c9b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4f77d582f352b9df7c62e93a2ee505a5d4b15fc2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# LP 1510234 for details)"},{"line_number":33,"context_line":"import oslo_service  # noqa"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"import eventlet  # noqa"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a6b64e89","side":"PARENT","line":35,"updated":"2019-03-15 13:33:42.000000000","message":"This was never required.","commit_id":"7705a55ffe107d139e3f70abe8516fbebe3d8c9b"}],"nova/monkey_patch.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4f77d582f352b9df7c62e93a2ee505a5d4b15fc2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# be green. To workaround this, reload the module after calling"},{"line_number":48,"context_line":"# monkey_patch()"},{"line_number":49,"context_line":"# NOTE(mdbooth): Is this still true? If so, can we avoid it?"},{"line_number":50,"context_line":"reload_module(importutils.import_module(\u0027oslo_context.context\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_4653ea39","side":"PARENT","line":50,"updated":"2019-03-15 13:33:42.000000000","message":"This was required because we were importing oslo_service nova/__init__.py, which imported oslo_context. That import is no longer required, so this can also be removed. The new assertion ensures it is not re-added.","commit_id":"7705a55ffe107d139e3f70abe8516fbebe3d8c9b"}],"requirements.txt":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4f77d582f352b9df7c62e93a2ee505a5d4b15fc2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"SQLAlchemy!\u003d1.1.5,!\u003d1.1.6,!\u003d1.1.7,!\u003d1.1.8,\u003e\u003d1.0.10 # MIT"},{"line_number":7,"context_line":"decorator\u003e\u003d3.4.0 # BSD"},{"line_number":8,"context_line":"eventlet!\u003d0.18.3,!\u003d0.20.1,\u003e\u003d0.18.2,\u003e\u003d0.21.0 # MIT"},{"line_number":9,"context_line":"Jinja2\u003e\u003d2.10 # BSD License (3 clause)"},{"line_number":10,"context_line":"keystonemiddleware\u003e\u003d4.17.0 # Apache-2.0"},{"line_number":11,"context_line":"lxml!\u003d3.7.0,\u003e\u003d3.4.1 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_662706cc","line":8,"updated":"2019-03-15 13:33:42.000000000","message":"Fixes eventlet hub to use a monotonic clock (see code removed in nova/__init__.py).","commit_id":"27d53e2d28f9f48c3f3c4de5cf1b9eed34c78b46"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"ec59543c55b7aa190ff6a6572ac70bdffc3913fe","unresolved":false,"context_lines":[{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"SQLAlchemy!\u003d1.1.5,!\u003d1.1.6,!\u003d1.1.7,!\u003d1.1.8,\u003e\u003d1.0.10 # MIT"},{"line_number":7,"context_line":"decorator\u003e\u003d3.4.0 # BSD"},{"line_number":8,"context_line":"eventlet!\u003d0.18.3,!\u003d0.20.1,\u003e\u003d0.18.2,\u003e\u003d0.21.0 # MIT"},{"line_number":9,"context_line":"Jinja2\u003e\u003d2.10 # BSD License (3 clause)"},{"line_number":10,"context_line":"keystonemiddleware\u003e\u003d4.17.0 # Apache-2.0"},{"line_number":11,"context_line":"lxml!\u003d3.7.0,\u003e\u003d3.4.1 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_8c6fac29","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":34},"updated":"2019-03-15 18:35:17.000000000","message":"I think you want to remove this then.","commit_id":"27d53e2d28f9f48c3f3c4de5cf1b9eed34c78b46"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"86a067f817788b1c6d4c0dec24b6706557e8cb53","unresolved":false,"context_lines":[{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"SQLAlchemy!\u003d1.1.5,!\u003d1.1.6,!\u003d1.1.7,!\u003d1.1.8,\u003e\u003d1.0.10 # MIT"},{"line_number":7,"context_line":"decorator\u003e\u003d3.4.0 # BSD"},{"line_number":8,"context_line":"eventlet!\u003d0.18.3,!\u003d0.20.1,\u003e\u003d0.18.2,\u003e\u003d0.21.0 # MIT"},{"line_number":9,"context_line":"Jinja2\u003e\u003d2.10 # BSD License (3 clause)"},{"line_number":10,"context_line":"keystonemiddleware\u003e\u003d4.17.0 # Apache-2.0"},{"line_number":11,"context_line":"lxml!\u003d3.7.0,\u003e\u003d3.4.1 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_4cfc643d","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":34},"in_reply_to":"5fc1f717_8c6fac29","updated":"2019-03-15 18:38:15.000000000","message":"Oh, and you\u0027ll need to update lower-constraints: https://github.com/openstack/nova/blob/master/lower-constraints.txt","commit_id":"27d53e2d28f9f48c3f3c4de5cf1b9eed34c78b46"}]}