)]}'
{"nova/virt/disk/mount/api.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"96dd7e69772ac785e30d390e968531c07bad5d95","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def unmnt_dev(self):"},{"line_number":205,"context_line":"        \"\"\"Unmount the device from the file system.\"\"\""},{"line_number":206,"context_line":"        if not self.mounted:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        LOG.debug(_(\"Umount %s\") % self.mapped_device)"},{"line_number":209,"context_line":"        utils.execute(\u0027umount\u0027, self.mapped_device, run_as_root\u003dTrue)"},{"line_number":210,"context_line":"        self.mounted \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F0sw%3D","line":207,"updated":"2013-12-30 18:53:51.000000000","message":"should the flush_dev just be done here?","commit_id":"c2d3a148662fb51672abc7588cbeadb7de8b1acc"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"85e9786c148ae3fe08cf7ee76fbecae323de6ba5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def unmnt_dev(self):"},{"line_number":205,"context_line":"        \"\"\"Unmount the device from the file system.\"\"\""},{"line_number":206,"context_line":"        if not self.mounted:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        LOG.debug(_(\"Umount %s\") % self.mapped_device)"},{"line_number":209,"context_line":"        utils.execute(\u0027umount\u0027, self.mapped_device, run_as_root\u003dTrue)"},{"line_number":210,"context_line":"        self.mounted \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F0o0%3D","line":207,"in_reply_to":"AAAAT3%2F%2F0sw%3D","updated":"2013-12-30 19:23:48.000000000","message":"yes, that would work","commit_id":"c2d3a148662fb51672abc7588cbeadb7de8b1acc"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"96dd7e69772ac785e30d390e968531c07bad5d95","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def do_umount(self):"},{"line_number":227,"context_line":"        \"\"\"Call the unmnt operation.\"\"\""},{"line_number":228,"context_line":"        self.flush_dev()"},{"line_number":229,"context_line":"        if self.mounted:"},{"line_number":230,"context_line":"            self.unmnt_dev()"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F0ss%3D","line":228,"updated":"2013-12-30 18:53:51.000000000","message":"should this be called here even if not mounted?","commit_id":"c2d3a148662fb51672abc7588cbeadb7de8b1acc"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"85e9786c148ae3fe08cf7ee76fbecae323de6ba5","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def do_umount(self):"},{"line_number":227,"context_line":"        \"\"\"Call the unmnt operation.\"\"\""},{"line_number":228,"context_line":"        self.flush_dev()"},{"line_number":229,"context_line":"        if self.mounted:"},{"line_number":230,"context_line":"            self.unmnt_dev()"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F0ok%3D","line":228,"in_reply_to":"AAAAT3%2F%2F0ss%3D","updated":"2013-12-30 19:23:48.000000000","message":"will move it to unmnt_dev","commit_id":"c2d3a148662fb51672abc7588cbeadb7de8b1acc"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"96dd7e69772ac785e30d390e968531c07bad5d95","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def do_teardown(self):"},{"line_number":233,"context_line":"        \"\"\"Call the umnt, unmap, and unget operations.\"\"\""},{"line_number":234,"context_line":"        self.flush_dev()"},{"line_number":235,"context_line":"        if self.mounted:"},{"line_number":236,"context_line":"            self.unmnt_dev()"},{"line_number":237,"context_line":"        if self.mapped:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F0so%3D","line":234,"updated":"2013-12-30 18:53:51.000000000","message":"should this be called here even if not mounted/mapped etc.?","commit_id":"c2d3a148662fb51672abc7588cbeadb7de8b1acc"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"85e9786c148ae3fe08cf7ee76fbecae323de6ba5","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def do_teardown(self):"},{"line_number":233,"context_line":"        \"\"\"Call the umnt, unmap, and unget operations.\"\"\""},{"line_number":234,"context_line":"        self.flush_dev()"},{"line_number":235,"context_line":"        if self.mounted:"},{"line_number":236,"context_line":"            self.unmnt_dev()"},{"line_number":237,"context_line":"        if self.mapped:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F0og%3D","line":234,"in_reply_to":"AAAAT3%2F%2F0so%3D","updated":"2013-12-30 19:23:48.000000000","message":"will move it to unmnt_dev","commit_id":"c2d3a148662fb51672abc7588cbeadb7de8b1acc"}],"nova/virt/disk/mount/nbd.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"dd44677855744292e7a4f9e8f0cdfa83b9d53f0c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.linked \u003d False"},{"line_number":131,"context_line":"        self.device \u003d None"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def flush_dev(self):"},{"line_number":134,"context_line":"        if self.device:"},{"line_number":135,"context_line":"            utils.execute(\u0027blockdev\u0027, \u0027--flushbufs\u0027,"},{"line_number":136,"context_line":"                          self.device, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F100%3D","line":133,"updated":"2013-12-30 11:18:17.000000000","message":"So I\u0027d comment here that this is provided to perform a BLKFLSBUF to ensure the block device is fully sync\u0027d,\nwhich is explicitly required on buggy versions of qemu-nbd\nbefore version x.xx\n\nSync stuff (like sleep stuff), should be commented as much as possible because of the large performance impacts and the awkwardness in adjusting later.\n\nthanks!","commit_id":"da1a2467159339c18cf98732523168b724f326b1"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2cb60e32ac20e9e3f51ff6ea9bf9d20a761560b2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.linked \u003d False"},{"line_number":131,"context_line":"        self.device \u003d None"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def flush_dev(self):"},{"line_number":134,"context_line":"        if self.device:"},{"line_number":135,"context_line":"            utils.execute(\u0027blockdev\u0027, \u0027--flushbufs\u0027,"},{"line_number":136,"context_line":"                          self.device, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F1ak%3D","line":133,"in_reply_to":"AAAAT3%2F%2F100%3D","updated":"2013-12-30 13:44:03.000000000","message":"Done","commit_id":"da1a2467159339c18cf98732523168b724f326b1"}]}