)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bc3766829ac9d410c7c6a629809cf9c1375aac1b","unresolved":false,"context_lines":[{"line_number":4250,"context_line":"                mach_type \u003d \u0027s390-ccw-virtio\u0027"},{"line_number":4251,"context_line":""},{"line_number":4252,"context_line":"            # If set in the config, use that as the default."},{"line_number":4253,"context_line":"            mach_type \u003d \\"},{"line_number":4254,"context_line":"                libvirt_utils.get_default_machine_type(caps.host.cpu.arch) \\"},{"line_number":4255,"context_line":"                or mach_type"},{"line_number":4256,"context_line":""},{"line_number":4257,"context_line":"        return mach_type"},{"line_number":4258,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fb71110e","line":4255,"range":{"start_line":4253,"start_character":11,"end_line":4255,"end_character":28},"updated":"2019-03-19 15:28:51.000000000","message":"Can you get rid of the backslashes please?","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"b28355477cf30ee0ef6fe2946decdfd10bb63135","unresolved":false,"context_lines":[{"line_number":4250,"context_line":"                mach_type \u003d \u0027s390-ccw-virtio\u0027"},{"line_number":4251,"context_line":""},{"line_number":4252,"context_line":"            # If set in the config, use that as the default."},{"line_number":4253,"context_line":"            mach_type \u003d \\"},{"line_number":4254,"context_line":"                libvirt_utils.get_default_machine_type(caps.host.cpu.arch) \\"},{"line_number":4255,"context_line":"                or mach_type"},{"line_number":4256,"context_line":""},{"line_number":4257,"context_line":"        return mach_type"},{"line_number":4258,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_ba5e1ae7","line":4255,"range":{"start_line":4253,"start_character":11,"end_line":4255,"end_character":28},"in_reply_to":"5fc1f717_fb71110e","updated":"2019-03-19 22:29:41.000000000","message":"Done","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bc3766829ac9d410c7c6a629809cf9c1375aac1b","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"def machine_type_mappings():"},{"line_number":545,"context_line":"    if CONF.libvirt.hw_machine_type is None:"},{"line_number":546,"context_line":"        return None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    mappings \u003d {}"},{"line_number":549,"context_line":"    for mapping in CONF.libvirt.hw_machine_type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_dbc3f537","line":546,"range":{"start_line":546,"start_character":15,"end_line":546,"end_character":19},"updated":"2019-03-19 15:28:51.000000000","message":"If you made this {}...","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"b28355477cf30ee0ef6fe2946decdfd10bb63135","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"def machine_type_mappings():"},{"line_number":545,"context_line":"    if CONF.libvirt.hw_machine_type is None:"},{"line_number":546,"context_line":"        return None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    mappings \u003d {}"},{"line_number":549,"context_line":"    for mapping in CONF.libvirt.hw_machine_type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_aa656d47","line":546,"range":{"start_line":546,"start_character":15,"end_line":546,"end_character":19},"in_reply_to":"5fc1f717_dbc3f537","updated":"2019-03-19 22:29:41.000000000","message":"Done","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bc3766829ac9d410c7c6a629809cf9c1375aac1b","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    mappings \u003d {}"},{"line_number":549,"context_line":"    for mapping in CONF.libvirt.hw_machine_type:"},{"line_number":550,"context_line":"        host_arch, _, machine_type \u003d mapping.partition(\u0027\u003d\u0027)"},{"line_number":551,"context_line":"        mappings[host_arch] \u003d machine_type"},{"line_number":552,"context_line":"    return mappings"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5b82a502","line":550,"range":{"start_line":550,"start_character":37,"end_line":550,"end_character":59},"updated":"2019-03-19 15:28:51.000000000","message":"weird. Why not\n\n host_arch, machine_type \u003d mapping.split(\u0027\u003d\u0027, 1)\n\n(currently (mostly) a copy/paste, so unrelated, no need to change it here)","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b8f049ee71f8390166e131c885f1faa0005d73d0","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    mappings \u003d {}"},{"line_number":549,"context_line":"    for mapping in CONF.libvirt.hw_machine_type:"},{"line_number":550,"context_line":"        host_arch, _, machine_type \u003d mapping.partition(\u0027\u003d\u0027)"},{"line_number":551,"context_line":"        mappings[host_arch] \u003d machine_type"},{"line_number":552,"context_line":"    return mappings"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_da31a6a4","line":550,"range":{"start_line":550,"start_character":37,"end_line":550,"end_character":59},"in_reply_to":"5fc1f717_0a6b611f","updated":"2019-03-19 22:33:51.000000000","message":"Okay.\n\nAnd... that happens, does it?\n\nNever mind, I don\u0027t want to know.","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"b28355477cf30ee0ef6fe2946decdfd10bb63135","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    mappings \u003d {}"},{"line_number":549,"context_line":"    for mapping in CONF.libvirt.hw_machine_type:"},{"line_number":550,"context_line":"        host_arch, _, machine_type \u003d mapping.partition(\u0027\u003d\u0027)"},{"line_number":551,"context_line":"        mappings[host_arch] \u003d machine_type"},{"line_number":552,"context_line":"    return mappings"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_0a6b611f","line":550,"range":{"start_line":550,"start_character":37,"end_line":550,"end_character":59},"in_reply_to":"5fc1f717_5b82a502","updated":"2019-03-19 22:29:41.000000000","message":"I think this protects against misconfigurations where the \"\u003d\" is missing.\n\n    \u003e\u003e\u003e a, b \u003d \"foo\".split(\"\u003d\", 1)\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    ValueError: not enough values to unpack (expected 2, got 1)\n    \u003e\u003e\u003e a, sep, b \u003d \"foo\".partition(\"\u003d\")\n    \u003e\u003e\u003e a\n    \u0027foo\u0027\n    \u003e\u003e\u003e b\n    \u0027\u0027","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"049e78c3525fcf722994a378e993e5c647dfa582","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    mappings \u003d {}"},{"line_number":549,"context_line":"    for mapping in CONF.libvirt.hw_machine_type:"},{"line_number":550,"context_line":"        host_arch, _, machine_type \u003d mapping.partition(\u0027\u003d\u0027)"},{"line_number":551,"context_line":"        mappings[host_arch] \u003d machine_type"},{"line_number":552,"context_line":"    return mappings"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_da619813","line":550,"range":{"start_line":550,"start_character":37,"end_line":550,"end_character":59},"in_reply_to":"5fc1f717_da31a6a4","updated":"2019-03-20 13:47:49.000000000","message":"Yeah, I vaguely recall seeing kind of misconfiguration in the past.","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bc3766829ac9d410c7c6a629809cf9c1375aac1b","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"def get_default_machine_type(arch):"},{"line_number":556,"context_line":"    mappings \u003d machine_type_mappings()"},{"line_number":557,"context_line":"    return mappings.get(arch) if mappings else None"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"def mdev_name2uuid(mdev_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7bea01ad","line":557,"range":{"start_line":557,"start_character":29,"end_line":557,"end_character":51},"updated":"2019-03-19 15:28:51.000000000","message":"...then you could remove this","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"b28355477cf30ee0ef6fe2946decdfd10bb63135","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"def get_default_machine_type(arch):"},{"line_number":556,"context_line":"    mappings \u003d machine_type_mappings()"},{"line_number":557,"context_line":"    return mappings.get(arch) if mappings else None"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"def mdev_name2uuid(mdev_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6a5f8572","line":557,"range":{"start_line":557,"start_character":29,"end_line":557,"end_character":51},"in_reply_to":"5fc1f717_7bea01ad","updated":"2019-03-19 22:29:41.000000000","message":"Done","commit_id":"82d2f6d2e399161d414e28b841323b9e8ad50563"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"36fef1d369e680b6216012b46883c0c0ec4165e7","unresolved":false,"context_lines":[{"line_number":546,"context_line":"    for mapping in CONF.libvirt.hw_machine_type or {}:"},{"line_number":547,"context_line":"        host_arch, _, machine_type \u003d mapping.partition(\u0027\u003d\u0027)"},{"line_number":548,"context_line":"        if machine_type \u003d\u003d \u0027\u0027:"},{"line_number":549,"context_line":"            LOG.warning(\"Invalid hw_machine_type config value %s\", mapping)"},{"line_number":550,"context_line":"        else:"},{"line_number":551,"context_line":"            mappings[host_arch] \u003d machine_type"},{"line_number":552,"context_line":"    return mappings"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_04a57fb5","line":549,"updated":"2019-03-20 16:27:27.000000000","message":"fine, we will then use the default one.","commit_id":"d2f89951039e99c7ab4aa11bea5464004265c76b"}]}