)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"29c3642942152a11b1b91d07c4a4bddc6b5fb973","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address old TODO in claim_resources_on_destination"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes some old comments about how things worked"},{"line_number":10,"context_line":"prior to Pike where the ResourceTracker would \"heal\""},{"line_number":11,"context_line":"allocations on the compute node during the periodic"},{"line_number":12,"context_line":"update_available_resource task. That code was removed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_de48c35d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":30},"updated":"2019-03-19 15:46:26.000000000","message":"Leading with this makes me think this is going to be a no-op change. I\u0027m not stuck on it, but if you could find a way to promote the second paragraph, that would be better.","commit_id":"ff53c454276824112c45516153d0a6629b2ab658"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35cfcde136d5121153723b7180162b0cf6887569","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address old TODO in claim_resources_on_destination"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes some old comments about how things worked"},{"line_number":10,"context_line":"prior to Pike where the ResourceTracker would \"heal\""},{"line_number":11,"context_line":"allocations on the compute node during the periodic"},{"line_number":12,"context_line":"update_available_resource task. That code was removed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_2aaaddd1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":30},"in_reply_to":"5fc1f717_de48c35d","updated":"2019-03-19 18:08:07.000000000","message":"Ack.","commit_id":"ff53c454276824112c45516153d0a6629b2ab658"}],"nova/scheduler/utils.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"29c3642942152a11b1b91d07c4a4bddc6b5fb973","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            context, instance.uuid)"},{"line_number":545,"context_line":"        source_allocations \u003d allocations.get(\u0027allocations\u0027, {})"},{"line_number":546,"context_line":"        consumer_generation \u003d allocations.get(\u0027consumer_generation\u0027)"},{"line_number":547,"context_line":"    else:"},{"line_number":548,"context_line":"        # NOTE(gibi) This is the live migrate case. The caller provided the"},{"line_number":549,"context_line":"        # allocation that needs to be used on the dest_node along with the"},{"line_number":550,"context_line":"        # expected consumer_generation of the consumer (which is the instance)."},{"line_number":551,"context_line":"        pass"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    if source_allocations:"},{"line_number":554,"context_line":"        # Generate an allocation request for the destination node."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_9e031bbf","line":551,"range":{"start_line":547,"start_character":0,"end_line":551,"end_character":12},"updated":"2019-03-19 15:46:26.000000000","message":"Why do we need `else: pass`?? I went and looked at the patch where this was done [1] and there\u0027s no indication. If we just need a vehicle for the \"source allocations were provided\" context of the comment, it seems like there are better ways.\n\n[1] https://review.openstack.org/#/c/583667/","commit_id":"ff53c454276824112c45516153d0a6629b2ab658"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35cfcde136d5121153723b7180162b0cf6887569","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            context, instance.uuid)"},{"line_number":545,"context_line":"        source_allocations \u003d allocations.get(\u0027allocations\u0027, {})"},{"line_number":546,"context_line":"        consumer_generation \u003d allocations.get(\u0027consumer_generation\u0027)"},{"line_number":547,"context_line":"    else:"},{"line_number":548,"context_line":"        # NOTE(gibi) This is the live migrate case. The caller provided the"},{"line_number":549,"context_line":"        # allocation that needs to be used on the dest_node along with the"},{"line_number":550,"context_line":"        # expected consumer_generation of the consumer (which is the instance)."},{"line_number":551,"context_line":"        pass"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    if source_allocations:"},{"line_number":554,"context_line":"        # Generate an allocation request for the destination node."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_ea5e1511","line":551,"range":{"start_line":547,"start_character":0,"end_line":551,"end_character":12},"in_reply_to":"5fc1f717_9e031bbf","updated":"2019-03-19 18:08:07.000000000","message":"Yeah I guess it was just for the comment in an else block. I could remove the else/pass and try to re-word this into the other comments above.","commit_id":"ff53c454276824112c45516153d0a6629b2ab658"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"29c3642942152a11b1b91d07c4a4bddc6b5fb973","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                       \u0027host\u0027: dest_node.host})"},{"line_number":605,"context_line":"            raise exception.NoValidHost(reason\u003dreason)"},{"line_number":606,"context_line":"    else:"},{"line_number":607,"context_line":"        # This shouldn\u0027t happen, so just raise an error since we cannot proceed"},{"line_number":608,"context_line":"        raise exception.ConsumerAllocationRetrievalFailed("},{"line_number":609,"context_line":"            consumer_uuid\u003dinstance.uuid,"},{"line_number":610,"context_line":"            error\u003d_(\u0027Expected to find allocations for source node resource \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5b12a564","line":607,"updated":"2019-03-19 15:46:26.000000000","message":"So why not do this after L545, and get rid of L553.","commit_id":"ff53c454276824112c45516153d0a6629b2ab658"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35cfcde136d5121153723b7180162b0cf6887569","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                       \u0027host\u0027: dest_node.host})"},{"line_number":605,"context_line":"            raise exception.NoValidHost(reason\u003dreason)"},{"line_number":606,"context_line":"    else:"},{"line_number":607,"context_line":"        # This shouldn\u0027t happen, so just raise an error since we cannot proceed"},{"line_number":608,"context_line":"        raise exception.ConsumerAllocationRetrievalFailed("},{"line_number":609,"context_line":"            consumer_uuid\u003dinstance.uuid,"},{"line_number":610,"context_line":"            error\u003d_(\u0027Expected to find allocations for source node resource \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6aa8e5da","line":607,"in_reply_to":"5fc1f717_5b12a564","updated":"2019-03-19 18:08:07.000000000","message":"That\u0027d be fine, and drop the big indentation.","commit_id":"ff53c454276824112c45516153d0a6629b2ab658"}]}