)]}'
{"nova/network/quantum/manager.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"0df6d80103e2068370591ad481bccb7c45cd5385","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        # which is incorrect"},{"line_number":224,"context_line":"        #"},{"line_number":225,"context_line":"        # Initialize forwarding"},{"line_number":226,"context_line":"        # self.l3driver.initialize_network(cidr)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return [{\u0027uuid\u0027: quantum_net_id}]"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2BEM%3D","line":226,"updated":"2012-04-11 18:45:39.000000000","message":"If you don\u0027t want nova-network to use the local host as the L3 router, you should set your l3driver to some driver other than the linux-net driver.","commit_id":"1522d97052b15e7b848edd2d86b6262066ebcf07"},{"author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"change_message_id":"5e71bf808f6755886729fde2cb4b3360fe524152","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        # which is incorrect"},{"line_number":224,"context_line":"        #"},{"line_number":225,"context_line":"        # Initialize forwarding"},{"line_number":226,"context_line":"        # self.l3driver.initialize_network(cidr)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return [{\u0027uuid\u0027: quantum_net_id}]"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFn%2F%2F%2F7Q%3D","line":226,"in_reply_to":"AAAAFX%2F%2F%2BEM%3D","updated":"2012-04-12 06:05:51.000000000","message":"Dan :\nAdding iptables rule is done by nova-network process during init_host and when new IP is allocated to an instance. \n\nCalling l3driver_initialize_network() in create_networks() call doesn\u0027t make sense, whether l3driver is linux-net or not.\n\nAs Ionut suggested - i\u0027ll remove this code (rather than keeping it commented)","commit_id":"1522d97052b15e7b848edd2d86b6262066ebcf07"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"a379a02bea3bd9c04905bfda2f8d0a4dd05321ce","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # Initialize forwarding"},{"line_number":223,"context_line":"        self.l3driver.initialize_network(cidr)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return [{\u0027uuid\u0027: quantum_net_id}]"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def delete_network(self, context, fixed_range, uuid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHH%2F%2F%2FoE%3D","side":"PARENT","line":224,"updated":"2012-04-25 18:52:22.000000000","message":"ignoring reviewer feedback is not a good way to encourage people to review your code.  See my comments from previous patches.","commit_id":"42f3bec10c7f7374ad4e9752b275b02ca2b2fdb9"}]}