)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"045a09ac19478ea11fc2e3558b7d889905932448","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-21 22:45:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make lower-constratints env use lower-constratins"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- The lower constratints job did not actully use the"},{"line_number":10,"context_line":"  constraints form lower-constraints.txt because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_b94911b8","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":49},"updated":"2019-03-21 23:51:36.000000000","message":"constraints","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"045a09ac19478ea11fc2e3558b7d889905932448","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-21 22:45:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make lower-constratints env use lower-constratins"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- The lower constratints job did not actully use the"},{"line_number":10,"context_line":"  constraints form lower-constraints.txt because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_f94f99bb","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":23},"updated":"2019-03-21 23:51:36.000000000","message":"constraints","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"045a09ac19478ea11fc2e3558b7d889905932448","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make lower-constratints env use lower-constratins"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- The lower constratints job did not actully use the"},{"line_number":10,"context_line":"  constraints form lower-constraints.txt because"},{"line_number":11,"context_line":"  the install_command in the base tox env included"},{"line_number":12,"context_line":"  the upper-constraints from the requirements repo."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_59c6ed18","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":24},"updated":"2019-03-21 23:51:36.000000000","message":"constraints :)","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"045a09ac19478ea11fc2e3558b7d889905932448","unresolved":false,"context_lines":[{"line_number":7,"context_line":"make lower-constratints env use lower-constratins"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- The lower constratints job did not actully use the"},{"line_number":10,"context_line":"  constraints form lower-constraints.txt because"},{"line_number":11,"context_line":"  the install_command in the base tox env included"},{"line_number":12,"context_line":"  the upper-constraints from the requirements repo."},{"line_number":13,"context_line":"- This change fixes the install command in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_79c96923","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":18},"updated":"2019-03-21 23:51:36.000000000","message":"from","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"045a09ac19478ea11fc2e3558b7d889905932448","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  the upper-constraints from the requirements repo."},{"line_number":13,"context_line":"- This change fixes the install command in the"},{"line_number":14,"context_line":"  lower-constraints tox env."},{"line_number":15,"context_line":"- This change modify the lower-constraints.txt"},{"line_number":16,"context_line":"  to allow nova to install."},{"line_number":17,"context_line":"- This change fixes an import order race in the tests"},{"line_number":18,"context_line":"  that was discovered when running lower-constraints."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_19d065c9","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":20},"updated":"2019-03-21 23:51:36.000000000","message":"modifies","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b46b06a78657b0421a9c684bd51189ff93fd56c2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  to allow nova to install."},{"line_number":17,"context_line":"- This change fixes an import order race in the tests"},{"line_number":18,"context_line":"  that was discovered when running lower-constraints."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I96f48c49cc700d4e40c8eb77cb2c8d845b8ff075"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_792de9fb","line":19,"updated":"2019-03-21 23:37:10.000000000","message":"ill file a bug for this tomorow","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f36faa1e50ddd04fd25a73ec762fd5269828a82a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  to allow nova to install."},{"line_number":17,"context_line":"- This change sorts the lower-constraitns.txt and"},{"line_number":18,"context_line":"  add missing packages that were installed but"},{"line_number":19,"context_line":"  not listed."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I96f48c49cc700d4e40c8eb77cb2c8d845b8ff075"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5fc1f717_2225345d","line":19,"updated":"2019-03-29 17:51:44.000000000","message":"Is this change associated with an open bug?","commit_id":"e130bb4c0f256c7a2f2f8ec03b19ab96b06a2c1d"}],"lower-constraints.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b90f0f8d48c8db041144f9bf809f829ca0df8850","unresolved":false,"context_lines":[{"line_number":108,"context_line":"ply\u003d\u003d3.11"},{"line_number":109,"context_line":"prettytable\u003d\u003d0.7.1"},{"line_number":110,"context_line":"psutil\u003d\u003d3.2.2"},{"line_number":111,"context_line":"psycopg2\u003d\u003d2.7.0"},{"line_number":112,"context_line":"py\u003d\u003d1.5.2"},{"line_number":113,"context_line":"pyasn1-modules\u003d\u003d0.2.1"},{"line_number":114,"context_line":"pyasn1\u003d\u003d0.4.2"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_f944791b","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":15},"updated":"2019-03-21 23:15:29.000000000","message":"this is technically only needed because of the fact\nubuntu 18.04 ships postgresql 10.6 but we need it for the gate. if you are not useing nova with postgres this dep is not needed at all.","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b90f0f8d48c8db041144f9bf809f829ca0df8850","unresolved":false,"context_lines":[{"line_number":122,"context_line":"pyparsing\u003d\u003d2.2.0"},{"line_number":123,"context_line":"pyperclip\u003d\u003d1.6.0"},{"line_number":124,"context_line":"pypowervm\u003d\u003d1.1.15"},{"line_number":125,"context_line":"pyroute2\u003d\u003d0.5.2"},{"line_number":126,"context_line":"pytest\u003d\u003d3.4.2"},{"line_number":127,"context_line":"python-barbicanclient\u003d\u003d4.5.2"},{"line_number":128,"context_line":"python-cinderclient\u003d\u003d3.3.0"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_793969a1","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":15},"updated":"2019-03-21 23:15:29.000000000","message":"this is the min version of pyroute2 requried by the min version of os-vif we depend on.","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b90f0f8d48c8db041144f9bf809f829ca0df8850","unresolved":false,"context_lines":[{"line_number":172,"context_line":"websockify\u003d\u003d0.8.0"},{"line_number":173,"context_line":"wrapt\u003d\u003d1.10.11"},{"line_number":174,"context_line":"wsgi-intercept\u003d\u003d1.7.0"},{"line_number":175,"context_line":"zVMCloudConnector\u003d\u003d1.1.1;sys_platform!\u003d\u0027win32\u0027 and python_version\u003d\u003d\u00272.7\u0027  # Apache 2.0 License"},{"line_number":176,"context_line":"zVMCloudConnector\u003d\u003d1.3.0;sys_platform!\u003d\u0027win32\u0027 and python_version!\u003d\u00272.7\u0027  # Apache 2.0 License"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_b9b91116","line":176,"range":{"start_line":175,"start_character":0,"end_line":176,"end_character":94},"updated":"2019-03-21 23:15:29.000000000","message":"1.1.1 is still fine on python 2.7\n\nthere is a runtime check that is executed by its setup.py \nfor python 3\nin 1.1.1 it only allowed py 3.5 eventhoguh py 3.6 works fine\n\n1.3.0 add py3.6 adn a later version removed it entirely\nour lower constrating job use py3.6 so i bumped to the min version requried for the job.","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"}],"nova/tests/fixtures.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b90f0f8d48c8db041144f9bf809f829ca0df8850","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            rpc.init(CONF)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        def cleanup_in_flight_rpc_messages():"},{"line_number":795,"context_line":"            messaging._drivers.impl_fake.FakeExchangeManager._exchanges \u003d {}"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        self.addCleanup(cleanup_in_flight_rpc_messages)"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b9e03128","side":"PARENT","line":795,"range":{"start_line":795,"start_character":12,"end_line":795,"end_character":40},"updated":"2019-03-21 23:15:29.000000000","message":"previously this would raise an error\nAttributeError: \u0027module\u0027 object has no attribute \u0027impl_fake\u0027\n\nif execution of cleanup_in_flight_rpc_messages happend before another test had executed an import of \noslo_messaging._drivers.impl_fake\n\n\nthis can be seen by doing the following in a tox env\n \n\u003e\u003e\u003e import oslo_messaging as messaging\n\u003e\u003e\u003e messaging._drivers.impl_fake.FakeExchangeManager._exchanges\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nAttributeError: \u0027module\u0027 object has no attribute \u0027impl_fake\u0027\n\u003e\u003e\u003e import oslo_messaging._drivers.impl_fake\n\u003e\u003e\u003e messaging._drivers.impl_fake.FakeExchangeManager._exchanges\n{}","commit_id":"c3386126e0f08c0b178778f90e1457e48376b3b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88ef1852817b1064f26634f6d2e8b1dae47fa6c1","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            mock_gtu.return_value \u003d None"},{"line_number":793,"context_line":"            rpc.init(CONF)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        def cleanup_in_flight_rpc_messages():"},{"line_number":796,"context_line":"            fake_messaging_driver.FakeExchangeManager._exchanges \u003d {}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        self.addCleanup(cleanup_in_flight_rpc_messages)"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_99ef75e8","line":796,"range":{"start_line":795,"start_character":12,"end_line":796,"end_character":69},"updated":"2019-03-21 23:18:16.000000000","message":"this might not acctully resetting the inflight messages\nit nolonger has the import race but it might be byassign some mocking. ill try doing this another way.","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1a7b78555126b4ff723371a640a2a436bb021891","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            mock_gtu.return_value \u003d None"},{"line_number":793,"context_line":"            rpc.init(CONF)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        def cleanup_in_flight_rpc_messages():"},{"line_number":796,"context_line":"            fake_messaging_driver.FakeExchangeManager._exchanges \u003d {}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        self.addCleanup(cleanup_in_flight_rpc_messages)"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_79bac9c0","line":796,"range":{"start_line":795,"start_character":12,"end_line":796,"end_character":69},"in_reply_to":"5fc1f717_99ef75e8","updated":"2019-03-21 23:29:40.000000000","message":"noop this is not the issue.\nwe are just not mocking properly\nor setting up our config correctly and end up using the amqp driver.\nhttp://paste.openstack.org/show/748221/","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b46b06a78657b0421a9c684bd51189ff93fd56c2","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  bindep test"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"[testenv:lower-constraints]"},{"line_number":280,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":281,"context_line":"deps \u003d"},{"line_number":282,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":283,"context_line":"  -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5fc1f717_b9ed91b8","line":280,"range":{"start_line":280,"start_character":1,"end_line":280,"end_character":47},"updated":"2019-03-21 23:37:10.000000000","message":"this is the actul fix for the job but the version changes are required when we actully start uing lower-constratints.txt instead of upper-constratints","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"62e31416d3ca2cb2e769ffbdd39e3e461218ef6d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  bindep test"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"[testenv:lower-constraints]"},{"line_number":280,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":281,"context_line":"deps \u003d"},{"line_number":282,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":283,"context_line":"  -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5fc1f717_c6fc2db7","line":280,"range":{"start_line":280,"start_character":1,"end_line":280,"end_character":47},"in_reply_to":"5fc1f717_b9ed91b8","updated":"2019-03-22 13:50:48.000000000","message":"I think you actually want to change the install_command line above to use this, then add a deps\u003d as the default using those upper constraints.\n\nHere\u0027s how I addressed it in one of the Cinder repos I found had this same issue:\n\nhttps://review.openstack.org/645590\n\nWhen the lower-constraints jobs were added, this was the assumed pattern that all repos were following, but obviously there were a few variations. Probably better to make it all consistent with how it was expected to work.","commit_id":"5408e0f5b056b18b58be9222c8de20171e155665"}]}