)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"55e7275a3f44d5ea0352845011fff30b9175e06f","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        for field in self.fields:"},{"line_number":484,"context_line":"            if self.obj_attr_is_set(field):"},{"line_number":485,"context_line":"                if field \u003d\u003d \u0027info_cache\u0027:"},{"line_number":486,"context_line":"                    self._refresh_nested(self[field], current[field])"},{"line_number":487,"context_line":"                elif self[field] !\u003d current[field]:"},{"line_number":488,"context_line":"                    self[field] \u003d current[field]"},{"line_number":489,"context_line":"        self.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FudQ%3D","line":486,"updated":"2014-01-02 20:49:43.000000000","message":"This would be nicer if InfoCache had \u0027refresh\u0027 that you could call here, instead.  You could probably make it generic and just check to see if the field is an object and refresh it if so?  That would mean you would need to add a refresh() to the other nested objects in Instance though :)","commit_id":"0e074fe6e6724de6c0504679f1d404668530a124"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4b808eccb7a32cae29400eab9945494170c1a11e","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        for field in self.fields:"},{"line_number":477,"context_line":"            if self.obj_attr_is_set(field):"},{"line_number":478,"context_line":"                if field \u003d\u003d \u0027info_cache\u0027:"},{"line_number":479,"context_line":"                    self.info_cache.refresh()"},{"line_number":480,"context_line":"                    # NOTE(danms): Make sure this shows up as touched"},{"line_number":481,"context_line":"                    self.info_cache \u003d self.info_cache"},{"line_number":482,"context_line":"                elif self[field] !\u003d current[field]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F71M%3D","line":479,"updated":"2014-01-06 15:33:48.000000000","message":"Why not pass the context in here?","commit_id":"ed8440895dfb8cf63dbfc7f30dad8a0e3ff2d2ee"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"87470221145e950d9e8cae803717a9022360c846","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        for field in self.fields:"},{"line_number":477,"context_line":"            if self.obj_attr_is_set(field):"},{"line_number":478,"context_line":"                if field \u003d\u003d \u0027info_cache\u0027:"},{"line_number":479,"context_line":"                    self.info_cache.refresh()"},{"line_number":480,"context_line":"                    # NOTE(danms): Make sure this shows up as touched"},{"line_number":481,"context_line":"                    self.info_cache \u003d self.info_cache"},{"line_number":482,"context_line":"                elif self[field] !\u003d current[field]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F7sQ%3D","line":479,"in_reply_to":"AAAAUH%2F%2F71M%3D","updated":"2014-01-06 16:06:05.000000000","message":"Because it already has the same context and we don\u0027t usually pass in context explicitly to object methods unless it\u0027s an orphan or we need to do something with an admin context.","commit_id":"ed8440895dfb8cf63dbfc7f30dad8a0e3ff2d2ee"}],"nova/objects/instance_info_cache.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7d9c30604b4e9ea119713a2edbc1ae20c7d2cf85","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        current._context \u003d None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for field in self.fields:"},{"line_number":107,"context_line":"            if self.obj_attr_is_set(field):"},{"line_number":108,"context_line":"                self[field] \u003d current[field]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F7pw%3D","line":107,"updated":"2014-01-06 16:15:55.000000000","message":"In the Instance.refresh() method you check to see that self[field] !\u003d current[field], why not do that here also?","commit_id":"ed8440895dfb8cf63dbfc7f30dad8a0e3ff2d2ee"}]}