)]}'
{"id":"openstack%2Fnova~647310","triplet_id":"openstack%2Fnova~stable%2Fstein~Id46e76666b553a10ec4654d4418a9884975b5b95","project":"openstack/nova","branch":"stable/stein","topic":"bug/1808975","hashtags":[],"change_id":"Id46e76666b553a10ec4654d4418a9884975b5b95","subject":"Eventlet monkey patching should be as early as possible","status":"MERGED","created":"2019-03-25 08:22:35.000000000","updated":"2019-05-15 01:12:34.000000000","submitted":"2019-05-04 22:49:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"647310-1557010175322-76a6aaaf","meta_rev_id":"e0149e0cb39a53b9e4dc2dc9403e7d4f3aa3612a","_number":647310,"virtual_id_number":647310,"owner":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"date":"2019-03-25 10:06:23.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-03-25 11:03:21.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-04 22:49:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":0,"date":"2019-03-25 10:09:35.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-03-25 12:03:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2019-04-25 16:14:41.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2019-04-26 01:52:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-04-11 16:43:23.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-05-04 19:32:46.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-05-04 08:55:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":1,"date":"2019-04-25 16:50:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"date":"2019-03-25 21:09:51.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2019-03-25 08:22:35.000000000","_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-03-25 20:39:53.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-05-04 19:32:46.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":0,"date":"2019-04-25 17:04:15.000000000","_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-25 08:22:35.000000000","updated_by":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"reviewer":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"state":"REVIEWER"},{"updated":"2019-03-25 10:06:23.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-03-25 10:09:35.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-03-25 11:03:21.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-03-25 12:03:10.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-03-25 20:39:53.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-03-25 21:09:51.000000000","updated_by":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"reviewer":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"state":"REVIEWER"},{"updated":"2019-04-11 16:43:23.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-04-25 16:14:41.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-04-25 16:50:59.000000000","updated_by":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"reviewer":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"state":"REVIEWER"},{"updated":"2019-04-25 17:04:15.000000000","updated_by":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"reviewer":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"state":"REVIEWER"},{"updated":"2019-04-26 01:52:18.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-05-04 08:55:56.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2019-05-04 19:32:46.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-04 22:49:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bb0f5503871a9d3fa1018e60a560ccfb35c6fcca","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-03-25 08:22:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a481ba7fb764f6219f094433566c7c6ed7bad47","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-25 09:50:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/10/647310/1/check/openstack-tox-cover/56567f6/cover/ : SUCCESS in 15m 55s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/647310/1/check/openstack-tox-lower-constraints/5735f8a/ : SUCCESS in 12m 08s\n- openstack-tox-pep8 http://logs.openstack.org/10/647310/1/check/openstack-tox-pep8/2be010e/ : SUCCESS in 10m 25s\n- openstack-tox-py27 http://logs.openstack.org/10/647310/1/check/openstack-tox-py27/4816139/ : SUCCESS in 12m 06s\n- openstack-tox-py35 http://logs.openstack.org/10/647310/1/check/openstack-tox-py35/07b747c/ : SUCCESS in 12m 29s\n- openstack-tox-py36 http://logs.openstack.org/10/647310/1/check/openstack-tox-py36/f160291/ : SUCCESS in 12m 05s\n- openstack-tox-py37 http://logs.openstack.org/10/647310/1/check/openstack-tox-py37/bc66541/ : SUCCESS in 11m 41s\n- openstack-tox-docs http://logs.openstack.org/10/647310/1/check/openstack-tox-docs/cf3aa6a/html/ : SUCCESS in 5m 57s\n- neutron-grenade-multinode http://logs.openstack.org/10/647310/1/check/neutron-grenade-multinode/0e2eb2e/ : SUCCESS in 1h 00m 55s\n- nova-grenade-live-migration http://logs.openstack.org/10/647310/1/check/nova-grenade-live-migration/f764e86/ : SUCCESS in 1h 05m 45s\n- nova-live-migration http://logs.openstack.org/10/647310/1/check/nova-live-migration/a64dd41/ : SUCCESS in 1h 09m 36s\n- nova-next http://logs.openstack.org/10/647310/1/check/nova-next/c311d57/ : SUCCESS in 1h 24m 59s\n- nova-tox-functional http://logs.openstack.org/10/647310/1/check/nova-tox-functional/a96e581/ : SUCCESS in 18m 50s\n- nova-tox-functional-py35 http://logs.openstack.org/10/647310/1/check/nova-tox-functional-py35/5e6aaea/ : SUCCESS in 18m 43s","accounts_in_message":[],"_revision_number":1},{"id":"8955a84e650fcb45647b42061cc17e864786f57d","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-03-25 10:06:23.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/647310/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/fe4d782 : FAILURE in 38s","accounts_in_message":[],"_revision_number":1},{"id":"366df2bf188bf253ef15f24ef6deff90d104d9c3","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-03-25 10:09:35.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/647310/1 : FAILURE in 10m 08s","accounts_in_message":[],"_revision_number":1},{"id":"609ed4aba53d3a28438d43ce531ad65a5c9b066a","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-03-25 11:03:21.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/10/647310/1/check/tempest-dsvm-full-xenial/eacca89/ : SUCCESS in 1h 08m 24s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/10/647310/1/check/tempest-dsvm-full-xenial-py3/9c455e7/ : SUCCESS in 1h 36m 42s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/10/647310/1/check/grenade-dsvm-xenial/71a230f/ : SUCCESS in 1h 02m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"817ebc13c2c0d10b482d52554dfb1093a588c264","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-03-25 12:03:10.000000000","message":"Patch Set 1: Code-Review+1\n\nThis backport will likely be needed in order to deploy tripleo with SSL; and probably more people would be affected by this bug.","accounts_in_message":[],"_revision_number":1},{"id":"2e0d4d39c593b8578a5afd64d3633e5be96ccef6","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-03-25 19:38:53.000000000","message":"Patch Set 1:\n\nBackport is clean, but this is considered risky for RC2 as it\u0027s a major re-work of eventlet monkey patching and we don\u0027t yet know if any other distros/deployments are affected (the potential of breaking them by changing this).\n\nThe current thinking we could consider backporting this as part of a normal stable release after the RC period is over, if we learn anyone else is affected by the issue.","accounts_in_message":[],"_revision_number":1},{"id":"044b12fae13c1c6b198a47f1f576987c7ef4537a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-26 13:20:46.000000000","message":"Patch Set 1:\n\nYeah as I said on the master branch change I\u0027d prefer to hold off on the stein GA for this and then backport it to stable/stein in a patch release later if other people/distros report the same issue.","accounts_in_message":[],"_revision_number":1},{"id":"7de87b8487e683c5c6d0e0924746e33089ba0537","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-04-02 10:29:07.000000000","message":"Patch Set 1: Code-Review+1\n\nJust catching up after PTO, while I could +2 this (that seems wrong prior to GA FWIW) the plan appears to be to let Stein GA without this and land it shortly there after *if* others also report the same problem. I\u0027m okay with that so just adding a meaningless +1 for now as the actual backport looks clean and correct.","accounts_in_message":[],"_revision_number":1},{"id":"baee2c1c72685781562890de615967879e824d9f","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-04-11 16:43:23.000000000","message":"Patch Set 1: Code-Review+2\n\nstable/stein is now open.","accounts_in_message":[],"_revision_number":1},{"id":"a6ebe9421820935c99dbfea6dc2f57bfff3b0fbf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 16:58:59.000000000","message":"Patch Set 1:\n\nI still don\u0027t really want to merge this soon after stein GA until / unless another distro comes along reporting the same issue.","accounts_in_message":[],"_revision_number":1},{"id":"f6dc3c7ef40ebcea3d0fb9881b3357bac1413ca6","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-04-23 12:50:09.000000000","message":"Patch Set 1:\n\nhttps://bugs.launchpad.net/nova/+bug/1825584 is reporting something similar with uWSGI in Stein but it isn\u0027t clear if this change has been applied in the bug report.","accounts_in_message":[],"_revision_number":1},{"id":"5d7b347cba97ced1bcaeef8f68137ffa90165792","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2019-04-25 13:16:55.000000000","message":"Patch Set 1:\n\nOk so this is affecting Ubuntu after all. Unfortunately just got the feedback today and the team also tested with this patch successfully.","accounts_in_message":[],"_revision_number":1},{"id":"17d7df98b10e9b15e6da204b1616acea2abb30ff","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-04-25 16:14:41.000000000","message":"Patch Set 1: Code-Review+1\n\nNow that this is affecting another distro, it seems worth the risk of going ahead with the backport.","accounts_in_message":[],"_revision_number":1},{"id":"e8c66c11bdc30e6d8ca30d5391ae90cdc132755f","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2019-04-25 16:50:59.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5f2c10f7ba213bd2811ad8b8ac3158439d3aeec2","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-04-26 01:52:18.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"dcb328bfc05f9f7801be91933c8fd882d9a236ab","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-05-04 08:55:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"341c0d207942b1e415bada732f5b384f77a155d1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-04 19:32:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nOK this has sat awhile both here and on master, and more than one distro is hitting it and says it fixes the problem for them, so yeah let\u0027s do it.","accounts_in_message":[],"_revision_number":1},{"id":"8b16cfb139e98055bd8487c796dbe2486f86c7c7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-04 19:33:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fcffd5836db2027947e42d08ca4edc9221243b88","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-04 22:49:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/10/647310/1/gate/grenade-py3/51644b2/ : SUCCESS in 59m 56s\n- tempest-full-py3 http://logs.openstack.org/10/647310/1/gate/tempest-full-py3/3653432/ : SUCCESS in 1h 36m 54s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/647310/1/gate/openstack-tox-lower-constraints/ec406d7/ : SUCCESS in 11m 37s\n- openstack-tox-pep8 http://logs.openstack.org/10/647310/1/gate/openstack-tox-pep8/c6528e0/ : SUCCESS in 9m 22s\n- openstack-tox-py27 http://logs.openstack.org/10/647310/1/gate/openstack-tox-py27/c14f533/ : SUCCESS in 12m 17s\n- openstack-tox-py35 http://logs.openstack.org/10/647310/1/gate/openstack-tox-py35/8a87fa3/ : SUCCESS in 14m 05s\n- openstack-tox-py36 http://logs.openstack.org/10/647310/1/gate/openstack-tox-py36/b8428e3/ : SUCCESS in 11m 05s\n- openstack-tox-py37 http://logs.openstack.org/10/647310/1/gate/openstack-tox-py37/d43d8a5/ : SUCCESS in 11m 58s\n- openstack-tox-docs http://logs.openstack.org/10/647310/1/gate/openstack-tox-docs/13e4a20/html/ : SUCCESS in 7m 14s\n- nova-grenade-live-migration http://logs.openstack.org/10/647310/1/gate/nova-grenade-live-migration/6fe23bb/ : SUCCESS in 1h 06m 41s\n- nova-live-migration http://logs.openstack.org/10/647310/1/gate/nova-live-migration/25577ec/ : SUCCESS in 47m 30s\n- nova-tox-functional http://logs.openstack.org/10/647310/1/gate/nova-tox-functional/cf69af0/ : SUCCESS in 20m 56s\n- nova-tox-functional-py35 http://logs.openstack.org/10/647310/1/gate/nova-tox-functional-py35/e5c57c6/ : SUCCESS in 25m 48s\n- nova-next http://logs.openstack.org/10/647310/1/gate/nova-next/6196851/ : SUCCESS in 1h 54m 49s\n- tempest-slow-py3 http://logs.openstack.org/10/647310/1/gate/tempest-slow-py3/a25ea16/ : SUCCESS in 2h 20m 37s","accounts_in_message":[],"_revision_number":1},{"id":"3cb77d171c0b8c5f66419a37881eb424bac1235a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-04 22:49:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"21a9d15c65851705583ef522eab4059c8864ee51","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-15 01:12:34.000000000","message":"Patch Set 1:\n\nI think everyone will be pleased to know that now starlingx is reporting this is breaking them:\n\nhttps://bugs.launchpad.net/nova/+bug/1829062","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d0f540742efc1004b4d2c64814dcc6f7b9f0ccf6","revisions":{"d0f540742efc1004b4d2c64814dcc6f7b9f0ccf6":{"kind":"REWORK","_number":1,"created":"2019-03-25 08:22:35.000000000","uploader":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"ref":"refs/changes/10/647310/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/647310/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/647310/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/647310/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/647310/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/647310/1"}}},"commit":{"parents":[{"commit":"ba01967bcf853d059a0a7d45c2005587f94ab400","subject":"Update .gitreview for stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba01967bcf853d059a0a7d45c2005587f94ab400"}]}],"author":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2019-01-30 15:10:25.000000000","tz":0},"committer":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-03-25 08:22:01.000000000","tz":60},"subject":"Eventlet monkey patching should be as early as possible","message":"Eventlet monkey patching should be as early as possible\n\nWe were seeing infinite recursion opening an ssl socket when running\nvarious combinations of python3, eventlet, and urllib3. It is not\nclear exactly what combination of versions are affected, but for\nbackground there is an example of this issue documented here:\n\nhttps://github.com/eventlet/eventlet/issues/371\n\nThe immediate cause in nova\u0027s case was that we were calling\neventlet.monkey_patch() after importing urllib3. Specifically, change\nIe7bf5d012e2ccbcd63c262ddaf739782afcdaf56 introduced the\nnova.utils.monkey_patch() method to make monkey patching common\nbetween WSGI and non-WSGI services. Unfortunately, before executing\nthis method you must first import nova.utils, which imports a large\nnumber of modules itself. Anything imported (transitively) by\nnova.utils would therefore be imported before monkey patching, which\nincluded urllib3. This triggers the infinite recursion problem\ndescribed above if you have an affected combination of library\nversions.\n\nWhile this specific issue may eventually be worked around or fixed in\neventlet or urllib3, it remains true that eventlet best practises are\nto monkey patch as early as possible, which we were not doing. To\navoid this and hopefully future similar issues, this change ensures\nthat monkey patching happens as early as possible, and only a minimum\nnumber of modules are imported first.\n\nThis change fixes monkey patching for both non-wsgi and wsgi callers:\n\n* Non-WSGI services (nova/cmd)\n\n  This is fixed by using the new monkey_patch module, which has minimal\n  dependencies.\n\n* WSGI services (nova/api/openstack)\n\n  This is fixed both by using the new monkey_patch module, and by moving\n  the patching point up one level so that it is done before importing\n  anything in nova/api/openstack/__init__.py.\n\n  This move causes issues for some external tools which load this path\n  from nova and now monkey patch where they previously did not. However,\n  it is unfortunately unavoidable to enable monkey patching for the wsgi\n  entry point without major restructuring. This change includes a\n  workaround for sphinx to avoid this issue.\n\nThis change has been through several iterations. I started with what\nseemed like the simplest and most obvious change, and moved on as I\ndiscovered more interactions which broke. It is clear that eventlet\nmonkey patching is extremely fragile, especially when done implicitly at\nmodule load time as we do. I would advocate a code restructure to\nimprove this situation, but I think the time would be better spent\nremoving the eventlet dependency entirely.\n\nCo-authored-by: Lee Yarwood \u003clyarwood@redhat.com\u003e\n\nCloses-Bug: #1808975\nCloses-Bug: #1808951\nChange-Id: Id46e76666b553a10ec4654d4418a9884975b5b95\n(cherry picked from commit 3c5e2b0e9fac985294a949852bb8c83d4ed77e04)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d0f540742efc1004b4d2c64814dcc6f7b9f0ccf6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d0f540742efc1004b4d2c64814dcc6f7b9f0ccf6"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
