)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5307439a471ec0ba8b125a79b1c8e80c2609a2d4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change refactors the error handling around the _confirm_resize"},{"line_number":18,"context_line":"call so the big nesting for _error_out_instance_on_exception is"},{"line_number":19,"context_line":"moved to confirm_resiez and then a try/finally is added around"},{"line_number":20,"context_line":"_confirm_resize so we can be sure to try and cleanup the allocations"},{"line_number":21,"context_line":"even if _confirm_resize fails in some obscure way. If _confirm_resize"},{"line_number":22,"context_line":"does fail, the error gets re-raised along with logging a traceback"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_e741e2a7","line":19,"range":{"start_line":19,"start_character":17,"end_line":19,"end_character":23},"updated":"2019-03-25 18:18:10.000000000","message":"resize","commit_id":"1a5cee4d5a1d65af1d3cb2f047e9b2e2a52ac5d6"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b50a84a71bb5f09875dfe6039c62b9aa34803f6a","unresolved":false,"context_lines":[{"line_number":3993,"context_line":"                            \u0027Resource allocations in the placement service \u0027"},{"line_number":3994,"context_line":"                            \u0027will be removed regardless because the instance \u0027"},{"line_number":3995,"context_line":"                            \u0027is now on the destination host %s. You can try \u0027"},{"line_number":3996,"context_line":"                            \u0027hard rebooting the instance to correct its \u0027"},{"line_number":3997,"context_line":"                            \u0027state.\u0027, self.host, migration.dest_compute,"},{"line_number":3998,"context_line":"                            instance\u003dinstance)"},{"line_number":3999,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_27a04a90","line":3996,"updated":"2019-03-25 18:08:12.000000000","message":"Resetting the state to ACTIVE in the API could also work, but hard reboot would likely be more robust.\n\nMaybe this isn\u0027t worth handling and logging something here and we just have the try/finally block?","commit_id":"1a5cee4d5a1d65af1d3cb2f047e9b2e2a52ac5d6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5307439a471ec0ba8b125a79b1c8e80c2609a2d4","unresolved":false,"context_lines":[{"line_number":3993,"context_line":"                            \u0027Resource allocations in the placement service \u0027"},{"line_number":3994,"context_line":"                            \u0027will be removed regardless because the instance \u0027"},{"line_number":3995,"context_line":"                            \u0027is now on the destination host %s. You can try \u0027"},{"line_number":3996,"context_line":"                            \u0027hard rebooting the instance to correct its \u0027"},{"line_number":3997,"context_line":"                            \u0027state.\u0027, self.host, migration.dest_compute,"},{"line_number":3998,"context_line":"                            instance\u003dinstance)"},{"line_number":3999,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_4758f688","line":3996,"in_reply_to":"5fc1f717_27a04a90","updated":"2019-03-25 18:18:10.000000000","message":"Meh, what harm?","commit_id":"1a5cee4d5a1d65af1d3cb2f047e9b2e2a52ac5d6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4dbbef2710a7e0bded464e0b5b5b1be2c5e52d94","unresolved":false,"context_lines":[{"line_number":3993,"context_line":"                            \u0027Resource allocations in the placement service \u0027"},{"line_number":3994,"context_line":"                            \u0027will be removed regardless because the instance \u0027"},{"line_number":3995,"context_line":"                            \u0027is now on the destination host %s. You can try \u0027"},{"line_number":3996,"context_line":"                            \u0027hard rebooting the instance to correct its \u0027"},{"line_number":3997,"context_line":"                            \u0027state.\u0027, self.host, migration.dest_compute,"},{"line_number":3998,"context_line":"                            instance\u003dinstance)"},{"line_number":3999,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_ca8dcb7c","line":3996,"in_reply_to":"5fc1f717_4758f688","updated":"2019-03-25 18:27:58.000000000","message":"\u003e Meh, what harm?\n\nAt worst the instance is running on the dest and you don\u0027t need to hard reboot it at all, just reset the status to ACTIVE. Now if the instance was resized while stopped, it will still be stopped on the dest and you can\u0027t reset to stopped, and setting it to ACTIVE in the API would just automatically get it stopped by the power sync task in the compute, so it\u0027s kind of complicated. Anyway, that\u0027s why I just tried to leave this as a hint but the operator can ignore it of course.","commit_id":"1a5cee4d5a1d65af1d3cb2f047e9b2e2a52ac5d6"}]}