)]}'
{"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83f6ee1a1199d731eb8d2fe33c6a998804ade5da","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # NOTE(mikal): this is used to stub away privsep helpers"},{"line_number":49,"context_line":"        def fake_noop(*args, **kwargs):"},{"line_number":50,"context_line":"            return None"},{"line_number":51,"context_line":"        self.stub_out(\u0027nova.privsep.utils.supports_direct_io\u0027, fake_noop)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Mock the \u0027get_connection\u0027 function, as we\u0027re going to need to provide"},{"line_number":54,"context_line":"        # custom capabilities for each test"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_029d9856","line":51,"updated":"2019-03-29 18:00:49.000000000","message":"this retruns True by default and otherwise returns False\nbut never non so this should proably return True.\n\nhttps://github.com/openstack/nova/blob/10fd3782e104cfba50d68e75bac2edc1ad3b262a/nova/privsep/utils.py#L45-L92\n\nThis stub is returning None which will never happen and might \nlead to error in the future if supports_direct_io ever does start using None as a return value.","commit_id":"749f83568a368343924b0558e51ce1984ad3903e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cade0ff280d0f0eb203c6d3b9b047a27291235a1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # NOTE(mikal): this is used to stub away privsep helpers"},{"line_number":49,"context_line":"        def fake_noop(*args, **kwargs):"},{"line_number":50,"context_line":"            return None"},{"line_number":51,"context_line":"        self.stub_out(\u0027nova.privsep.utils.supports_direct_io\u0027, fake_noop)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Mock the \u0027get_connection\u0027 function, as we\u0027re going to need to provide"},{"line_number":54,"context_line":"        # custom capabilities for each test"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_840c25ed","line":51,"in_reply_to":"5fc1f717_029d9856","updated":"2019-04-01 09:48:51.000000000","message":"Done","commit_id":"749f83568a368343924b0558e51ce1984ad3903e"}]}