)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a613a0729a298b8c206db1b45c10d9bd3a55a3cc","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"But almost all of the ones in unit tests are just wasting time. So this"},{"line_number":19,"context_line":"commit mocks time.sleep() in those."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] If971c31380b1c5d1cc242846fb9c0779f03bbd19"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I8ca348ab1a671b943c17dfec9ada2103aeb7cd84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fb8cfa7_d0a9a423","line":20,"updated":"2019-06-14 16:51:22.000000000","message":"A comparison of runtimes would have been helpful here, but I\u0027m onboard with the general idea so meh","commit_id":"610d7e486accf2d0f733b2f890ecdc9fef129c8e"}],"nova/tests/unit/test_utils.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"981d96fa0a00815088020ef466cee31022a5e400","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        self.assertNotIn(filename, utils._FILE_CACHE)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"class RootwrapDaemonTestCase(test.NoDBTestCase):"},{"line_number":294,"context_line":"    @mock.patch(\u0027oslo_rootwrap.client.Client\u0027)"},{"line_number":295,"context_line":"    def test_get_client(self, mock_client):"},{"line_number":296,"context_line":"        mock_conf \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_f65cd14d","line":293,"updated":"2019-03-29 19:39:20.000000000","message":"Why the change here? I don\u0027t doubt it\u0027s right, but I would think it would be a lot better to just do that in another patch for clarity. Since you\u0027re potentially doing things here that could uncover (or cause) subtle races at gate scale it would be bad to hide this inside I think.","commit_id":"21896678c6981c943ba2cdb30917db654acb90e1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"85f28bd41b036a3da272eb5cdea7013094bc17a0","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        self.assertNotIn(filename, utils._FILE_CACHE)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"class RootwrapDaemonTestCase(test.NoDBTestCase):"},{"line_number":294,"context_line":"    @mock.patch(\u0027oslo_rootwrap.client.Client\u0027)"},{"line_number":295,"context_line":"    def test_get_client(self, mock_client):"},{"line_number":296,"context_line":"        mock_conf \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1992eea0","line":293,"in_reply_to":"5fc1f717_f65cd14d","updated":"2019-03-29 20:00:34.000000000","message":"Oh, I was just correcting the spelling of the test class because I happened to notice it while I was searching for hits from the test results and not finding them due to this.\n\nThe name of a test case class is garbage in garbage out unless it\u0027s being subclassed, which this isn\u0027t.\n\nIt\u0027s also not worth burning a whole commit for IMO so I slid it in here. Happy to unwind it, though.","commit_id":"21896678c6981c943ba2cdb30917db654acb90e1"}],"nova/tests/unit/virt/disk/mount/test_nbd.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"981d96fa0a00815088020ef466cee31022a5e400","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            # Ensure that context switch happens before the device is marked"},{"line_number":283,"context_line":"            # as used. This will cause a failure without nbd-allocation-lock"},{"line_number":284,"context_line":"            # in place."},{"line_number":285,"context_line":"            time.sleep(0)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # We always choose the top device in find_unused - remove it now."},{"line_number":288,"context_line":"            free_devices.pop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_363819ed","line":285,"updated":"2019-03-29 19:39:20.000000000","message":"Just to be clear, if there isn\u0027t actually something waiting this will be a direct pass through, whereas before it would actually wait. I haven\u0027t really looked, but are we sure this is kosher?","commit_id":"21896678c6981c943ba2cdb30917db654acb90e1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"85f28bd41b036a3da272eb5cdea7013094bc17a0","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            # Ensure that context switch happens before the device is marked"},{"line_number":283,"context_line":"            # as used. This will cause a failure without nbd-allocation-lock"},{"line_number":284,"context_line":"            # in place."},{"line_number":285,"context_line":"            time.sleep(0)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # We always choose the top device in find_unused - remove it now."},{"line_number":288,"context_line":"            free_devices.pop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_19c0ae7c","line":285,"in_reply_to":"5fc1f717_363819ed","updated":"2019-03-29 20:00:34.000000000","message":"Yeah, the test is just wanting to ensure that a context switch (yield) happens, which is by definition what sleep(0) does. But I agree this one is more invasive than the rest and should probably be done separately (if at all).","commit_id":"21896678c6981c943ba2cdb30917db654acb90e1"}],"nova/tests/unit/virt/libvirt/volume/test_mount.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c6cafc4ff8f904567b443fdd35c4858d4da99a96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fc1f717_2b65f145","updated":"2019-04-01 21:44:15.000000000","message":"This file needs to be reverted. The sleeps are legit.","commit_id":"e82f6b0f6bbb0fbb12e18ccc88329b0ae49e1a15"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ad88b99ca885856b104f4d5fde9f74c72019a095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fc1f717_e6b400d4","in_reply_to":"5fc1f717_2b65f145","updated":"2019-04-01 22:34:37.000000000","message":"Done","commit_id":"e82f6b0f6bbb0fbb12e18ccc88329b0ae49e1a15"}]}