)]}'
{"id":"openstack%2Fnova~648762","triplet_id":"openstack%2Fnova~master~I8ca348ab1a671b943c17dfec9ada2103aeb7cd84","project":"openstack/nova","branch":"master","topic":"mock_sleeps","hashtags":[],"change_id":"I8ca348ab1a671b943c17dfec9ada2103aeb7cd84","subject":"Mock time.sleep() in unit tests","status":"MERGED","created":"2019-03-29 19:29:51.000000000","updated":"2019-06-14 21:53:17.000000000","submitted":"2019-06-14 21:53:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"648762-1560549197464-e3a0d8e9","meta_rev_id":"58f2589916982c4316947fa11c8d31d14777f3d5","_number":648762,"virtual_id_number":648762,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-14 21:53:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2019-04-02 11:34:49.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"date":"2019-04-02 01:02:44.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},{"value":0,"date":"2019-04-02 02:39:24.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"date":"2019-04-02 02:45:31.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-04-03 22:32:29.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2019-04-02 10:07:48.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-14 16:51:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-14 07:54:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-05-13 22:09:33.000000000","_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-14 06:46:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-14 16:51:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-29 20:03:52.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-03-29 22:52:07.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-02 01:02:44.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-02 02:39:24.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-02 02:45:31.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-02 10:07:48.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-04-02 11:34:49.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-04-03 22:32:29.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-13 22:09:33.000000000","updated_by":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"reviewer":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"state":"REVIEWER"},{"updated":"2019-05-14 06:46:36.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-05-14 07:54:57.000000000","updated_by":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"reviewer":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"state":"REVIEWER"},{"updated":"2019-06-14 16:51:22.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-06-14 21:53:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"310011343bbba2808375f816b5d85126ca703361","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-29 19:29:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"74c70389cac4b74a47ca2d0e654d6a72f4c14857","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-03-29 19:30:21.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"981d96fa0a00815088020ef466cee31022a5e400","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-03-29 19:39:20.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nQuestions inline but otherwise I\u0027m happy to support this as an incremental step :)","accounts_in_message":[],"_revision_number":1},{"id":"85f28bd41b036a3da272eb5cdea7013094bc17a0","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-29 20:00:34.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"31b8758ec88f094d74bf13f68f206a8a11279171","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-29 20:02:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e08aca61667a08999eef9702112d6549648f2b80","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-03-29 20:03:25.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"fefc0f9d48f38f909d15510e1bde15748d8cbeb2","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-03-29 20:03:52.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"417f62764d2b0a18f537df0914b9465723be65fb","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-03-29 21:07:48.000000000","message":"Patch Set 2:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-29709 : SUCCESS in 1h 04m 26s","accounts_in_message":[],"_revision_number":2},{"id":"1284c5472b62f00d5da69ab8251199012ddf315e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-03-29 22:13:55.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/648762/2 : SUCCESS in 2h 10m 13s","accounts_in_message":[],"_revision_number":2},{"id":"0c91d1f0872eeb6a5f424e58f2e361a43e8e48a2","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-03-29 22:52:07.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/62/648762/2/check/nova-out-of-tree-pvm/3279be0 : FAILURE in 2h 11m 08s\n- nova-in-tree-pvm http://184.172.12.213/62/648762/2/check/nova-in-tree-pvm/4ed364c : FAILURE in 2h 12m 20s","accounts_in_message":[],"_revision_number":2},{"id":"5b3d9ec2e3251af21f879456019dc8ecd4d4c10e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-29 23:25:23.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/62/648762/2/check/openstack-tox-cover/c8e2ee8/ : RETRY_LIMIT in 58m 52s\n- openstack-tox-lower-constraints http://logs.openstack.org/62/648762/2/check/openstack-tox-lower-constraints/d7af5b3/ : SUCCESS in 12m 26s\n- openstack-tox-pep8 http://logs.openstack.org/62/648762/2/check/openstack-tox-pep8/cd37426/ : SUCCESS in 9m 16s\n- openstack-tox-py27 http://logs.openstack.org/62/648762/2/check/openstack-tox-py27/71544c9/ : SUCCESS in 13m 41s\n- openstack-tox-py35 http://logs.openstack.org/62/648762/2/check/openstack-tox-py35/8dc74d8/ : SUCCESS in 15m 24s\n- openstack-tox-py36 http://logs.openstack.org/62/648762/2/check/openstack-tox-py36/d1fe857/ : FAILURE in 14m 31s\n- openstack-tox-py37 http://logs.openstack.org/62/648762/2/check/openstack-tox-py37/9306cad/ : SUCCESS in 14m 54s\n- openstack-tox-docs http://logs.openstack.org/62/648762/2/check/openstack-tox-docs/cfa182e/html/ : SUCCESS in 6m 53s\n- nova-tox-functional http://logs.openstack.org/62/648762/2/check/nova-tox-functional/6d64916/ : SUCCESS in 18m 10s\n- nova-tox-functional-py35 http://logs.openstack.org/62/648762/2/check/nova-tox-functional-py35/e8097e3/ : SUCCESS in 21m 00s","accounts_in_message":[],"_revision_number":2},{"id":"761f102a644a4ea6d49b0dd1d2c8f363d1f157f0","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-04-01 19:17:37.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"bda3c1491da4ffb98236c8a4948cb879b30820c6","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-04-01 19:18:31.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6f3a7c00bdfb60d756584a4d2a6547f79cef7f1c","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-04-01 19:21:21.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-29779 : FAILURE in 3m 12s","accounts_in_message":[],"_revision_number":3},{"id":"8d174df1b60411d5ac0e3fd5646c11decd2c83d5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-01 21:38:04.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/648762/3 : SUCCESS in 2h 19m 35s","accounts_in_message":[],"_revision_number":3},{"id":"172d3f1424b2c18728f618a7c9e316df17445b8a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-01 21:41:23.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/62/648762/3/check/openstack-tox-cover/071074f/cover/ : SUCCESS in 17m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/62/648762/3/check/openstack-tox-lower-constraints/d9625a8/ : SUCCESS in 14m 09s\n- openstack-tox-pep8 http://logs.openstack.org/62/648762/3/check/openstack-tox-pep8/80153b7/ : SUCCESS in 10m 34s\n- openstack-tox-py27 http://logs.openstack.org/62/648762/3/check/openstack-tox-py27/39942d7/ : SUCCESS in 12m 35s\n- openstack-tox-py35 http://logs.openstack.org/62/648762/3/check/openstack-tox-py35/8a24227/ : FAILURE in 22m 57s\n- openstack-tox-py36 http://logs.openstack.org/62/648762/3/check/openstack-tox-py36/a59ed0b/ : SUCCESS in 12m 31s\n- openstack-tox-py37 http://logs.openstack.org/62/648762/3/check/openstack-tox-py37/25629ad/ : SUCCESS in 12m 37s\n- openstack-tox-docs http://logs.openstack.org/62/648762/3/check/openstack-tox-docs/c61177d/html/ : SUCCESS in 6m 29s\n- nova-tox-functional http://logs.openstack.org/62/648762/3/check/nova-tox-functional/7f10da7/ : SUCCESS in 20m 16s\n- nova-tox-functional-py35 http://logs.openstack.org/62/648762/3/check/nova-tox-functional-py35/fbf4b04/ : SUCCESS in 20m 54s","accounts_in_message":[],"_revision_number":3},{"id":"c6cafc4ff8f904567b443fdd35c4858d4da99a96","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-04-01 21:44:15.000000000","message":"Patch Set 3: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b7ba7c5d099bb35844f7112e53bdc9efabba8e4d","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-04-01 22:34:23.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"ad88b99ca885856b104f4d5fde9f74c72019a095","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-04-01 22:34:37.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b1a66790e6b1a09b3452ac2201af877b00c84c1f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-02 01:02:10.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/62/648762/4/check/openstack-tox-cover/a4838c9/cover/ : SUCCESS in 15m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/62/648762/4/check/openstack-tox-lower-constraints/6bf744a/ : SUCCESS in 10m 57s\n- openstack-tox-pep8 http://logs.openstack.org/62/648762/4/check/openstack-tox-pep8/a6a4d96/ : SUCCESS in 9m 57s\n- openstack-tox-py27 http://logs.openstack.org/62/648762/4/check/openstack-tox-py27/68fab87/ : SUCCESS in 12m 30s\n- openstack-tox-py35 http://logs.openstack.org/62/648762/4/check/openstack-tox-py35/9dfb803/ : SUCCESS in 13m 57s\n- openstack-tox-py36 http://logs.openstack.org/62/648762/4/check/openstack-tox-py36/6f921f7/ : SUCCESS in 13m 17s\n- openstack-tox-py37 http://logs.openstack.org/62/648762/4/check/openstack-tox-py37/758029d/ : SUCCESS in 11m 48s\n- openstack-tox-docs http://logs.openstack.org/62/648762/4/check/openstack-tox-docs/a1bd21c/html/ : SUCCESS in 6m 21s\n- nova-tox-functional http://logs.openstack.org/62/648762/4/check/nova-tox-functional/71e956b/ : SUCCESS in 21m 29s\n- nova-tox-functional-py35 http://logs.openstack.org/62/648762/4/check/nova-tox-functional-py35/9d66e34/ : SUCCESS in 25m 28s","accounts_in_message":[],"_revision_number":4},{"id":"c3a10f0054ca6173e8689a3e0ea470d8ff98ebea","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-04-02 01:02:44.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/62/648762/4/check/EMC_VxFlexOS_NOVA/a266b71/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-dell-emc-vxflexos\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/Dell_EMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":4},{"id":"4fba0cbe5c1243e77eb3fa7a482c904914964e04","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-04-02 02:39:24.000000000","message":"Patch Set 4:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"149bf93e91884d12ac0a048746e4779c37beeb21","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-04-02 02:45:31.000000000","message":"Patch Set 4:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-62-648762-4 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":4},{"id":"5a646393e373a3d3bb55459cb36c057987e3ea73","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-02 10:07:48.000000000","message":"Patch Set 4:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/648762/4 : FAILURE in 50s","accounts_in_message":[],"_revision_number":4},{"id":"a9bcd24e0ed9ebc6f15f2e4c14e9d56f1a66e701","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-04-02 11:34:49.000000000","message":"Patch Set 4:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-29849 : SUCCESS in 2h 22m 20s","accounts_in_message":[],"_revision_number":4},{"id":"08629486bb99821bc7e8039220e8bf6413c68581","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-04-03 22:32:29.000000000","message":"Patch Set 4:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/62/648762/4/check-vote/ext-nova-zuul/b2a4e0e : FAILURE in 1h 10m 21s","accounts_in_message":[],"_revision_number":4},{"id":"cc92a1a54ecead467adbf80eaa12d02f4d3e954c","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2019-05-13 22:09:33.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"3cb8e0f0fc772a829091bfa3590893605dfee61d","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-05-14 06:46:36.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"10782909821d8d3aaf9e1307549412fd3e664ceb","author":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"date":"2019-05-14 07:54:57.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"a613a0729a298b8c206db1b45c10d9bd3a55a3cc","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-14 16:51:22.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"3cf2c04f9f9a004232f9fd3bce987371afc12fcc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 16:52:55.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"3bdd750172090ea6d997d6c6bec05b9c876713b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 21:53:15.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/62/648762/4/gate/openstack-tox-lower-constraints/167d535/ : SUCCESS in 15m 40s\n- openstack-tox-pep8 http://logs.openstack.org/62/648762/4/gate/openstack-tox-pep8/3e15199/ : SUCCESS in 10m 32s\n- openstack-tox-py27 http://logs.openstack.org/62/648762/4/gate/openstack-tox-py27/efbc870/ : SUCCESS in 12m 56s\n- openstack-tox-py36 http://logs.openstack.org/62/648762/4/gate/openstack-tox-py36/140b26e/ : SUCCESS in 12m 42s\n- openstack-tox-py37 http://logs.openstack.org/62/648762/4/gate/openstack-tox-py37/3cfe71d/ : SUCCESS in 17m 42s\n- openstack-tox-docs http://logs.openstack.org/62/648762/4/gate/openstack-tox-docs/89947cb/html/ : SUCCESS in 6m 18s\n- nova-tox-functional http://logs.openstack.org/62/648762/4/gate/nova-tox-functional/d5efb57/ : SUCCESS in 21m 48s\n- nova-tox-functional-py36 http://logs.openstack.org/62/648762/4/gate/nova-tox-functional-py36/5273f5e/ : SUCCESS in 16m 19s","accounts_in_message":[],"_revision_number":4},{"id":"fe0ae13acf95401d473222cbd437c02705a1a35c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 21:53:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"610d7e486accf2d0f733b2f890ecdc9fef129c8e","revisions":{"21896678c6981c943ba2cdb30917db654acb90e1":{"kind":"REWORK","_number":1,"created":"2019-03-29 19:29:51.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/62/648762/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/648762/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/648762/1"}}},"commit":{"parents":[{"commit":"10fd3782e104cfba50d68e75bac2edc1ad3b262a","subject":"Merge \"Fix exception type in test_boot_reschedule_fill_provider_mapping_raises\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/10fd3782e104cfba50d68e75bac2edc1ad3b262a"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-29 19:25:37.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-29 19:25:37.000000000","tz":-300},"subject":"Mock time.sleep() in unit tests","message":"Mock time.sleep() in unit tests\n\nA previous patch [1] attempted to make sure that tests would never\nsleep() unless they really meant to. That turned out to be too invasive,\nand too difficult to get right. But it revealed all of the places in the\nnova codebase where real nonzero sleep()s were being done in test code.\n\nSome of those are necessary: specifically the ones in functional test\ncode, which are doing things like _wait_for_server_status while other\nthreads are building (almost) real instances and such.\n\nBut the ones in unit tests are just wasting time. So this commit mocks\ntime.sleep() in those.\n\n[1] If971c31380b1c5d1cc242846fb9c0779f03bbd19\n\nChange-Id: I8ca348ab1a671b943c17dfec9ada2103aeb7cd84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/21896678c6981c943ba2cdb30917db654acb90e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/21896678c6981c943ba2cdb30917db654acb90e1"}]},"branch":"refs/heads/master"},"74f570cf5d97dd5e278a8341d45619f5f7edf470":{"kind":"REWORK","_number":2,"created":"2019-03-29 20:02:54.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/62/648762/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/648762/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/648762/2"}}},"commit":{"parents":[{"commit":"10fd3782e104cfba50d68e75bac2edc1ad3b262a","subject":"Merge \"Fix exception type in test_boot_reschedule_fill_provider_mapping_raises\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/10fd3782e104cfba50d68e75bac2edc1ad3b262a"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-29 19:25:37.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-29 20:02:50.000000000","tz":-300},"subject":"Mock time.sleep() in unit tests","message":"Mock time.sleep() in unit tests\n\nA previous patch [1] attempted to make sure that tests would never\nsleep() unless they really meant to. That turned out to be too invasive,\nand too difficult to get right. But it revealed all of the places in the\nnova codebase where real nonzero sleep()s were being done in test code.\n\nSome of those are necessary: specifically the ones in functional test\ncode, which are doing things like _wait_for_server_status while other\nthreads are building (almost) real instances and such.\n\nBut the ones in unit tests are just wasting time. So this commit mocks\ntime.sleep() in those.\n\n[1] If971c31380b1c5d1cc242846fb9c0779f03bbd19\n\nChange-Id: I8ca348ab1a671b943c17dfec9ada2103aeb7cd84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/74f570cf5d97dd5e278a8341d45619f5f7edf470"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/74f570cf5d97dd5e278a8341d45619f5f7edf470"}]},"branch":"refs/heads/master"},"e82f6b0f6bbb0fbb12e18ccc88329b0ae49e1a15":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2019-04-01 19:17:37.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/62/648762/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/648762/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/648762/3"}}},"commit":{"parents":[{"commit":"bed9d49163a70e063835d49aff3757f2c1a798f3","subject":"Pass --nic when creating servers in evacuate integration test script","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bed9d49163a70e063835d49aff3757f2c1a798f3"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-29 19:25:37.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-04-01 19:17:37.000000000","tz":0},"subject":"Mock time.sleep() in unit tests","message":"Mock time.sleep() in unit tests\n\nA previous patch [1] attempted to make sure that tests would never\nsleep() unless they really meant to. That turned out to be too invasive,\nand too difficult to get right. But it revealed all of the places in the\nnova codebase where real nonzero sleep()s were being done in test code.\n\nSome of those are necessary: specifically the ones in functional test\ncode, which are doing things like _wait_for_server_status while other\nthreads are building (almost) real instances and such.\n\nBut the ones in unit tests are just wasting time. So this commit mocks\ntime.sleep() in those.\n\n[1] If971c31380b1c5d1cc242846fb9c0779f03bbd19\n\nChange-Id: I8ca348ab1a671b943c17dfec9ada2103aeb7cd84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e82f6b0f6bbb0fbb12e18ccc88329b0ae49e1a15"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e82f6b0f6bbb0fbb12e18ccc88329b0ae49e1a15"}]},"branch":"refs/heads/master"},"610d7e486accf2d0f733b2f890ecdc9fef129c8e":{"kind":"REWORK","_number":4,"created":"2019-04-01 22:34:23.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/62/648762/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/648762/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/648762/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/648762/4"}}},"commit":{"parents":[{"commit":"bed9d49163a70e063835d49aff3757f2c1a798f3","subject":"Pass --nic when creating servers in evacuate integration test script","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bed9d49163a70e063835d49aff3757f2c1a798f3"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-29 19:25:37.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-04-01 22:33:49.000000000","tz":-300},"subject":"Mock time.sleep() in unit tests","message":"Mock time.sleep() in unit tests\n\nA previous patch [1] attempted to make sure that tests would never\nsleep() unless they really meant to. That turned out to be too invasive,\nand too difficult to get right. But it revealed all of the places in the\nnova codebase where real nonzero sleep()s were being done in test code.\n\nSome of those are necessary: specifically the ones in functional test\ncode, which are doing things like _wait_for_server_status while other\nthreads are building (almost) real instances and such.\n\nBut almost all of the ones in unit tests are just wasting time. So this\ncommit mocks time.sleep() in those.\n\n[1] If971c31380b1c5d1cc242846fb9c0779f03bbd19\n\nChange-Id: I8ca348ab1a671b943c17dfec9ada2103aeb7cd84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/610d7e486accf2d0f733b2f890ecdc9fef129c8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/610d7e486accf2d0f733b2f890ecdc9fef129c8e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}