)]}'
{"nova/objects/request_spec.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6c8ea43006d3d4c067e3fdbb6bbb4253b2644070","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            # though they should match."},{"line_number":451,"context_line":"            if key in [\u0027id\u0027, \u0027instance_uuid\u0027]:"},{"line_number":452,"context_line":"                setattr(spec, key, db_spec[key])"},{"line_number":453,"context_line":"            elif key \u003d\u003d \u0027ignore_hosts\u0027:"},{"line_number":454,"context_line":"                # NOTE(mriedem): Do not override the \u0027ignore_hosts\u0027"},{"line_number":455,"context_line":"                # field which is not persisted. It is not a lazy-loadable"},{"line_number":456,"context_line":"                # field. If it is not set, set None."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_86ae572c","line":453,"updated":"2019-04-12 21:01:32.000000000","message":"I probably would have just made this:\n\n elif key in (\u0027ignore_hosts\u0027,):\n\nso that it was minimally changed and setup for the future, but that\u0027s just a nit.","commit_id":"8f1773a7af273e2739843a804fb4fe718c0a242d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6a75174a21c0f6f2b9738ba19ec5dd13b56207b9","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            # though they should match."},{"line_number":451,"context_line":"            if key in [\u0027id\u0027, \u0027instance_uuid\u0027]:"},{"line_number":452,"context_line":"                setattr(spec, key, db_spec[key])"},{"line_number":453,"context_line":"            elif key \u003d\u003d \u0027ignore_hosts\u0027:"},{"line_number":454,"context_line":"                # NOTE(mriedem): Do not override the \u0027ignore_hosts\u0027"},{"line_number":455,"context_line":"                # field which is not persisted. It is not a lazy-loadable"},{"line_number":456,"context_line":"                # field. If it is not set, set None."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_01525114","line":453,"in_reply_to":"3fce034c_86ae572c","updated":"2019-04-12 21:14:48.000000000","message":"Same.","commit_id":"8f1773a7af273e2739843a804fb4fe718c0a242d"}],"nova/tests/unit/objects/test_request_spec.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6a75174a21c0f6f2b9738ba19ec5dd13b56207b9","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        # change something to make sure _save_in_db is called"},{"line_number":573,"context_line":"        expected_destination \u003d request_spec.Destination(host\u003d\u0027sample-host\u0027)"},{"line_number":574,"context_line":"        req_obj.requested_destination \u003d expected_destination"},{"line_number":575,"context_line":"        expected_retry \u003d objects.SchedulerRetries("},{"line_number":576,"context_line":"            num_attempts\u003d2,"},{"line_number":577,"context_line":"            hosts\u003dobjects.ComputeNodeList(objects\u003d["},{"line_number":578,"context_line":"                objects.ComputeNode(host\u003d\u0027host1\u0027, hypervisor_hostname\u003d\u0027node1\u0027),"},{"line_number":579,"context_line":"                objects.ComputeNode(host\u003d\u0027host2\u0027, hypervisor_hostname\u003d\u0027node2\u0027),"},{"line_number":580,"context_line":"            ]))"},{"line_number":581,"context_line":"        req_obj.retry \u003d expected_retry"},{"line_number":582,"context_line":"        req_obj.ignore_hosts \u003d [uuids.ignored_host]"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        orig_save_in_db \u003d request_spec.RequestSpec._save_in_db"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_41b5b930","line":581,"range":{"start_line":575,"start_character":0,"end_line":581,"end_character":38},"updated":"2019-04-12 21:14:48.000000000","message":"Seems like these shouldn\u0027t be here, they\u0027re unused.","commit_id":"8f1773a7af273e2739843a804fb4fe718c0a242d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cfc7389c05d9865bda46365bdbca293c4a7b6df8","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        # change something to make sure _save_in_db is called"},{"line_number":573,"context_line":"        expected_destination \u003d request_spec.Destination(host\u003d\u0027sample-host\u0027)"},{"line_number":574,"context_line":"        req_obj.requested_destination \u003d expected_destination"},{"line_number":575,"context_line":"        expected_retry \u003d objects.SchedulerRetries("},{"line_number":576,"context_line":"            num_attempts\u003d2,"},{"line_number":577,"context_line":"            hosts\u003dobjects.ComputeNodeList(objects\u003d["},{"line_number":578,"context_line":"                objects.ComputeNode(host\u003d\u0027host1\u0027, hypervisor_hostname\u003d\u0027node1\u0027),"},{"line_number":579,"context_line":"                objects.ComputeNode(host\u003d\u0027host2\u0027, hypervisor_hostname\u003d\u0027node2\u0027),"},{"line_number":580,"context_line":"            ]))"},{"line_number":581,"context_line":"        req_obj.retry \u003d expected_retry"},{"line_number":582,"context_line":"        req_obj.ignore_hosts \u003d [uuids.ignored_host]"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        orig_save_in_db \u003d request_spec.RequestSpec._save_in_db"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_010a51d1","line":581,"range":{"start_line":575,"start_character":0,"end_line":581,"end_character":38},"in_reply_to":"3fce034c_41b5b930","updated":"2019-04-12 21:21:19.000000000","message":"This is a result of porting the test from rocky since it didn\u0027t exist in queens and I tried to trim it down but missed this one. I could remove it but then I likely have to re-do the cherry picks downstream from this as well (pike and ocata).","commit_id":"8f1773a7af273e2739843a804fb4fe718c0a242d"}]}