)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-02 18:27:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"gracefuly handel none nic VFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"as part of adding support for bandwidth based schduling"},{"line_number":10,"context_line":"I038867c4094d79ae4a20615ab9c9f9e38fcc2e0a intoduced"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_413a8b98","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":16},"updated":"2019-04-02 17:45:32.000000000","message":"libvirt: gracefully handle","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1edc11f1af1f067ed69e050185b5e2bffe4a7b99","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-02 18:27:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"gracefuly handel none nic VFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"as part of adding support for bandwidth based schduling"},{"line_number":10,"context_line":"I038867c4094d79ae4a20615ab9c9f9e38fcc2e0a intoduced"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_dc96623f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":16},"in_reply_to":"5fc1f717_413a8b98","updated":"2019-04-02 18:42:25.000000000","message":"ill add this in v3\nim going to go file the nova but now.","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"gracefuly handel none nic VFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"as part of adding support for bandwidth based schduling"},{"line_number":10,"context_line":"I038867c4094d79ae4a20615ab9c9f9e38fcc2e0a intoduced"},{"line_number":11,"context_line":"automatic discovery of parent netdev names for pci"},{"line_number":12,"context_line":"virtual functions. nova pci passthough support was originally"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_0144831a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":2},"updated":"2019-04-02 17:45:32.000000000","message":"As","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"gracefuly handel none nic VFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"as part of adding support for bandwidth based schduling"},{"line_number":10,"context_line":"I038867c4094d79ae4a20615ab9c9f9e38fcc2e0a intoduced"},{"line_number":11,"context_line":"automatic discovery of parent netdev names for pci"},{"line_number":12,"context_line":"virtual functions. nova pci passthough support was originally"},{"line_number":13,"context_line":"developed for intel QAT devices and other non nics. The pci sig"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_a1480f2e","line":10,"range":{"start_line":10,"start_character":42,"end_line":10,"end_character":51},"updated":"2019-04-02 17:45:32.000000000","message":"introduced","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"automatic discovery of parent netdev names for pci"},{"line_number":12,"context_line":"virtual functions. nova pci passthough support was originally"},{"line_number":13,"context_line":"developed for intel QAT devices and other non nics. The pci sig"},{"line_number":14,"context_line":"sriov specifcation while most often used by nic vendors to"},{"line_number":15,"context_line":"virtualise a nic in hardware was designed for device of any"},{"line_number":16,"context_line":"pcie class. Intels QAT device and other acclerator like AMD\u0027s"},{"line_number":17,"context_line":"SRIOV based VGPU have therfor been regress by the intoducion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_814f1333","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":18},"updated":"2019-04-02 17:45:32.000000000","message":"specification","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"developed for intel QAT devices and other non nics. The pci sig"},{"line_number":14,"context_line":"sriov specifcation while most often used by nic vendors to"},{"line_number":15,"context_line":"virtualise a nic in hardware was designed for device of any"},{"line_number":16,"context_line":"pcie class. Intels QAT device and other acclerator like AMD\u0027s"},{"line_number":17,"context_line":"SRIOV based VGPU have therfor been regress by the intoducion"},{"line_number":18,"context_line":"of the new parent_ifname lookup code."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_e157f7c9","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":50},"updated":"2019-04-02 17:45:32.000000000","message":"accelerators","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sriov specifcation while most often used by nic vendors to"},{"line_number":15,"context_line":"virtualise a nic in hardware was designed for device of any"},{"line_number":16,"context_line":"pcie class. Intels QAT device and other acclerator like AMD\u0027s"},{"line_number":17,"context_line":"SRIOV based VGPU have therfor been regress by the intoducion"},{"line_number":18,"context_line":"of the new parent_ifname lookup code."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change simply catchs the excpetion that would be raised"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_616b0785","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":60},"updated":"2019-04-02 17:45:32.000000000","message":"introduction","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sriov specifcation while most often used by nic vendors to"},{"line_number":15,"context_line":"virtualise a nic in hardware was designed for device of any"},{"line_number":16,"context_line":"pcie class. Intels QAT device and other acclerator like AMD\u0027s"},{"line_number":17,"context_line":"SRIOV based VGPU have therfor been regress by the intoducion"},{"line_number":18,"context_line":"of the new parent_ifname lookup code."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change simply catchs the excpetion that would be raised"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_c16e7b95","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":42},"updated":"2019-04-02 17:45:32.000000000","message":"regressed","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sriov specifcation while most often used by nic vendors to"},{"line_number":15,"context_line":"virtualise a nic in hardware was designed for device of any"},{"line_number":16,"context_line":"pcie class. Intels QAT device and other acclerator like AMD\u0027s"},{"line_number":17,"context_line":"SRIOV based VGPU have therfor been regress by the intoducion"},{"line_number":18,"context_line":"of the new parent_ifname lookup code."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change simply catchs the excpetion that would be raised"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_a171ef79","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":29},"updated":"2019-04-02 17:45:32.000000000","message":"therefore","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b362c5b9a8fd3ce210bb8f9c5fe6933bc2bae67a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"SRIOV based VGPU have therfor been regress by the intoducion"},{"line_number":18,"context_line":"of the new parent_ifname lookup code."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change simply catchs the excpetion that would be raised"},{"line_number":21,"context_line":"when pci_utils.get_ifname_by_pci_address is called on a non"},{"line_number":22,"context_line":"nic allowing a graceful fallback to the previous behavior."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_2103bfc0","line":20,"range":{"start_line":20,"start_character":30,"end_line":20,"end_character":39},"updated":"2019-04-02 17:45:32.000000000","message":"exception","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d961e8a7d26e96932861e6f6b508248ab0d3e053","unresolved":false,"context_lines":[{"line_number":22,"context_line":"nic allowing a graceful fallback to the previous behavior."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ib3811f828246311d90b0e3ba71c162c03fb8fe5a"},{"line_number":25,"context_line":"Related-Bug: #1821938"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_81fdd3b2","line":25,"updated":"2019-04-02 17:46:36.000000000","message":"Need a nova bug for this. And tag it with stein-rc-potential.","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7cfb16f292766e66aac87838b5c4d98171f3ca5f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Libvirt: gracefully handle non-nic VFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of adding support for bandwidth based scheduling"},{"line_number":10,"context_line":"I038867c4094d79ae4a20615ab9c9f9e38fcc2e0a introduced"},{"line_number":11,"context_line":"automatic discovery of parent netdev names for PCIe"},{"line_number":12,"context_line":"virtual functions."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_57bd6d00","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":41},"updated":"2019-04-02 19:15:41.000000000","message":"✔","commit_id":"8cf401735ec885c07647a75731e694a1e798e3fe"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"24ae8d920ee30ccaf23152d36a337bf2d52d5485","unresolved":false,"context_lines":[{"line_number":6048,"context_line":"                    try:"},{"line_number":6049,"context_line":"                        parent_ifname \u003d pci_utils.get_ifname_by_pci_address("},{"line_number":6050,"context_line":"                            pci_address, pf_interface\u003dTrue)"},{"line_number":6051,"context_line":"                    except Exception:"},{"line_number":6052,"context_line":"                        pass"},{"line_number":6053,"context_line":"                    if parent_ifname:"},{"line_number":6054,"context_line":"                        result[\u0027parent_ifname\u0027] \u003d parent_ifname"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_41eccb28","line":6051,"updated":"2019-04-02 17:40:51.000000000","message":"Leave a comment about why we can ignore this.","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"263b0caba7f0e3466a413fd5a8168a84d9b378ee","unresolved":false,"context_lines":[{"line_number":6048,"context_line":"                    try:"},{"line_number":6049,"context_line":"                        parent_ifname \u003d pci_utils.get_ifname_by_pci_address("},{"line_number":6050,"context_line":"                            pci_address, pf_interface\u003dTrue)"},{"line_number":6051,"context_line":"                    except Exception:"},{"line_number":6052,"context_line":"                        pass"},{"line_number":6053,"context_line":"                    if parent_ifname:"},{"line_number":6054,"context_line":"                        result[\u0027parent_ifname\u0027] \u003d parent_ifname"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_01cfa3b0","line":6051,"range":{"start_line":6051,"start_character":27,"end_line":6051,"end_character":36},"updated":"2019-04-02 17:42:56.000000000","message":"PciDeviceNotFoundById would be a lot better than ignoring all exceptions here.","commit_id":"27128fc7cff1bbff20c813cb6c1a1e8af889e431"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ac42501442cf38d02261eec75d1219a51977f434","unresolved":false,"context_lines":[{"line_number":6053,"context_line":"                        # is expected when the virtual function is not a NIC."},{"line_number":6054,"context_line":"                        pass"},{"line_number":6055,"context_line":"                    if parent_ifname:"},{"line_number":6056,"context_line":"                        result[\u0027parent_ifname\u0027] \u003d parent_ifname"},{"line_number":6057,"context_line":"                    return result"},{"line_number":6058,"context_line":""},{"line_number":6059,"context_line":"            return {\u0027dev_type\u0027: fields.PciDeviceType.STANDARD}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_7271970c","line":6056,"range":{"start_line":6056,"start_character":24,"end_line":6056,"end_character":63},"updated":"2019-04-02 20:35:42.000000000","message":"nit: would it be cleaner to just put this in the try block?","commit_id":"8cf401735ec885c07647a75731e694a1e798e3fe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d33a4f7260dc3e56e430cc3b677248f5827bd6d5","unresolved":false,"context_lines":[{"line_number":6053,"context_line":"                        # is expected when the virtual function is not a NIC."},{"line_number":6054,"context_line":"                        pass"},{"line_number":6055,"context_line":"                    if parent_ifname:"},{"line_number":6056,"context_line":"                        result[\u0027parent_ifname\u0027] \u003d parent_ifname"},{"line_number":6057,"context_line":"                    return result"},{"line_number":6058,"context_line":""},{"line_number":6059,"context_line":"            return {\u0027dev_type\u0027: fields.PciDeviceType.STANDARD}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_ae60ee36","line":6056,"range":{"start_line":6056,"start_character":24,"end_line":6056,"end_character":63},"in_reply_to":"5fc1f717_7271970c","updated":"2019-04-03 09:53:54.000000000","message":"yeah, I would put it in the try block.","commit_id":"8cf401735ec885c07647a75731e694a1e798e3fe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f52200d04b8931327d87b455b1cf2fd908d82d0e","unresolved":false,"context_lines":[{"line_number":6053,"context_line":"                        # is expected when the virtual function is not a NIC."},{"line_number":6054,"context_line":"                        pass"},{"line_number":6055,"context_line":"                    if parent_ifname:"},{"line_number":6056,"context_line":"                        result[\u0027parent_ifname\u0027] \u003d parent_ifname"},{"line_number":6057,"context_line":"                    return result"},{"line_number":6058,"context_line":""},{"line_number":6059,"context_line":"            return {\u0027dev_type\u0027: fields.PciDeviceType.STANDARD}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_519c8f5a","line":6056,"range":{"start_line":6056,"start_character":24,"end_line":6056,"end_character":63},"in_reply_to":"5fc1f717_ae60ee36","updated":"2019-04-03 10:31:28.000000000","message":"ya im going to do a follow up patch to clean up some comments and also move one of the repeteing logs messages to debug so ill do that as well","commit_id":"8cf401735ec885c07647a75731e694a1e798e3fe"}]}