)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c4de4e56866ddabec5246aa6207f4e867826740","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"            try:"},{"line_number":1135,"context_line":"                migration \u003d objects.Migration.get_by_instance_and_status("},{"line_number":1136,"context_line":"                            context, instance.uuid, status)"},{"line_number":1137,"context_line":"                LOG.debug(\u0027NOT Binding ports to destination host: %s\u0027,"},{"line_number":1138,"context_line":"                          migration.dest_compute, instance\u003dinstance)"},{"line_number":1139,"context_line":"                # For neutron, migrate_instance_start will activate the"},{"line_number":1140,"context_line":"                # destination host port bindings, if there are any created by"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d6538c6b","line":1137,"updated":"2019-04-03 16:22:15.000000000","message":"Hmm, I don\u0027t see this in either n-cpu log in the nova-live-migration job for this change.\n\nProbably because live_migration_permit_post_copy defaults to False...","commit_id":"5a7973da3ee10ac6a2c830916a19fb654e31742c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd784b70c272783742e440baad2f161e86e46211","unresolved":false,"context_lines":[{"line_number":6934,"context_line":"                                                         self.host)"},{"line_number":6935,"context_line":"        migration \u003d {\u0027source_compute\u0027: instance.host,"},{"line_number":6936,"context_line":"                     \u0027dest_compute\u0027: self.host, }"},{"line_number":6937,"context_line":"        self.network_api.migrate_instance_finish(context,"},{"line_number":6938,"context_line":"                                                 instance,"},{"line_number":6939,"context_line":"                                                 migration)"},{"line_number":6940,"context_line":""},{"line_number":6941,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(context, instance)"},{"line_number":6942,"context_line":"        self._notify_about_instance_usage("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a5ded60d","line":6939,"range":{"start_line":6937,"start_character":8,"end_line":6939,"end_character":59},"updated":"2019-04-02 22:29:59.000000000","message":"This is what ultimately tries to update the port binding:host_id value to the dest host and blows up with a duplicate entry error because there is already a port binding for that dest host (albeit inactive).","commit_id":"5a7973da3ee10ac6a2c830916a19fb654e31742c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0435685187ff34cbe0acb62e10d5a66d28648eb3","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"            try:"},{"line_number":1135,"context_line":"                migration \u003d objects.Migration.get_by_instance_and_status("},{"line_number":1136,"context_line":"                            context, instance.uuid, status)"},{"line_number":1137,"context_line":"                LOG.debug(\u0027NOT Binding ports to destination host: %s\u0027,"},{"line_number":1138,"context_line":"                          migration.dest_compute, instance\u003dinstance)"},{"line_number":1139,"context_line":"                # For neutron, migrate_instance_start will activate the"},{"line_number":1140,"context_line":"                # destination host port bindings, if there are any created by"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_48512b0e","line":1137,"updated":"2019-04-26 17:40:41.000000000","message":"Still not seeing this in the logs.","commit_id":"2f6719304151f58262dd164ffccd819009d1ed31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c1fcbdd320cb01a9c3cb141dc075c8634b4b45c5","unresolved":false,"context_lines":[{"line_number":6800,"context_line":""},{"line_number":6801,"context_line":"        migration \u003d {\u0027source_compute\u0027: self.host,"},{"line_number":6802,"context_line":"                     \u0027dest_compute\u0027: dest, }"},{"line_number":6803,"context_line":"        # For neutron, migrate_instance_start will activate the destination"},{"line_number":6804,"context_line":"        # host port bindings, if there are any created by conductor before live"},{"line_number":6805,"context_line":"        # migration started."},{"line_number":6806,"context_line":"        self.network_api.migrate_instance_start(ctxt,"},{"line_number":6807,"context_line":"                                                instance,"},{"line_number":6808,"context_line":"                                                migration)"},{"line_number":6809,"context_line":""},{"line_number":6810,"context_line":"        destroy_vifs \u003d False"},{"line_number":6811,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_7e6dab30","line":6808,"range":{"start_line":6803,"start_character":8,"end_line":6808,"end_character":58},"updated":"2019-05-09 21:57:58.000000000","message":"This is probably why we don\u0027t fail in the gate, because we\u0027re activating the dest host port bindings here in post (on the source) before post_live_migration_at_destination (below, which calls to the dest) calls migrate_instance_finish which will update the port binding:host_id to the dest host if it\u0027s not already set to that (because of the dest host port binding activation triggered here).","commit_id":"2f6719304151f58262dd164ffccd819009d1ed31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0751cd8cac4ad4e7fd183db04a25d9cdbbac2be7","unresolved":false,"context_lines":[{"line_number":6836,"context_line":"        # For neutron, migrate_instance_start will activate the destination"},{"line_number":6837,"context_line":"        # host port bindings, if there are any created by conductor before live"},{"line_number":6838,"context_line":"        # migration started."},{"line_number":6839,"context_line":"        LOG.error(\u0027BUG-1822884: Not activating dest host port binding during \u0027"},{"line_number":6840,"context_line":"                  \u0027_post_live_migration; expect migrate_instance_finish on \u0027"},{"line_number":6841,"context_line":"                  \u0027dest host call to post_live_migration_at_destination to \u0027"},{"line_number":6842,"context_line":"                  \u0027fail with a server error from neutron (UniqueConstraint).\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_c499666e","line":6839,"updated":"2019-05-10 00:04:05.000000000","message":"OK so this does make it fail:\n\nhttp://logs.openstack.org/64/649464/3/check/nova-live-migration/a0fdcc9/logs/screen-n-cpu.txt.gz?level\u003dTRACE#_May_09_22_57_59_460763\n\nbut...","commit_id":"671e87ccfb4a907990bd9164d13b1f56c9b7d154"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0751cd8cac4ad4e7fd183db04a25d9cdbbac2be7","unresolved":false,"context_lines":[{"line_number":6886,"context_line":"            # We don\u0027t want to break _post_live_migration() if"},{"line_number":6887,"context_line":"            # post_live_migration_at_destination() fails as it should never"},{"line_number":6888,"context_line":"            # affect cleaning up source node."},{"line_number":6889,"context_line":"            LOG.exception(\"Post live migration at destination %s failed\","},{"line_number":6890,"context_line":"                          dest, instance\u003dinstance, error\u003derror)"},{"line_number":6891,"context_line":""},{"line_number":6892,"context_line":"        do_cleanup, destroy_disks \u003d self._live_migration_cleanup_flags("}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_44ad7686","line":6889,"updated":"2019-05-10 00:04:05.000000000","message":"...the error from the dest host is caught and ignored here:\n\nhttp://logs.openstack.org/64/649464/3/check/nova-live-migration/a0fdcc9/logs/screen-n-cpu.txt.gz?level\u003dTRACE#_May_09_23_00_39_272825\n\nso the overall live migration doesn\u0027t fail - dumb...but that\u0027s another bug.","commit_id":"671e87ccfb4a907990bd9164d13b1f56c9b7d154"}]}