)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0d95e83b9a02dc11cca20356177fbb989b5d1ae1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to the same host/node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4cf90139075a5e1900ff84c455e7f66ba212d123"},{"line_number":14,"context_line":"Closes-Bug: 1735407"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_b0e1d2d2","line":14,"updated":"2019-04-08 16:01:29.000000000","message":"This bug is already marked as fix because of change I752617066bb2167b49239ab9d17b0c89754a3e12. If there is still an issue with evacuate and anti-affinity groups, please report a separate bug and in the commit message explain why I752617066bb2167b49239ab9d17b0c89754a3e12 was insufficient.","commit_id":"b339c6c862f114147277c5d1401edd27a8d6930f"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"94a497f034aba6a262047c091b822636d49d858f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to the same host/node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4cf90139075a5e1900ff84c455e7f66ba212d123"},{"line_number":14,"context_line":"Closes-Bug: 1735407"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_d205787b","line":14,"in_reply_to":"5fc1f717_b0e1d2d2","updated":"2019-04-09 03:57:05.000000000","message":"Done.\nReport a seperate bug on launchpad for nova.\nAdd more messages to explain why I752617066bb2167b49239ab9d17b0c89754a3e12 was insufficient.","commit_id":"b339c6c862f114147277c5d1401edd27a8d6930f"}],"nova/compute/manager.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0558f802f3f52abd2ac579cebc0996b668326734","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"                    context, self.host)"},{"line_number":1384,"context_line":"                ins_on_host \u003d set(instances_uuids)"},{"line_number":1385,"context_line":"                members \u003d set(group.members)"},{"line_number":1386,"context_line":"                # Determine the set of instance group members on this host"},{"line_number":1387,"context_line":"                # which are not the instance in question. This is used to"},{"line_number":1388,"context_line":"                # determine how many other members from the same anti-affinity"},{"line_number":1389,"context_line":"                # group can be on this host."},{"line_number":1390,"context_line":"                members_on_host \u003d ins_on_host \u0026 members - set([instance.uuid])"},{"line_number":1391,"context_line":"                if migration:"},{"line_number":1392,"context_line":"                    mgs_same_host_and_node \u003d objects.MigrationList. \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_bce004fa","line":1389,"range":{"start_line":1386,"start_character":16,"end_line":1389,"end_character":44},"updated":"2019-04-04 16:35:27.000000000","message":"probably want to update this to indicate that you\u0027re also considering group members that are migrating to this node.","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"deb7db35921ea1857dc5ae7e0fc8c60dce13c61d","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"                    context, self.host)"},{"line_number":1384,"context_line":"                ins_on_host \u003d set(instances_uuids)"},{"line_number":1385,"context_line":"                members \u003d set(group.members)"},{"line_number":1386,"context_line":"                # Determine the set of instance group members on this host"},{"line_number":1387,"context_line":"                # which are not the instance in question. This is used to"},{"line_number":1388,"context_line":"                # determine how many other members from the same anti-affinity"},{"line_number":1389,"context_line":"                # group can be on this host."},{"line_number":1390,"context_line":"                members_on_host \u003d ins_on_host \u0026 members - set([instance.uuid])"},{"line_number":1391,"context_line":"                if migration:"},{"line_number":1392,"context_line":"                    mgs_same_host_and_node \u003d objects.MigrationList. \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_40946a37","line":1389,"range":{"start_line":1386,"start_character":16,"end_line":1389,"end_character":44},"in_reply_to":"5fc1f717_bce004fa","updated":"2019-04-08 05:52:52.000000000","message":"Done","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0558f802f3f52abd2ac579cebc0996b668326734","unresolved":false,"context_lines":[{"line_number":1389,"context_line":"                # group can be on this host."},{"line_number":1390,"context_line":"                members_on_host \u003d ins_on_host \u0026 members - set([instance.uuid])"},{"line_number":1391,"context_line":"                if migration:"},{"line_number":1392,"context_line":"                    mgs_same_host_and_node \u003d objects.MigrationList. \\"},{"line_number":1393,"context_line":"                        get_in_progress_by_host_and_node("},{"line_number":1394,"context_line":"                            context, host\u003dmigration.dest_compute,"},{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_bc44841a","line":1392,"range":{"start_line":1392,"start_character":20,"end_line":1392,"end_character":42},"updated":"2019-04-04 16:35:27.000000000","message":"would be clearer as just \"migrations\" I think. It took me some thinking to realize that \"mgs\" meant \"migrations.","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"deb7db35921ea1857dc5ae7e0fc8c60dce13c61d","unresolved":false,"context_lines":[{"line_number":1389,"context_line":"                # group can be on this host."},{"line_number":1390,"context_line":"                members_on_host \u003d ins_on_host \u0026 members - set([instance.uuid])"},{"line_number":1391,"context_line":"                if migration:"},{"line_number":1392,"context_line":"                    mgs_same_host_and_node \u003d objects.MigrationList. \\"},{"line_number":1393,"context_line":"                        get_in_progress_by_host_and_node("},{"line_number":1394,"context_line":"                            context, host\u003dmigration.dest_compute,"},{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_20dd9e13","line":1392,"range":{"start_line":1392,"start_character":20,"end_line":1392,"end_character":42},"in_reply_to":"5fc1f717_bc44841a","updated":"2019-04-08 05:52:52.000000000","message":"Done","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0558f802f3f52abd2ac579cebc0996b668326734","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                if migration:"},{"line_number":1392,"context_line":"                    mgs_same_host_and_node \u003d objects.MigrationList. \\"},{"line_number":1393,"context_line":"                        get_in_progress_by_host_and_node("},{"line_number":1394,"context_line":"                            context, host\u003dmigration.dest_compute,"},{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"},{"line_number":1396,"context_line":"                    ins_uuids \u003d [mgs.instance_uuid"},{"line_number":1397,"context_line":"                                 for mgs in mgs_same_host_and_node]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7cb93c13","line":1394,"range":{"start_line":1394,"start_character":37,"end_line":1394,"end_character":64},"updated":"2019-04-04 16:35:27.000000000","message":"maybe just use self.host?","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"deb7db35921ea1857dc5ae7e0fc8c60dce13c61d","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                if migration:"},{"line_number":1392,"context_line":"                    mgs_same_host_and_node \u003d objects.MigrationList. \\"},{"line_number":1393,"context_line":"                        get_in_progress_by_host_and_node("},{"line_number":1394,"context_line":"                            context, host\u003dmigration.dest_compute,"},{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"},{"line_number":1396,"context_line":"                    ins_uuids \u003d [mgs.instance_uuid"},{"line_number":1397,"context_line":"                                 for mgs in mgs_same_host_and_node]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_40bd4ab5","line":1394,"range":{"start_line":1394,"start_character":37,"end_line":1394,"end_character":64},"in_reply_to":"5fc1f717_7cb93c13","updated":"2019-04-08 05:52:52.000000000","message":"Done","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0558f802f3f52abd2ac579cebc0996b668326734","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"                        get_in_progress_by_host_and_node("},{"line_number":1394,"context_line":"                            context, host\u003dmigration.dest_compute,"},{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"},{"line_number":1396,"context_line":"                    ins_uuids \u003d [mgs.instance_uuid"},{"line_number":1397,"context_line":"                                 for mgs in mgs_same_host_and_node]"},{"line_number":1398,"context_line":"                    members_on_host \u003d set(list(members_on_host) + ins_uuids) \\"},{"line_number":1399,"context_line":"                        \u0026 members - set([instance.uuid])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fc420c0f","line":1396,"range":{"start_line":1396,"start_character":19,"end_line":1396,"end_character":29},"updated":"2019-04-04 16:35:27.000000000","message":"I think this would be clearer as \"instance_uuids\"","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"deb7db35921ea1857dc5ae7e0fc8c60dce13c61d","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"                        get_in_progress_by_host_and_node("},{"line_number":1394,"context_line":"                            context, host\u003dmigration.dest_compute,"},{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"},{"line_number":1396,"context_line":"                    ins_uuids \u003d [mgs.instance_uuid"},{"line_number":1397,"context_line":"                                 for mgs in mgs_same_host_and_node]"},{"line_number":1398,"context_line":"                    members_on_host \u003d set(list(members_on_host) + ins_uuids) \\"},{"line_number":1399,"context_line":"                        \u0026 members - set([instance.uuid])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_80d33201","line":1396,"range":{"start_line":1396,"start_character":19,"end_line":1396,"end_character":29},"in_reply_to":"5fc1f717_fc420c0f","updated":"2019-04-08 05:52:52.000000000","message":"For this, I stand my ground. I think it is unnecessary to change it as \u0027instance_uuids\u0027. :)","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0558f802f3f52abd2ac579cebc0996b668326734","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"},{"line_number":1396,"context_line":"                    ins_uuids \u003d [mgs.instance_uuid"},{"line_number":1397,"context_line":"                                 for mgs in mgs_same_host_and_node]"},{"line_number":1398,"context_line":"                    members_on_host \u003d set(list(members_on_host) + ins_uuids) \\"},{"line_number":1399,"context_line":"                        \u0026 members - set([instance.uuid])"},{"line_number":1400,"context_line":"                rules \u003d group.rules"},{"line_number":1401,"context_line":"                if rules and \u0027max_server_per_host\u0027 in rules:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_9c20a84b","line":1398,"range":{"start_line":1398,"start_character":47,"end_line":1398,"end_character":62},"updated":"2019-04-04 16:35:27.000000000","message":"maybe change to \"ins_on_host\" and delete line 1390?","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"deb7db35921ea1857dc5ae7e0fc8c60dce13c61d","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"                            node\u003dmigration.dest_node)"},{"line_number":1396,"context_line":"                    ins_uuids \u003d [mgs.instance_uuid"},{"line_number":1397,"context_line":"                                 for mgs in mgs_same_host_and_node]"},{"line_number":1398,"context_line":"                    members_on_host \u003d set(list(members_on_host) + ins_uuids) \\"},{"line_number":1399,"context_line":"                        \u0026 members - set([instance.uuid])"},{"line_number":1400,"context_line":"                rules \u003d group.rules"},{"line_number":1401,"context_line":"                if rules and \u0027max_server_per_host\u0027 in rules:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_80a572a1","line":1398,"range":{"start_line":1398,"start_character":47,"end_line":1398,"end_character":62},"in_reply_to":"5fc1f717_9c20a84b","updated":"2019-04-08 05:52:52.000000000","message":"Done","commit_id":"43ce926dccae9e60611b1224ab06dcad8f650fce"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dd066d8024cd7cbeb812aa0549f2a9d6aaebedcb","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"                # group can be on this host."},{"line_number":1384,"context_line":"                # Also consider group members that are migrating to avoid"},{"line_number":1385,"context_line":"                # breaking the policy of group if it is a migration action."},{"line_number":1386,"context_line":"                ins_uuids \u003d []"},{"line_number":1387,"context_line":"                if migration:"},{"line_number":1388,"context_line":"                    migrations_same_host_and_node \u003d objects.MigrationList.\\"},{"line_number":1389,"context_line":"                        get_in_progress_by_host_and_node("}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_b0c232e8","line":1386,"range":{"start_line":1386,"start_character":28,"end_line":1386,"end_character":30},"updated":"2019-04-08 16:07:18.000000000","message":"Shouldn\u0027t this be a set?","commit_id":"b339c6c862f114147277c5d1401edd27a8d6930f"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"94a497f034aba6a262047c091b822636d49d858f","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"                # group can be on this host."},{"line_number":1384,"context_line":"                # Also consider group members that are migrating to avoid"},{"line_number":1385,"context_line":"                # breaking the policy of group if it is a migration action."},{"line_number":1386,"context_line":"                ins_uuids \u003d []"},{"line_number":1387,"context_line":"                if migration:"},{"line_number":1388,"context_line":"                    migrations_same_host_and_node \u003d objects.MigrationList.\\"},{"line_number":1389,"context_line":"                        get_in_progress_by_host_and_node("}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_92fb7079","line":1386,"range":{"start_line":1386,"start_character":28,"end_line":1386,"end_character":30},"in_reply_to":"5fc1f717_b0c232e8","updated":"2019-04-09 03:57:05.000000000","message":"Done. Set ins_uuids as \u0027set()\u0027.","commit_id":"b339c6c862f114147277c5d1401edd27a8d6930f"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"94a497f034aba6a262047c091b822636d49d858f","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                            node\u003dmigration.dest_node)"},{"line_number":1392,"context_line":"                    ins_uuids \u003d set([mgs.instance_uuid"},{"line_number":1393,"context_line":"                                     for mgs in migrations_same_host_and_node])"},{"line_number":1394,"context_line":"                members_on_host \u003d ins_on_host | ins_uuids \\"},{"line_number":1395,"context_line":"                    \u0026 members - set([instance.uuid])"},{"line_number":1396,"context_line":"                rules \u003d group.rules"},{"line_number":1397,"context_line":"                if rules and \u0027max_server_per_host\u0027 in rules:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_72f60492","line":1394,"range":{"start_line":1394,"start_character":34,"end_line":1394,"end_character":57},"updated":"2019-04-09 03:57:05.000000000","message":"ins_on_host and ins_uuids are all \u0027set\u0027 here. Just directly use set operator.","commit_id":"9e9e081828361f6aacbc7628230e5d26ee6966ec"}]}