)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2c057054487a277b3136f445dd18367bb181f981","unresolved":false,"context_lines":[{"line_number":26,"context_line":"and none of those should result in a traceback, so this change"},{"line_number":27,"context_line":"just expects Invalid and its subclasses."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The one exception is InterfaceAttachFailed which is raised when"},{"line_number":30,"context_line":"something in allocate_port_for_instance or driver.attach_interface"},{"line_number":31,"context_line":"fails. That is an unexpected situation so the parent class for"},{"line_number":32,"context_line":"InterfaceAttachFailed is changed from Invalid to NovaException so"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_f9125fb4","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":17},"updated":"2019-07-23 19:40:41.000000000","message":"yuk","commit_id":"ade6c9393632e830c2368825568769853fce3b99"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c01155f543e81cb6e418449d0d8674346a9c43e9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"The one exception is InterfaceAttachFailed which is raised when"},{"line_number":30,"context_line":"something in allocate_port_for_instance or driver.attach_interface"},{"line_number":31,"context_line":"fails. That is an unexpected situation so the parent class for"},{"line_number":32,"context_line":"InterfaceAttachFailed is changed from Invalid to NovaException so"},{"line_number":33,"context_line":"it continues to be traced in the logs as an exception."},{"line_number":34,"context_line":"InterfaceAttachFailedNoNetwork is kept as Invalid since it is a"},{"line_number":35,"context_line":"user error (trying to attach an interface when the user has no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_378c2f34","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":62},"updated":"2019-04-04 17:33:39.000000000","message":"My first thought was, could this not cause problems if something was catching InterfaceAttachFailed as an Invalid and suddenly it\u0027s getting a NovaException and bubbling that up?\n\nBut checking all the places InterfaceAttachFailed is raised, it\u0027s either in a driver\u0027s attach_interface() - this is fine because this patch handles Invalid exceptions thrown by that) - or in the compute manager\u0027s attach_interface() - and this is fine because the API catches InterfaceAttachFailed explicitly.","commit_id":"ade6c9393632e830c2368825568769853fce3b99"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28614c5afa3b36e6807952950b9546dd5d308373","unresolved":false,"context_lines":[{"line_number":29,"context_line":"The one exception is InterfaceAttachFailed which is raised when"},{"line_number":30,"context_line":"something in allocate_port_for_instance or driver.attach_interface"},{"line_number":31,"context_line":"fails. That is an unexpected situation so the parent class for"},{"line_number":32,"context_line":"InterfaceAttachFailed is changed from Invalid to NovaException so"},{"line_number":33,"context_line":"it continues to be traced in the logs as an exception."},{"line_number":34,"context_line":"InterfaceAttachFailedNoNetwork is kept as Invalid since it is a"},{"line_number":35,"context_line":"user error (trying to attach an interface when the user has no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_577f7baa","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":62},"in_reply_to":"5fc1f717_378c2f34","updated":"2019-04-04 17:39:07.000000000","message":"\u003e either in a driver\u0027s attach_interface() - this is fine because this\n \u003e patch handles Invalid exceptions thrown by that\n\nErr, no, this is fine because the compute manager catches NovaException.","commit_id":"ade6c9393632e830c2368825568769853fce3b99"}],"nova/api/openstack/compute/attach_interfaces.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c01155f543e81cb6e418449d0d8674346a9c43e9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        except (exception.PortNotFound,"},{"line_number":184,"context_line":"                exception.NetworkNotFound) as e:"},{"line_number":185,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":186,"context_line":"        except exception.InterfaceAttachFailed as e:"},{"line_number":187,"context_line":"            raise webob.exc.HTTPInternalServerError("},{"line_number":188,"context_line":"                explanation\u003de.format_message())"},{"line_number":189,"context_line":"        except exception.InstanceInvalidState as state_error:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b766df54","line":186,"updated":"2019-04-04 17:33:39.000000000","message":"Caught here.","commit_id":"ade6c9393632e830c2368825568769853fce3b99"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a42c31473402808253878b37d89c367ab6fb1cd9","unresolved":false,"context_lines":[{"line_number":6067,"context_line":"        # PortInUse"},{"line_number":6068,"context_line":"        # PortNotUsableDNS"},{"line_number":6069,"context_line":"        # AttachSRIOVPortNotSupported"},{"line_number":6070,"context_line":"        # NetworksWithQoSPolicyNotSupported"},{"line_number":6071,"context_line":"        exception.Invalid)"},{"line_number":6072,"context_line":"    @wrap_exception()"},{"line_number":6073,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_718443b2","line":6070,"range":{"start_line":6070,"start_character":10,"end_line":6070,"end_character":43},"updated":"2019-07-23 22:49:34.000000000","message":"Just a note for backports, this wouldn\u0027t apply before Stein.\n\nI7e1edede827cf8469771c0496b1dce55c627cf5d","commit_id":"ade6c9393632e830c2368825568769853fce3b99"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28614c5afa3b36e6807952950b9546dd5d308373","unresolved":false,"context_lines":[{"line_number":6105,"context_line":"        try:"},{"line_number":6106,"context_line":"            self.driver.attach_interface(context, instance, image_meta,"},{"line_number":6107,"context_line":"                                         network_info[0])"},{"line_number":6108,"context_line":"        except exception.NovaException as ex:"},{"line_number":6109,"context_line":"            port_id \u003d network_info[0].get(\u0027id\u0027)"},{"line_number":6110,"context_line":"            LOG.warning(\"attach interface failed , try to deallocate \""},{"line_number":6111,"context_line":"                        \"port %(port_id)s, reason: %(msg)s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_174b3387","line":6108,"range":{"start_line":6108,"start_character":25,"end_line":6108,"end_character":38},"updated":"2019-04-04 17:39:07.000000000","message":"Catches NovaException here.","commit_id":"ade6c9393632e830c2368825568769853fce3b99"}],"nova/exception.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c01155f543e81cb6e418449d0d8674346a9c43e9","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"                \"%(instance_uuid)s\")"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"class InterfaceAttachFailedNoNetwork(Invalid):"},{"line_number":1608,"context_line":"    msg_fmt \u003d _(\"No specific network was requested and none are available \""},{"line_number":1609,"context_line":"                \"for project \u0027%(project_id)s\u0027.\")"},{"line_number":1610,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d7e84b7d","line":1607,"range":{"start_line":1607,"start_character":37,"end_line":1607,"end_character":44},"updated":"2019-04-04 17:33:39.000000000","message":"✓ (and there are no other children of InterfaceAttachFailed)","commit_id":"ade6c9393632e830c2368825568769853fce3b99"}]}