)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf2301c7f7495edcc8929a8e56a20e37c04e54e0","unresolved":false,"context_lines":[{"line_number":3422,"context_line":"                request_spec.scheduler_hints \u003d {}"},{"line_number":3423,"context_line":"            # Nuke the id on this so we can\u0027t accidentally save"},{"line_number":3424,"context_line":"            # this hint hack later"},{"line_number":3425,"context_line":"            del request_spec.id"},{"line_number":3426,"context_line":""},{"line_number":3427,"context_line":"            # NOTE(danms): Passing host\u003dNone tells conductor to"},{"line_number":3428,"context_line":"            # call the scheduler. The _nova_check_type hint"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_0cbd4fb6","line":3425,"updated":"2019-04-05 18:13:19.000000000","message":"I don\u0027t know if bug 1823369 should be fixed before this change or not, but an easy backportable change would be to reset the changes to scheduler_hints and force_hosts/force_nodes here in the API before casting to conductor.","commit_id":"8a003f4bad1d87ec90f6500e1576788a9be1a316"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"ec2e4aa9c3f206a96a10a5ce6c548bf8971e0074","unresolved":false,"context_lines":[{"line_number":3422,"context_line":"                request_spec.scheduler_hints \u003d {}"},{"line_number":3423,"context_line":"            # Nuke the id on this so we can\u0027t accidentally save"},{"line_number":3424,"context_line":"            # this hint hack later"},{"line_number":3425,"context_line":"            del request_spec.id"},{"line_number":3426,"context_line":""},{"line_number":3427,"context_line":"            # NOTE(danms): Passing host\u003dNone tells conductor to"},{"line_number":3428,"context_line":"            # call the scheduler. The _nova_check_type hint"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_ea29ee9a","line":3425,"in_reply_to":"5fc1f717_0cbd4fb6","updated":"2019-04-25 02:26:37.000000000","message":"Could you review [1] if you like it?\n\n[1] https://review.opendev.org/#/c/655278/","commit_id":"8a003f4bad1d87ec90f6500e1576788a9be1a316"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf2301c7f7495edcc8929a8e56a20e37c04e54e0","unresolved":false,"context_lines":[{"line_number":3430,"context_line":"            # host that we are currently on and only checks"},{"line_number":3431,"context_line":"            # rebuild-related filters."},{"line_number":3432,"context_line":"            request_spec.scheduler_hints[\u0027_nova_check_type\u0027] \u003d [\u0027rebuild\u0027]"},{"line_number":3433,"context_line":"            request_spec.requested_destination \u003d objects.Destination("},{"line_number":3434,"context_line":"                host\u003dinstance.host, node\u003dinstance.node,"},{"line_number":3435,"context_line":"                # TODO(mriedem): We could avoid this DB query if CELLS was"},{"line_number":3436,"context_line":"                # a dict keyed by cell UUID. Also, why isn\u0027t conductor"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6ca2d39c","line":3433,"updated":"2019-04-05 18:13:19.000000000","message":"This field doesn\u0027t need to be reset because it\u0027s not persisted:\n\nI2a78f0754c63381c57e7e1c610d0938b6df0f537","commit_id":"8a003f4bad1d87ec90f6500e1576788a9be1a316"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf2301c7f7495edcc8929a8e56a20e37c04e54e0","unresolved":false,"context_lines":[{"line_number":3432,"context_line":"            request_spec.scheduler_hints[\u0027_nova_check_type\u0027] \u003d [\u0027rebuild\u0027]"},{"line_number":3433,"context_line":"            request_spec.requested_destination \u003d objects.Destination("},{"line_number":3434,"context_line":"                host\u003dinstance.host, node\u003dinstance.node,"},{"line_number":3435,"context_line":"                # TODO(mriedem): We could avoid this DB query if CELLS was"},{"line_number":3436,"context_line":"                # a dict keyed by cell UUID. Also, why isn\u0027t conductor"},{"line_number":3437,"context_line":"                # restricting the request spec to the same cell the instance"},{"line_number":3438,"context_line":"                # is in - for either rebuild or evacuate, like we do for"},{"line_number":3439,"context_line":"                # cold/live migrate and unshelve (bug 1823370)?"},{"line_number":3440,"context_line":"                cell\u003dobjects.CellMapping.get_by_uuid("},{"line_number":3441,"context_line":"                    context, context.cell_uuid))"},{"line_number":3442,"context_line":"            host \u003d None"},{"line_number":3443,"context_line":""},{"line_number":3444,"context_line":"        self.compute_task_api.rebuild_instance(context, instance\u003dinstance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8c9fff4e","line":3441,"range":{"start_line":3435,"start_character":15,"end_line":3441,"end_character":48},"updated":"2019-04-05 18:13:19.000000000","message":"Fixing bug 1823370 first will remove the need for this.","commit_id":"8a003f4bad1d87ec90f6500e1576788a9be1a316"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"ec2e4aa9c3f206a96a10a5ce6c548bf8971e0074","unresolved":false,"context_lines":[{"line_number":3429,"context_line":"            # requires that the scheduler returns only the same"},{"line_number":3430,"context_line":"            # host that we are currently on and only checks"},{"line_number":3431,"context_line":"            # rebuild-related filters."},{"line_number":3432,"context_line":"            request_spec.scheduler_hints[\u0027_nova_check_type\u0027] \u003d [\u0027rebuild\u0027]"},{"line_number":3433,"context_line":"            request_spec.requested_destination \u003d objects.Destination("},{"line_number":3434,"context_line":"                host\u003dinstance.host, node\u003dinstance.node)"},{"line_number":3435,"context_line":"            host \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_4ab83a75","line":3432,"range":{"start_line":3432,"start_character":12,"end_line":3432,"end_character":74},"updated":"2019-04-25 02:26:37.000000000","message":"I assume you plan to delete this in the U cycle at the same time when you remove the scheduler code. I would leave TODO here, too.","commit_id":"186dfaa37fe008eadccc421ab3c2c34b8bdfba9e"}]}