)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3f051a6df893a1e4906b3bf91b3271ba06943630","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     tanlin \u003clin.tan@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-08 17:37:24 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Instance Object functions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add add_security_group() and remove_security_group()"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUH%2F%2FsVU%3D","line":7,"updated":"2014-01-09 15:07:03.000000000","message":"This is not a proper summary line for this patch.","commit_id":"220a90a106fff9052724170eef7916412e3494e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3f051a6df893a1e4906b3bf91b3271ba06943630","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Instance Object functions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add add_security_group() and remove_security_group()"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related to blueprint icehouse-objects."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUH%2F%2FsU8%3D","line":9,"updated":"2014-01-09 15:07:03.000000000","message":"This would be better than the above, if it included \"Instance object\"","commit_id":"220a90a106fff9052724170eef7916412e3494e9"}],"nova/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4956ac98e1224438802953d86ec337c98752078f","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    @base.remotable"},{"line_number":531,"context_line":"    def add_security_group(self, context,"},{"line_number":532,"context_line":"                           secgroup):"},{"line_number":533,"context_line":"        db.instance_add_security_group(context.elevated(),"},{"line_number":534,"context_line":"                                       self.uuid,"},{"line_number":535,"context_line":"                                       secgroup.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FsWI%3D","line":532,"updated":"2014-01-09 15:05:13.000000000","message":"Why is secgroup wrapped?","commit_id":"220a90a106fff9052724170eef7916412e3494e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4956ac98e1224438802953d86ec337c98752078f","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                           secgroup):"},{"line_number":533,"context_line":"        db.instance_add_security_group(context.elevated(),"},{"line_number":534,"context_line":"                                       self.uuid,"},{"line_number":535,"context_line":"                                       secgroup.id)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    @base.remotable"},{"line_number":538,"context_line":"    def remove_security_group(self, context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FsWU%3D","line":535,"updated":"2014-01-09 15:05:13.000000000","message":"This does not  update the instance\u0027s notion of its own security groups, but should.","commit_id":"220a90a106fff9052724170eef7916412e3494e9"},{"author":{"_account_id":9407,"name":"tan0","email":"tano.tum@gmail.com","username":"tanlin"},"change_message_id":"c65f79e5b07bbf922091b0a3d8daa3efcb548131","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                           secgroup):"},{"line_number":533,"context_line":"        db.instance_add_security_group(context.elevated(),"},{"line_number":534,"context_line":"                                       self.uuid,"},{"line_number":535,"context_line":"                                       secgroup.id)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    @base.remotable"},{"line_number":538,"context_line":"    def remove_security_group(self, context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FpCM%3D","line":535,"in_reply_to":"AAAAUH%2F%2FsWU%3D","updated":"2014-01-10 06:52:34.000000000","message":"@Dan Smith\nYou mentioned in \nhttps://review.openstack.org/#/c/64494/\nPatch set 4:\n\"These need version bumps and don\u0027t modify the instance itself, which will be stale after the call.\"\nSo I removed the code of updating the instance.\nDo I misunderstand you or you changed your idea?","commit_id":"220a90a106fff9052724170eef7916412e3494e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4956ac98e1224438802953d86ec337c98752078f","unresolved":false,"context_lines":[{"line_number":539,"context_line":"                              secgroup):"},{"line_number":540,"context_line":"        db.instance_remove_security_group(context.elevated(),"},{"line_number":541,"context_line":"                                          self.uuid,"},{"line_number":542,"context_line":"                                          secgroup.id)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"def _make_instance_list(context, inst_list, db_inst_list, expected_attrs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FsWQ%3D","line":542,"updated":"2014-01-09 15:05:13.000000000","message":"Same here.","commit_id":"220a90a106fff9052724170eef7916412e3494e9"}],"nova/tests/objects/test_instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4956ac98e1224438802953d86ec337c98752078f","unresolved":false,"context_lines":[{"line_number":807,"context_line":"            inst \u003d instance.Instance(id\u003d1, uuid\u003d\u0027uuid1\u0027)"},{"line_number":808,"context_line":"            inst.security_groups \u003d security_group.SecurityGroupList()"},{"line_number":809,"context_line":"            inst.add_security_group(self.context, secgroup)"},{"line_number":810,"context_line":"            inst.security_groups.objects.append(secgroup)"},{"line_number":811,"context_line":"        self.assertEqual(1, len(inst.security_groups.objects))"},{"line_number":812,"context_line":"        self.assertEqual(inst.security_groups[0].id, secgroup.id)"},{"line_number":813,"context_line":"        self.assertRemotes()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FsVs%3D","line":810,"updated":"2014-01-09 15:05:13.000000000","message":"This should not be here. The instance should be doing this.","commit_id":"220a90a106fff9052724170eef7916412e3494e9"}]}