)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"013751e9cba8af37486b1264c80c55d663d0f3e4","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"                        self._validate_image_traits_for_rebuild(context,"},{"line_number":1057,"context_line":"                                                                instance,"},{"line_number":1058,"context_line":"                                                                image_ref)"},{"line_number":1059,"context_line":"                    self._restrict_request_spec_to_cell("},{"line_number":1060,"context_line":"                        context, instance, request_spec)"},{"line_number":1061,"context_line":"                    request_spec.ensure_project_and_user_id(instance)"},{"line_number":1062,"context_line":"                    request_spec.ensure_network_metadata(instance)"},{"line_number":1063,"context_line":"                    compute_utils.heal_reqspec_is_bfv("},{"line_number":1064,"context_line":"                        context, request_spec, instance)"},{"line_number":1065,"context_line":"                    host_lists \u003d self._schedule_instances(context,"},{"line_number":1066,"context_line":"                            request_spec, [instance.uuid],"},{"line_number":1067,"context_line":"                            return_alternates\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d73b54e7","line":1064,"range":{"start_line":1059,"start_character":20,"end_line":1064,"end_character":56},"updated":"2019-04-05 20:00:14.000000000","message":"A follow up could DRY this up between unshelve and evacuate as well. Maybe if we didn\u0027t have to copy the same 20 RequestSpec fixes in 5 different places we wouldn\u0027t have missed the evacuate case.","commit_id":"0325023e1a75979389d0df09bd95c4e66edcbab4"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"ea89739f193b3f8efb0f54930dfbb2dd522d9738","unresolved":false,"context_lines":[{"line_number":822,"context_line":"        if (\u0027requested_destination\u0027 in request_spec and"},{"line_number":823,"context_line":"                request_spec.requested_destination):"},{"line_number":824,"context_line":"            request_spec.requested_destination.cell \u003d ("},{"line_number":825,"context_line":"                instance_mapping.cell_mapping)"},{"line_number":826,"context_line":"        else:"},{"line_number":827,"context_line":"            request_spec.requested_destination \u003d ("},{"line_number":828,"context_line":"                objects.Destination("}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_4a359a45","line":825,"updated":"2019-04-25 01:42:21.000000000","message":"If the requested_destination is already set, that probably means it has the host and the node already set, and what happens if the host/node is out of the cell set here is that it fails anyway later with no host found in the scheduler layer, and it is also the case if we get use-placement-in-tree [1] in so this looks fine to me. \n\n[1] https://review.opendev.org/#/c/650877/","commit_id":"9e33dc54b6685e5bb6b4a1db55d2521280bf343f"}]}