)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aef9161ae0157fc7e1be070a44c19fa0c6cda474","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        :param migrate_uri: URI for invoking the migration"},{"line_number":614,"context_line":"        :param migrate_disks: List of disks to be migrated"},{"line_number":615,"context_line":"        :param destination_xml: The guest XML to be used on the target host"},{"line_number":616,"context_line":"        :param flags: May be one of more of the following:"},{"line_number":617,"context_line":"           VIR_MIGRATE_LIVE Do not pause the VM during migration"},{"line_number":618,"context_line":"           VIR_MIGRATE_PEER2PEER Direct connection between source \u0026"},{"line_number":619,"context_line":"                                 destination hosts"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_1f42fbab","line":616,"range":{"start_line":616,"start_character":22,"end_line":616,"end_character":58},"updated":"2019-05-30 17:42:30.000000000","message":"I checked the VIR_MIGRATE_* flags *currently* used by the libvirt driver, and this change in the docstring correctly lists all and only those flags.\n\nI\u0027m also in favor of documenting what each of the flags means, as is being done here.\n\nHowever, it\u0027s weird and brittle and non-future-proof that only a subset of possible flags are listed here, particularly under a lead line \"May be one or more of the following\" implying that you shouldn\u0027t use any others.\n\nMy point is that, some time in the future, someone may want to add another flag in the code that calls this. When they do, they\u0027ll likely forget to update this docstring (which is surely how it got out of sync in the first place).\n\nI don\u0027t have a wonderful suggestion for mitigating this. But perhaps we could rephrase this lead line to something like:\n\n\"Bitmask of ``VIR_MIGRATE_*`` flags listed at \u003clink from the commit message\u003e. The following are the flags currently used by the libvirt driver. Please remember to keep this docstring up to date as flags are added/removed from usage.\"","commit_id":"3412595a3506514d6a4f5da7877d93a273be30b5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6472dcfe94183b70b601697837e3610a5acbcb0c","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        :param migrate_uri: URI for invoking the migration"},{"line_number":614,"context_line":"        :param migrate_disks: List of disks to be migrated"},{"line_number":615,"context_line":"        :param destination_xml: The guest XML to be used on the target host"},{"line_number":616,"context_line":"        :param flags: May be one of more of the following:"},{"line_number":617,"context_line":"           VIR_MIGRATE_LIVE Do not pause the VM during migration"},{"line_number":618,"context_line":"           VIR_MIGRATE_PEER2PEER Direct connection between source \u0026"},{"line_number":619,"context_line":"                                 destination hosts"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_ed4b8fad","line":616,"range":{"start_line":616,"start_character":22,"end_line":616,"end_character":58},"in_reply_to":"bfb3d3c7_1f42fbab","updated":"2019-06-03 11:42:32.000000000","message":"+1 that idea.","commit_id":"3412595a3506514d6a4f5da7877d93a273be30b5"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"9e09111e001954adf3e3e2aa9e71496543e81b42","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                                     hypervisor can transfer the changed"},{"line_number":634,"context_line":"                                     memory to the destination host"},{"line_number":635,"context_line":"           VIR_MIGRATE_POSTCOPY Tell libvirt to enable post-copy migration"},{"line_number":636,"context_line":"           VIR_MIGRATE_TLS Use QEMU-native TLS"},{"line_number":637,"context_line":"        :param bandwidth: The maximum bandwidth in MiB/s"},{"line_number":638,"context_line":"        \"\"\""},{"line_number":639,"context_line":"        params \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_8a3f4ad5","line":636,"range":{"start_line":636,"start_character":11,"end_line":636,"end_character":26},"updated":"2019-04-12 08:34:40.000000000","message":"Here ^","commit_id":"3412595a3506514d6a4f5da7877d93a273be30b5"}]}