)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"74acd8f345fad36760102957a8b24faaef8f4a5b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"asserting the 410 response now. The latter are also expanded to cover"},{"line_number":16,"context_line":"APIs that weren\u0027t previously tested."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API sample docs are left intact since the API reference still builds"},{"line_number":19,"context_line":"from those and can be considered more or less branchless, so people"},{"line_number":20,"context_line":"looking at the API reference can apply it to older deployments of nova"},{"line_number":21,"context_line":"before os-cells was removed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_8b2ba62e","line":18,"updated":"2019-04-15 15:14:26.000000000","message":"Might be worth putting a README in this directory https://github.com/openstack/nova/tree/master/doc/api_samples/os-cells so someone doesn\u0027t come along in a year and say \"these aren\u0027t used we should delete them\" and we forget about the reason for leaving them in place. Could be a follow up and we likely have the same issue in other obsolete APIs.","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"033d1bd1da22831fa0400d19cf053a42f1b78fb8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"asserting the 410 response now. The latter are also expanded to cover"},{"line_number":16,"context_line":"APIs that weren\u0027t previously tested."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API sample docs are left intact since the API reference still builds"},{"line_number":19,"context_line":"from those and can be considered more or less branchless, so people"},{"line_number":20,"context_line":"looking at the API reference can apply it to older deployments of nova"},{"line_number":21,"context_line":"before os-cells was removed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_3d83c6ce","line":18,"in_reply_to":"3fce034c_8b2ba62e","updated":"2019-04-16 08:35:25.000000000","message":"I still see references to this these samples in the documentation, so I think that removing them would result in an obvious enough error. I did note that one of the samples is unused though so I\u0027ve removed that in the follow-up","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"25e41cf1825e5fe7d7d2696043fe93d05fb79ae4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"asserting the 410 response now. The latter are also expanded to cover"},{"line_number":16,"context_line":"APIs that weren\u0027t previously tested."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API sample docs are left intact since the API reference still builds"},{"line_number":19,"context_line":"from those and can be considered more or less branchless, so people"},{"line_number":20,"context_line":"looking at the API reference can apply it to older deployments of nova"},{"line_number":21,"context_line":"before os-cells was removed."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_a1825dc7","line":19,"range":{"start_line":18,"start_character":46,"end_line":19,"end_character":56},"updated":"2019-04-12 21:54:28.000000000","message":"Eh? Oh, geez, that\u0027s true. That... kind of sucks. We\u0027re going to never remove this stuff from the API reference? Or when Stein is EOL?","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a82e26a67e0abaa99c4faf7732e5bdc90e412ef9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"asserting the 410 response now. The latter are also expanded to cover"},{"line_number":16,"context_line":"APIs that weren\u0027t previously tested."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API sample docs are left intact since the API reference still builds"},{"line_number":19,"context_line":"from those and can be considered more or less branchless, so people"},{"line_number":20,"context_line":"looking at the API reference can apply it to older deployments of nova"},{"line_number":21,"context_line":"before os-cells was removed."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_0ac6d79b","line":19,"range":{"start_line":18,"start_character":46,"end_line":19,"end_character":56},"in_reply_to":"3fce034c_a1825dc7","updated":"2019-04-15 10:10:30.000000000","message":"Nope, they stay forever. It\u0027s docs and in theory should never change (unless we change how we do docs or something) so I don\u0027t think they\u0027re _that_ much of a burden but idk for sure","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"}],"api-ref/source/os-cells.inc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"74acd8f345fad36760102957a8b24faaef8f4a5b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Update a Cell"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. rest_method:: PUT /os-cells/{cell_od}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Update an existing cell."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fce034c_4b9e1e55","line":133,"range":{"start_line":133,"start_character":37,"end_line":133,"end_character":39},"updated":"2019-04-15 15:14:26.000000000","message":"Want to fix this while you\u0027re in here? {cell_id}","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"033d1bd1da22831fa0400d19cf053a42f1b78fb8","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Update a Cell"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. rest_method:: PUT /os-cells/{cell_od}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Update an existing cell."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fce034c_3d5c267d","line":133,"range":{"start_line":133,"start_character":37,"end_line":133,"end_character":39},"in_reply_to":"3fce034c_4b9e1e55","updated":"2019-04-16 08:35:25.000000000","message":"Done","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"}],"nova/api/validation/parameter_types.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"74acd8f345fad36760102957a8b24faaef8f4a5b","unresolved":false,"context_lines":[{"line_number":308,"context_line":"}"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"tcp_udp_port \u003d {"},{"line_number":312,"context_line":"    \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027], \u0027pattern\u0027: \u0027^[0-9]*$\u0027,"},{"line_number":313,"context_line":"    \u0027minimum\u0027: 0, \u0027maximum\u0027: 65535,"},{"line_number":314,"context_line":"    \u0027minLength\u0027: 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_2bd0721f","line":311,"updated":"2019-04-15 15:14:26.000000000","message":"Looks like this is no longer used either. Could remove in a follow up.","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"033d1bd1da22831fa0400d19cf053a42f1b78fb8","unresolved":false,"context_lines":[{"line_number":308,"context_line":"}"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"tcp_udp_port \u003d {"},{"line_number":312,"context_line":"    \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027], \u0027pattern\u0027: \u0027^[0-9]*$\u0027,"},{"line_number":313,"context_line":"    \u0027minimum\u0027: 0, \u0027maximum\u0027: 65535,"},{"line_number":314,"context_line":"    \u0027minLength\u0027: 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_fdda1ee7","line":311,"in_reply_to":"3fce034c_2bd0721f","updated":"2019-04-16 08:35:25.000000000","message":"Done","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"}],"nova/tests/functional/api_sample_tests/test_cells.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"74acd8f345fad36760102957a8b24faaef8f4a5b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class CellsTest(api_sample_base.ApiSampleTestBaseV21):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_cells_list(self):"},{"line_number":24,"context_line":"        ex \u003d self.assertRaises(api_client.OpenStackApiException,"},{"line_number":25,"context_line":"                               self.api.api_get, \u0027os-cells\u0027)"},{"line_number":26,"context_line":"        self.assertEqual(410, ex.response.status_code)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_cells_capacity(self):"},{"line_number":29,"context_line":"        ex \u003d self.assertRaises(api_client.OpenStackApiException,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_eb9eea61","line":26,"range":{"start_line":24,"start_character":8,"end_line":26,"end_character":54},"updated":"2019-04-15 15:14:26.000000000","message":"nit: you could avoid the explicit 410 check with assertRaises by passing check_response_status\u003d[410] to api_get.","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"033d1bd1da22831fa0400d19cf053a42f1b78fb8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class CellsTest(api_sample_base.ApiSampleTestBaseV21):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_cells_list(self):"},{"line_number":24,"context_line":"        ex \u003d self.assertRaises(api_client.OpenStackApiException,"},{"line_number":25,"context_line":"                               self.api.api_get, \u0027os-cells\u0027)"},{"line_number":26,"context_line":"        self.assertEqual(410, ex.response.status_code)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_cells_capacity(self):"},{"line_number":29,"context_line":"        ex \u003d self.assertRaises(api_client.OpenStackApiException,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_fd03fe40","line":26,"range":{"start_line":24,"start_character":8,"end_line":26,"end_character":54},"in_reply_to":"3fce034c_eb9eea61","updated":"2019-04-16 08:35:25.000000000","message":"Done","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef7930a72c06c6d546db3366275151d2f059af0d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_cells_list(self):"},{"line_number":24,"context_line":"        self.assertRaises(api_client.OpenStackApiException,"},{"line_number":25,"context_line":"                          self.api.api_get, \u0027os-cells\u0027,"},{"line_number":26,"context_line":"                          check_response_state\u003d[410])"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_cells_capacity(self):"},{"line_number":29,"context_line":"        self.assertRaises(api_client.OpenStackApiException,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_47035b74","line":26,"range":{"start_line":26,"start_character":26,"end_line":26,"end_character":46},"updated":"2019-04-16 13:40:04.000000000","message":"check_response_status","commit_id":"29d82108928dd03a2907cd84a633a5ee65eeec46"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"358b0b7cc1131e72c60231d1a73385fab23a1cc1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_cells_list(self):"},{"line_number":24,"context_line":"        self.assertRaises(api_client.OpenStackApiException,"},{"line_number":25,"context_line":"                          self.api.api_get, \u0027os-cells\u0027,"},{"line_number":26,"context_line":"                          check_response_state\u003d[410])"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_cells_capacity(self):"},{"line_number":29,"context_line":"        self.assertRaises(api_client.OpenStackApiException,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_e2e6f516","line":26,"range":{"start_line":26,"start_character":26,"end_line":26,"end_character":46},"in_reply_to":"3fce034c_47035b74","updated":"2019-04-16 14:22:59.000000000","message":"Done /o\\","commit_id":"29d82108928dd03a2907cd84a633a5ee65eeec46"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"feed7b6adb350f81f268c9d5345ae66537880c0f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from nova.tests.functional.api import client as api_client"},{"line_number":18,"context_line":"from nova.tests.functional.api_sample_tests import api_sample_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_ab3f6923","line":17,"updated":"2019-04-16 15:49:01.000000000","message":"pep8 failure:\n\n./nova/tests/functional/api_sample_tests/test_cells.py:17:1: F401 \u0027api_client\u0027 imported but unused","commit_id":"790b1dda86117acf4ce557f4d9e970d2484f1826"}],"releasenotes/notes/remove-cells-v1-055028c270d06680.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"74acd8f345fad36760102957a8b24faaef8f4a5b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    * ``GET /os-cells/capacities``"},{"line_number":13,"context_line":"    * ``GET /os-cells/detail``"},{"line_number":14,"context_line":"    * ``GET /os-cells/info``"},{"line_number":15,"context_line":"    * ``POST /os-cells/sync_instances``"},{"line_number":16,"context_line":"    * ``GET /os-cells/{cell_id}``"},{"line_number":17,"context_line":"    * ``POST /os-cells/{cell_id}``"},{"line_number":18,"context_line":"    * ``DELETE /os-cells/{cell_id}``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_8b872610","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":39},"updated":"2019-04-15 15:14:26.000000000","message":"Huh I guess this one wasn\u0027t even in the API reference.","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"74acd8f345fad36760102957a8b24faaef8f4a5b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * ``GET /os-cells/info``"},{"line_number":15,"context_line":"    * ``POST /os-cells/sync_instances``"},{"line_number":16,"context_line":"    * ``GET /os-cells/{cell_id}``"},{"line_number":17,"context_line":"    * ``POST /os-cells/{cell_id}``"},{"line_number":18,"context_line":"    * ``DELETE /os-cells/{cell_id}``"},{"line_number":19,"context_line":"    * ``GET /os-cells/{cell_id}/capacities``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_eb77ca39","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":12},"updated":"2019-04-15 15:14:26.000000000","message":"PUT? http://logs.openstack.org/91/651291/1/check/build-openstack-api-ref/5144c47/html/?expanded\u003d#update-a-cell","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"033d1bd1da22831fa0400d19cf053a42f1b78fb8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * ``GET /os-cells/info``"},{"line_number":15,"context_line":"    * ``POST /os-cells/sync_instances``"},{"line_number":16,"context_line":"    * ``GET /os-cells/{cell_id}``"},{"line_number":17,"context_line":"    * ``POST /os-cells/{cell_id}``"},{"line_number":18,"context_line":"    * ``DELETE /os-cells/{cell_id}``"},{"line_number":19,"context_line":"    * ``GET /os-cells/{cell_id}/capacities``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_dd8de2d3","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":12},"in_reply_to":"3fce034c_eb77ca39","updated":"2019-04-16 08:35:25.000000000","message":"Done","commit_id":"469d58ed79aca342a2916d0f4f8ffd06df467fe4"}]}