)]}'
{"nova/cells/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9a5020b9029f61b5cd2ac24d290c181054c40087","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                            instance_uuid)"},{"line_number":169,"context_line":"                except exception.InstanceNotFound:"},{"line_number":170,"context_line":"                    continue"},{"line_number":171,"context_line":"                self._sync_instance(ctxt, instance)"},{"line_number":172,"context_line":"                break"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def _sync_instance(self, ctxt, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_7cabbad5","line":171,"range":{"start_line":171,"start_character":16,"end_line":171,"end_character":51},"updated":"2019-04-12 22:53:16.000000000","message":"Curious, any reason not to just remove this line and the whole _sync_instance method?","commit_id":"7cffd17c5983000632488038b8c4548317e9465e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"65add8feab94ae72818a22eb2649b2f7a0a046f4","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                            instance_uuid)"},{"line_number":169,"context_line":"                except exception.InstanceNotFound:"},{"line_number":170,"context_line":"                    continue"},{"line_number":171,"context_line":"                self._sync_instance(ctxt, instance)"},{"line_number":172,"context_line":"                break"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def _sync_instance(self, ctxt, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_8a95e7e6","line":171,"range":{"start_line":171,"start_character":16,"end_line":171,"end_character":51},"in_reply_to":"3fce034c_7cabbad5","updated":"2019-05-01 22:28:29.000000000","message":"Not really. Just wanted to keep the diff as small as possible, really. I thought there might be more callers than there were. No point respinning now for this though, as you\u0027ve figured","commit_id":"7cffd17c5983000632488038b8c4548317e9465e"}],"nova/cells/messaging.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9a5020b9029f61b5cd2ac24d290c181054c40087","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        instances \u003d cells_utils.get_instances_to_sync(message.ctxt,"},{"line_number":1012,"context_line":"                updated_since\u003dupdated_since, project_id\u003dproject_id,"},{"line_number":1013,"context_line":"                deleted\u003ddeleted)"},{"line_number":1014,"context_line":"        for instance in instances:"},{"line_number":1015,"context_line":"            self._sync_instance(message.ctxt, instance)"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    def service_get_all(self, message, filters):"},{"line_number":1018,"context_line":"        if filters is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_fc880a72","line":1015,"range":{"start_line":1014,"start_character":0,"end_line":1015,"end_character":55},"updated":"2019-04-12 22:53:16.000000000","message":"likewise, why not remove this block and the _sync_instance method? AFAICT not used anywhere else.","commit_id":"7cffd17c5983000632488038b8c4548317e9465e"}],"nova/compute/cells_api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9a5020b9029f61b5cd2ac24d290c181054c40087","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                        exc.reraise \u003d False"},{"line_number":277,"context_line":"                        self._handle_cell_delete(context, instance,"},{"line_number":278,"context_line":"                                method_name)"},{"line_number":279,"context_line":"            return"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        method \u003d getattr(super(ComputeCellsAPI, self), method_name)"},{"line_number":282,"context_line":"        method(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_1ce63646","line":279,"updated":"2019-04-12 22:53:16.000000000","message":"Note to self: you were suspicious about\n\n except InstanceNotFound: pass\n\nno longer being necessary here. You convinced yourself it doesn\u0027t matter.","commit_id":"7cffd17c5983000632488038b8c4548317e9465e"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9a5020b9029f61b5cd2ac24d290c181054c40087","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        \"\"\"Common code for testing save() for cells/non-cells.\"\"\""},{"line_number":446,"context_line":"        if cell_type:"},{"line_number":447,"context_line":"            self.flags(enable\u003dTrue, cell_type\u003dcell_type, group\u003d\u0027cells\u0027)"},{"line_number":448,"context_line":"        else:"},{"line_number":449,"context_line":"            self.flags(enable\u003dFalse, group\u003d\u0027cells\u0027)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        old_ref \u003d dict(self.fake_instance, host\u003d\u0027oldhost\u0027, user_data\u003d\u0027old\u0027,"},{"line_number":452,"context_line":"                       vm_state\u003d\u0027old\u0027, task_state\u003d\u0027old\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_fc3b2a99","side":"PARENT","line":449,"range":{"start_line":448,"start_character":8,"end_line":449,"end_character":51},"updated":"2019-04-12 22:53:16.000000000","message":"Weird that this was here in the first place, as it\u0027s the default.","commit_id":"bb39296c331948c29ad9aa6422cb103095ce851c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9a5020b9029f61b5cd2ac24d290c181054c40087","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        new_ref \u003d dict(old_ref, host\u003d\u0027newhost\u0027, **expected_updates)"},{"line_number":459,"context_line":"        exp_vm_state \u003d save_kwargs.get(\u0027expected_vm_state\u0027)"},{"line_number":460,"context_line":"        exp_task_state \u003d save_kwargs.get(\u0027expected_task_state\u0027)"},{"line_number":461,"context_line":"        admin_reset \u003d save_kwargs.get(\u0027admin_state_reset\u0027, False)"},{"line_number":462,"context_line":"        if exp_vm_state:"},{"line_number":463,"context_line":"            expected_updates[\u0027expected_vm_state\u0027] \u003d exp_vm_state"},{"line_number":464,"context_line":"        if exp_task_state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_fc09eadc","side":"PARENT","line":461,"range":{"start_line":461,"start_character":39,"end_line":461,"end_character":56},"updated":"2019-04-12 22:53:16.000000000","message":"Note to self: admin_state_reset is still used and seems to be in a reachable code path; but that code path doesn\u0027t get hit by these tests anymore so this removal is copacetic.","commit_id":"bb39296c331948c29ad9aa6422cb103095ce851c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9a5020b9029f61b5cd2ac24d290c181054c40087","unresolved":false,"context_lines":[{"line_number":544,"context_line":"                                            mock_update_and_get):"},{"line_number":545,"context_line":"        # Tests that simply changing the \u0027display_name\u0027 on the instance"},{"line_number":546,"context_line":"        # will send a notification."},{"line_number":547,"context_line":"        self.flags(enable\u003dFalse, group\u003d\u0027cells\u0027)"},{"line_number":548,"context_line":"        old_ref \u003d dict(self.fake_instance, display_name\u003d\u0027hello\u0027)"},{"line_number":549,"context_line":"        fake_uuid \u003d old_ref[\u0027uuid\u0027]"},{"line_number":550,"context_line":"        expected_updates \u003d dict(display_name\u003d\u0027goodbye\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_bc45a219","side":"PARENT","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":47},"updated":"2019-04-12 22:53:16.000000000","message":"ditto","commit_id":"bb39296c331948c29ad9aa6422cb103095ce851c"}]}