)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4dca66d4d2f26e8fda33524a3da37971c4012486","unresolved":false,"context_lines":[{"line_number":3462,"context_line":"    @check_instance_lock"},{"line_number":3463,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED])"},{"line_number":3464,"context_line":"    def resize(self, context, instance, flavor_id\u003dNone, clean_shutdown\u003dTrue,"},{"line_number":3465,"context_line":"               host_name\u003dNone, **extra_instance_updates):"},{"line_number":3466,"context_line":"        \"\"\"Resize (ie, migrate) a running instance."},{"line_number":3467,"context_line":""},{"line_number":3468,"context_line":"        If flavor_id is None, the process is considered a migration, keeping"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_46ad7e86","line":3465,"range":{"start_line":3465,"start_character":31,"end_line":3465,"end_character":55},"updated":"2019-06-07 13:39:02.000000000","message":"It looks like for resize (not cold migrate) the only possible kwarg here is auto_disk_config. Therefore it would be nice to drop this dumb **kwargs and make it explicitly an auto_disk_config parameter, but could be done in a follow up. Maybe just leave a TODO here.","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0c26229b2a0f430e28d119039b3f2e801609195","unresolved":false,"context_lines":[{"line_number":3462,"context_line":"    @check_instance_lock"},{"line_number":3463,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED])"},{"line_number":3464,"context_line":"    def resize(self, context, instance, flavor_id\u003dNone, clean_shutdown\u003dTrue,"},{"line_number":3465,"context_line":"               host_name\u003dNone, **extra_instance_updates):"},{"line_number":3466,"context_line":"        \"\"\"Resize (ie, migrate) a running instance."},{"line_number":3467,"context_line":""},{"line_number":3468,"context_line":"        If flavor_id is None, the process is considered a migration, keeping"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_261de565","line":3465,"range":{"start_line":3465,"start_character":31,"end_line":3465,"end_character":55},"in_reply_to":"9fb8cfa7_46ad7e86","updated":"2019-06-07 16:23:28.000000000","message":"Done","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d05dd37157590826f4b70d2ac2b23eb5736bde8c","unresolved":false,"context_lines":[{"line_number":3462,"context_line":"    @check_instance_lock"},{"line_number":3463,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED])"},{"line_number":3464,"context_line":"    def resize(self, context, instance, flavor_id\u003dNone, clean_shutdown\u003dTrue,"},{"line_number":3465,"context_line":"               host_name\u003dNone, **extra_instance_updates):"},{"line_number":3466,"context_line":"        \"\"\"Resize (ie, migrate) a running instance."},{"line_number":3467,"context_line":""},{"line_number":3468,"context_line":"        If flavor_id is None, the process is considered a migration, keeping"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_d7e036fd","line":3465,"range":{"start_line":3465,"start_character":31,"end_line":3465,"end_character":55},"updated":"2019-06-07 15:14:21.000000000","message":"As noted in PS7 I would have liked to see a TODO here to change this from **kwargs essentially to a single named auto_disk_config kwarg since that\u0027s all that we can pass in here for resize (and cold migrate doesn\u0027t pass anything extra).","commit_id":"2652d89522e73e6a1840bc05508fe5921b336157"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef1b8a8cce4023deaec108c688fd17b5a1b50e31","unresolved":false,"context_lines":[{"line_number":1402,"context_line":"        LOG.error(\u0027Error: %s\u0027, exc_info[1], instance_uuid\u003dinstance_uuid,"},{"line_number":1403,"context_line":"                  exc_info\u003dexc_info)"},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"    # TODO(mriedem): This method is confusing and only ever used for resize"},{"line_number":1406,"context_line":"    # reschedules; remove it and merge into _reschedule_resize_or_reraise."},{"line_number":1407,"context_line":"    def _reschedule(self, context, request_spec, filter_properties,"},{"line_number":1408,"context_line":"            instance, reschedule_method, method_args, task_state,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_e2a6f553","side":"PARENT","line":1405,"updated":"2019-05-22 15:32:27.000000000","message":"Can we deal with this in a separate change because it\u0027s kind of hard to review the refactor of this alongside the cells v1 removal part of this change.","commit_id":"0ca5a35e5a92ad8ecd29caebfa8f201722cf55b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c450aa7162d2f16ff91a7d7bab9d5c800fb47be9","unresolved":false,"context_lines":[{"line_number":4416,"context_line":"                exception\u003derror,"},{"line_number":4417,"context_line":"                tb\u003d\u0027,\u0027.join(traceback.format_exception(*exc_info)))"},{"line_number":4418,"context_line":""},{"line_number":4419,"context_line":"        if rescheduled:"},{"line_number":4420,"context_line":"            self._log_original_error(exc_info, instance_uuid)"},{"line_number":4421,"context_line":"            compute_utils.add_instance_fault_from_exc(context,"},{"line_number":4422,"context_line":"                    instance, exc_info[1], exc_info\u003dexc_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_22d64dc5","line":4419,"updated":"2019-05-22 16:01:19.000000000","message":"Yes, this is unrelated but can we keep it? Please please please","commit_id":"bd70597205cbe0abd329341aee33971cc11fccea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4dca66d4d2f26e8fda33524a3da37971c4012486","unresolved":false,"context_lines":[{"line_number":4445,"context_line":"                scheduler_hint \u003d {\u0027filter_properties\u0027: filter_properties}"},{"line_number":4446,"context_line":""},{"line_number":4447,"context_line":"                self.compute_task_api.resize_instance("},{"line_number":4448,"context_line":"                    context, instance, None, scheduler_hint, instance_type,"},{"line_number":4449,"context_line":"                    request_spec\u003drequest_spec, host_list\u003dhost_list)"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"                rescheduled \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_4649fecd","side":"PARENT","line":4448,"range":{"start_line":4448,"start_character":39,"end_line":4448,"end_character":43},"updated":"2019-06-07 13:39:02.000000000","message":"Just drop this, I don\u0027t know why they all need to change to named kwargs.","commit_id":"c6aa5828183837a5e3cb9229758097e3f64acf9a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"43a7c5f9ad6d93b736f0cf3613971a92f6c2125f","unresolved":false,"context_lines":[{"line_number":4445,"context_line":"                scheduler_hint \u003d {\u0027filter_properties\u0027: filter_properties}"},{"line_number":4446,"context_line":""},{"line_number":4447,"context_line":"                self.compute_task_api.resize_instance("},{"line_number":4448,"context_line":"                    context, instance, None, scheduler_hint, instance_type,"},{"line_number":4449,"context_line":"                    request_spec\u003drequest_spec, host_list\u003dhost_list)"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"                rescheduled \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_accc59bc","side":"PARENT","line":4448,"range":{"start_line":4448,"start_character":39,"end_line":4448,"end_character":43},"in_reply_to":"9fb8cfa7_4649fecd","updated":"2019-06-07 14:32:35.000000000","message":"Yeah, split out to a separate patch","commit_id":"c6aa5828183837a5e3cb9229758097e3f64acf9a"}],"nova/conductor/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4dca66d4d2f26e8fda33524a3da37971c4012486","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.conductor_compute_rpcapi \u003d rpcapi.ComputeTaskAPI()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def resize_instance(self, context, instance, scheduler_hint, flavor,"},{"line_number":88,"context_line":"                        reservations\u003dNone, clean_shutdown\u003dTrue,"},{"line_number":89,"context_line":"                        request_spec\u003dNone, host_list\u003dNone):"},{"line_number":90,"context_line":"        self.conductor_compute_rpcapi.migrate_server("},{"line_number":91,"context_line":"            context, instance, scheduler_hint, live\u003dFalse, rebuild\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_c683aecb","line":88,"range":{"start_line":88,"start_character":24,"end_line":88,"end_character":41},"updated":"2019-06-07 13:39:02.000000000","message":"Pretty sure we could also remove this also since we don\u0027t use reservations anymore but I\u0027d handle that in a follow up since it\u0027s unrelated to cells v1 removal.","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0c26229b2a0f430e28d119039b3f2e801609195","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.conductor_compute_rpcapi \u003d rpcapi.ComputeTaskAPI()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def resize_instance(self, context, instance, scheduler_hint, flavor,"},{"line_number":88,"context_line":"                        reservations\u003dNone, clean_shutdown\u003dTrue,"},{"line_number":89,"context_line":"                        request_spec\u003dNone, host_list\u003dNone):"},{"line_number":90,"context_line":"        self.conductor_compute_rpcapi.migrate_server("},{"line_number":91,"context_line":"            context, instance, scheduler_hint, live\u003dFalse, rebuild\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_e64d8d72","line":88,"range":{"start_line":88,"start_character":24,"end_line":88,"end_character":41},"in_reply_to":"9fb8cfa7_c683aecb","updated":"2019-06-07 16:23:28.000000000","message":"Done","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c450aa7162d2f16ff91a7d7bab9d5c800fb47be9","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"            },"},{"line_number":1115,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[2])"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._resize\u0027)"},{"line_number":1118,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._prep_resize\u0027)"},{"line_number":1119,"context_line":"    def test_resize_server_error_and_reschedule_was_failed("},{"line_number":1120,"context_line":"            self, mock_prep_resize, mock_resize):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_62ed258a","line":1117,"updated":"2019-05-22 16:01:19.000000000","message":"This is why we need the \u0027_resize\u0027 function. If someone else can think of a way to stub out \u0027ComputeTaskAPI.resize_instance\u0027 but only for the \u0027ComputeManager\u0027 instance, I\u0027d be happy to hear it","commit_id":"bd70597205cbe0abd329341aee33971cc11fccea"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4dca66d4d2f26e8fda33524a3da37971c4012486","unresolved":false,"context_lines":[{"line_number":12885,"context_line":"            mock_update.assert_called_once_with("},{"line_number":12886,"context_line":"                self.context, mock.ANY, task_state\u003dtask_states.RESIZE_PREP)"},{"line_number":12887,"context_line":"            mock_resize.assert_called_once_with("},{"line_number":12888,"context_line":"                context\u003dself.context, instance\u003dmock.ANY,"},{"line_number":12889,"context_line":"                scheduler_hint\u003d{\u0027filter_properties\u0027: filter_properties},"},{"line_number":12890,"context_line":"                flavor\u003dself.instance_type, request_spec\u003dself.request_spec,"},{"line_number":12891,"context_line":"                host_list\u003dNone)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_26664a53","line":12888,"updated":"2019-06-07 13:39:02.000000000","message":"You wouldn\u0027t need to change all of this if you didn\u0027t change to named kwargs for whatever reason. -1 for that unrelated change.","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"43a7c5f9ad6d93b736f0cf3613971a92f6c2125f","unresolved":false,"context_lines":[{"line_number":12885,"context_line":"            mock_update.assert_called_once_with("},{"line_number":12886,"context_line":"                self.context, mock.ANY, task_state\u003dtask_states.RESIZE_PREP)"},{"line_number":12887,"context_line":"            mock_resize.assert_called_once_with("},{"line_number":12888,"context_line":"                context\u003dself.context, instance\u003dmock.ANY,"},{"line_number":12889,"context_line":"                scheduler_hint\u003d{\u0027filter_properties\u0027: filter_properties},"},{"line_number":12890,"context_line":"                flavor\u003dself.instance_type, request_spec\u003dself.request_spec,"},{"line_number":12891,"context_line":"                host_list\u003dNone)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_4cbb5d0d","line":12888,"in_reply_to":"9fb8cfa7_26664a53","updated":"2019-06-07 14:32:35.000000000","message":"Done","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aa1b416826896f2f9bd2acbec6f1c8f99623c175","unresolved":false,"context_lines":[{"line_number":1891,"context_line":"                     flavor_id_passed\u003dTrue,"},{"line_number":1892,"context_line":"                     same_host\u003dFalse, allow_same_host\u003dFalse,"},{"line_number":1893,"context_line":"                     project_id\u003dNone,"},{"line_number":1894,"context_line":"                     extra_kwargs\u003dNone,"},{"line_number":1895,"context_line":"                     same_flavor\u003dFalse,"},{"line_number":1896,"context_line":"                     clean_shutdown\u003dTrue,"},{"line_number":1897,"context_line":"                     host_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fb8cfa7_a9d18f25","side":"PARENT","line":1894,"updated":"2019-06-10 14:27:30.000000000","message":"This seems unrelated (but good)","commit_id":"1316c1c2850d2f966f335b628f7f5fe88cef611c"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4dca66d4d2f26e8fda33524a3da37971c4012486","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # The API method is actually \u0027resize_instance\u0027.  It gets"},{"line_number":402,"context_line":"            # converted into \u0027migrate_server\u0027 when doing RPC."},{"line_number":403,"context_line":"            self.conductor.resize_instance("},{"line_number":404,"context_line":"                context\u003dself.context, instance\u003dinst_obj,"},{"line_number":405,"context_line":"                scheduler_hint\u003dscheduler_hint, flavor\u003dflavor, reservations\u003d[],"},{"line_number":406,"context_line":"                clean_shutdown\u003dclean_shutdown, host_list\u003dNone)"},{"line_number":407,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_e65fd26f","line":404,"updated":"2019-06-07 13:39:02.000000000","message":"same","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"43a7c5f9ad6d93b736f0cf3613971a92f6c2125f","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # The API method is actually \u0027resize_instance\u0027.  It gets"},{"line_number":402,"context_line":"            # converted into \u0027migrate_server\u0027 when doing RPC."},{"line_number":403,"context_line":"            self.conductor.resize_instance("},{"line_number":404,"context_line":"                context\u003dself.context, instance\u003dinst_obj,"},{"line_number":405,"context_line":"                scheduler_hint\u003dscheduler_hint, flavor\u003dflavor, reservations\u003d[],"},{"line_number":406,"context_line":"                clean_shutdown\u003dclean_shutdown, host_list\u003dNone)"},{"line_number":407,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_0c3b259c","line":404,"in_reply_to":"9fb8cfa7_e65fd26f","updated":"2019-06-07 14:32:35.000000000","message":"Done","commit_id":"3bec0514c54d9b2b00d91948344c441d379dd44f"}]}