)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50909bf0b23024f5de9932dc14a75cd549785445","unresolved":false,"context_lines":[{"line_number":3162,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED,"},{"line_number":3163,"context_line":"                                    vm_states.ERROR])"},{"line_number":3164,"context_line":"    def rebuild(self, context, instance, image_href, admin_password,"},{"line_number":3165,"context_line":"                files_to_inject\u003dNone, **kwargs):"},{"line_number":3166,"context_line":"        \"\"\"Rebuild the given instance with the provided attributes.\"\"\""},{"line_number":3167,"context_line":"        files_to_inject \u003d files_to_inject or []"},{"line_number":3168,"context_line":"        metadata \u003d kwargs.get(\u0027metadata\u0027, {})"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_37fe7237","line":3165,"range":{"start_line":3165,"start_character":38,"end_line":3165,"end_character":46},"updated":"2019-06-07 15:36:23.000000000","message":"Similar to https://review.opendev.org/#/c/651311/8/nova/compute/api.py it would be nice to at some point expand this out to named kwargs for sanity but in a follow up.","commit_id":"818ff1267050ac946f55275121605de33a345e20"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4f523f4f0b0a3369bbef397bffe4765847e72df","unresolved":false,"context_lines":[{"line_number":3162,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED,"},{"line_number":3163,"context_line":"                                    vm_states.ERROR])"},{"line_number":3164,"context_line":"    def rebuild(self, context, instance, image_href, admin_password,"},{"line_number":3165,"context_line":"                files_to_inject\u003dNone, **kwargs):"},{"line_number":3166,"context_line":"        \"\"\"Rebuild the given instance with the provided attributes.\"\"\""},{"line_number":3167,"context_line":"        files_to_inject \u003d files_to_inject or []"},{"line_number":3168,"context_line":"        metadata \u003d kwargs.get(\u0027metadata\u0027, {})"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_a65a35f0","line":3165,"range":{"start_line":3165,"start_character":38,"end_line":3165,"end_character":46},"in_reply_to":"9fb8cfa7_37fe7237","updated":"2019-06-07 16:28:45.000000000","message":"Done","commit_id":"818ff1267050ac946f55275121605de33a345e20"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"50d0f8a94e8e1a33833e65f1176676a7b9d408ae","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                   block_device_info\u003dblock_device_info,"},{"line_number":794,"context_line":"                   reboot_type\u003dreboot_type)"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    # TODO(stephenfin): Remove kwargs in version 6.0"},{"line_number":797,"context_line":"    def rebuild_instance(self, ctxt, instance, new_pass, injected_files,"},{"line_number":798,"context_line":"            image_ref, orig_image_ref, orig_sys_metadata, bdms,"},{"line_number":799,"context_line":"            recreate, on_shared_storage, host, node,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_bb00cd02","line":796,"updated":"2019-05-28 20:45:28.000000000","message":"We can remove it here, its on the manager we need to add the comment about removing it later, I think?","commit_id":"53a8a2878dadc26e15c66491510e23c4473b9c09"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"755b76b89ac1ddc3e112044c504c4f679acf66f9","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                   block_device_info\u003dblock_device_info,"},{"line_number":794,"context_line":"                   reboot_type\u003dreboot_type)"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    # TODO(stephenfin): Remove kwargs in version 6.0"},{"line_number":797,"context_line":"    def rebuild_instance(self, ctxt, instance, new_pass, injected_files,"},{"line_number":798,"context_line":"            image_ref, orig_image_ref, orig_sys_metadata, bdms,"},{"line_number":799,"context_line":"            recreate, on_shared_storage, host, node,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_2a2a382b","line":796,"in_reply_to":"bfb3d3c7_bb00cd02","updated":"2019-05-29 16:22:16.000000000","message":"Oh, of course. Done","commit_id":"53a8a2878dadc26e15c66491510e23c4473b9c09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50909bf0b23024f5de9932dc14a75cd549785445","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        # NOTE(edleafe): compute nodes can only use the dict form of limits."},{"line_number":801,"context_line":"        if isinstance(limits, objects.SchedulerLimits):"},{"line_number":802,"context_line":"            limits \u003d limits.to_dict()"},{"line_number":803,"context_line":"        # NOTE(danms): kwargs is only here for cells compatibility, don\u0027t"},{"line_number":804,"context_line":"        # actually send it to compute"},{"line_number":805,"context_line":"        msg_args \u003d {\u0027preserve_ephemeral\u0027: preserve_ephemeral,"},{"line_number":806,"context_line":"                    \u0027migration\u0027: migration,"},{"line_number":807,"context_line":"                    \u0027scheduled_node\u0027: node,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_57f9a64a","line":804,"range":{"start_line":803,"start_character":8,"end_line":804,"end_character":37},"updated":"2019-06-07 15:36:23.000000000","message":"You should remove this.","commit_id":"818ff1267050ac946f55275121605de33a345e20"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"50d0f8a94e8e1a33833e65f1176676a7b9d408ae","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        cctxt \u003d self.client.prepare(version\u003dversion)"},{"line_number":412,"context_line":"        cctxt.cast(context, \u0027unshelve_instance\u0027, **kw)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # TODO(stephenfin): Remove \u0027kwargs\u0027 in version 4.0 of the API"},{"line_number":415,"context_line":"    def rebuild_instance(self, ctxt, instance, new_pass, injected_files,"},{"line_number":416,"context_line":"            image_ref, orig_image_ref, orig_sys_metadata, bdms,"},{"line_number":417,"context_line":"            recreate\u003dFalse, on_shared_storage\u003dFalse, host\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_7b06d51e","line":414,"updated":"2019-05-28 20:45:28.000000000","message":"As before, this comment goes on the manager, I believe.","commit_id":"53a8a2878dadc26e15c66491510e23c4473b9c09"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"755b76b89ac1ddc3e112044c504c4f679acf66f9","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        cctxt \u003d self.client.prepare(version\u003dversion)"},{"line_number":412,"context_line":"        cctxt.cast(context, \u0027unshelve_instance\u0027, **kw)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # TODO(stephenfin): Remove \u0027kwargs\u0027 in version 4.0 of the API"},{"line_number":415,"context_line":"    def rebuild_instance(self, ctxt, instance, new_pass, injected_files,"},{"line_number":416,"context_line":"            image_ref, orig_image_ref, orig_sys_metadata, bdms,"},{"line_number":417,"context_line":"            recreate\u003dFalse, on_shared_storage\u003dFalse, host\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_ea1f4005","line":414,"in_reply_to":"bfb3d3c7_7b06d51e","updated":"2019-05-29 16:22:16.000000000","message":"Done","commit_id":"53a8a2878dadc26e15c66491510e23c4473b9c09"}]}