)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4cd190b8cc94c4b9acfc4e96ee3a6a4bd2cadb6c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-06-07 17:27:45 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop passing \u0027delete_type\u0027 to \u0027terminate_instance\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Part of blueprint remove-cells-v1"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ifaa414fe9ab104ba141fd27bff8fb1b7f8da7684"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9fb8cfa7_e6f02d6a","line":8,"updated":"2019-06-07 16:50:42.000000000","message":"nit: could have mentioned that _do_force_delete is dropped since it is now redundant with _do_delete.","commit_id":"da434b44d2f3dc6169dbde1a692b052191d9f871"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3d689acdcb5af9f52e95e0c8bba15701a6b9350","unresolved":false,"context_lines":[{"line_number":2261,"context_line":"            self.compute_rpcapi.terminate_instance(context, instance, bdms)"},{"line_number":2262,"context_line":"        self._update_queued_for_deletion(context, instance, True)"},{"line_number":2263,"context_line":""},{"line_number":2264,"context_line":"    def _do_force_delete(self, context, instance, bdms, local\u003dFalse):"},{"line_number":2265,"context_line":"        if local:"},{"line_number":2266,"context_line":"            instance.vm_state \u003d vm_states.DELETED"},{"line_number":2267,"context_line":"            instance.task_state \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_97adde32","line":2264,"range":{"start_line":2264,"start_character":8,"end_line":2264,"end_character":24},"updated":"2019-06-07 15:38:32.000000000","message":"This method is now an exact copy of _do_delete so can\u0027t we just drop this method and use _do_delete in it\u0027s place?","commit_id":"54f2ccc47d80d178063a9f2f9f7a2e4ffb283a45"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9290a38b01c125f9957bdcb74701441a486f1a8b","unresolved":false,"context_lines":[{"line_number":2261,"context_line":"            self.compute_rpcapi.terminate_instance(context, instance, bdms)"},{"line_number":2262,"context_line":"        self._update_queued_for_deletion(context, instance, True)"},{"line_number":2263,"context_line":""},{"line_number":2264,"context_line":"    def _do_force_delete(self, context, instance, bdms, local\u003dFalse):"},{"line_number":2265,"context_line":"        if local:"},{"line_number":2266,"context_line":"            instance.vm_state \u003d vm_states.DELETED"},{"line_number":2267,"context_line":"            instance.task_state \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_66f99dc6","line":2264,"range":{"start_line":2264,"start_character":8,"end_line":2264,"end_character":24},"in_reply_to":"9fb8cfa7_97adde32","updated":"2019-06-07 16:27:55.000000000","message":"Good spot. Done.","commit_id":"54f2ccc47d80d178063a9f2f9f7a2e4ffb283a45"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9b3cc38b7e6f01856665d5caad92f289fc46e375","unresolved":false,"context_lines":[{"line_number":991,"context_line":"                server\u003d_compute_host(None, instance), version\u003dversion)"},{"line_number":992,"context_line":"        cctxt.cast(ctxt, \u0027suspend_instance\u0027, instance\u003dinstance)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    # TODO(stephenfin): Remove \u0027delete_type\u0027 in version 6.0"},{"line_number":995,"context_line":"    def terminate_instance(self, ctxt, instance, bdms, delete_type\u003dNone):"},{"line_number":996,"context_line":"        # NOTE(rajesht): The `delete_type` parameter is passed because"},{"line_number":997,"context_line":"        # the method signature has to match with `terminate_instance()`"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_600ce440","line":994,"updated":"2019-05-28 20:44:14.000000000","message":"I think we can remove it in this code, as only \"new\" code will call this code, but we should instead put the TODO on the compute manager. I think...?","commit_id":"c50bed1c711b24ccdf2d47a783f71ecbe8c37536"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6458e54bc8ed28c6a99c0e4ed08437d9842566f6","unresolved":false,"context_lines":[{"line_number":991,"context_line":"                server\u003d_compute_host(None, instance), version\u003dversion)"},{"line_number":992,"context_line":"        cctxt.cast(ctxt, \u0027suspend_instance\u0027, instance\u003dinstance)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    # TODO(stephenfin): Remove \u0027delete_type\u0027 in version 6.0"},{"line_number":995,"context_line":"    def terminate_instance(self, ctxt, instance, bdms, delete_type\u003dNone):"},{"line_number":996,"context_line":"        # NOTE(rajesht): The `delete_type` parameter is passed because"},{"line_number":997,"context_line":"        # the method signature has to match with `terminate_instance()`"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_2aad589a","line":994,"in_reply_to":"bfb3d3c7_600ce440","updated":"2019-05-29 16:22:32.000000000","message":"Done","commit_id":"c50bed1c711b24ccdf2d47a783f71ecbe8c37536"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4cd190b8cc94c4b9acfc4e96ee3a6a4bd2cadb6c","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"        if is_shelved:"},{"line_number":1184,"context_line":"            mock_image_delete.assert_called_once_with(self.context,"},{"line_number":1185,"context_line":"                                                      snapshot_id)"},{"line_number":1186,"context_line":"        if not cast and delete_type \u003d\u003d \u0027delete\u0027:"},{"line_number":1187,"context_line":"            mock_notify.assert_has_calls(["},{"line_number":1188,"context_line":"                mock.call(self.context, inst, host\u003d\u0027fake-mini\u0027,"},{"line_number":1189,"context_line":"                          source\u003d\u0027nova-api\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_a69f9501","line":1186,"range":{"start_line":1186,"start_character":24,"end_line":1186,"end_character":48},"updated":"2019-06-07 16:50:42.000000000","message":"nit: this could be \"delete_type !\u003d \u0027soft_delete\u0027\"","commit_id":"da434b44d2f3dc6169dbde1a692b052191d9f871"}]}