)]}'
{"id":"openstack%2Fnova~652150","triplet_id":"openstack%2Fnova~stable%2Fqueens~Ic7d78ad43a2bad7f932c22c98944accbbed9e9e2","project":"openstack/nova","branch":"stable/queens","topic":"bug/1821594","hashtags":[],"change_id":"Ic7d78ad43a2bad7f932c22c98944accbbed9e9e2","subject":"Error out migration when confirm_resize fails","status":"MERGED","created":"2019-04-12 20:56:16.000000000","updated":"2019-05-24 10:23:51.000000000","submitted":"2019-05-24 10:23:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"652150-1558693431240-ba97d950","meta_rev_id":"fbc9315540f4d81911f315bde4dc8edb74c5c4d8","_number":652150,"virtual_id_number":652150,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"date":"2019-04-12 20:56:57.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-04-12 21:39:29.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-04-12 23:19:42.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-24 10:23:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-04-23 20:35:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2019-05-24 06:05:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2019-05-24 06:05:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-12 20:56:57.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-12 21:39:29.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-04-12 23:19:42.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-23 20:35:17.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-05-24 06:05:52.000000000","updated_by":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"reviewer":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"state":"REVIEWER"},{"updated":"2019-05-24 10:23:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f2b7098336b9a1e563add315117f0c6793e77238","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-12 20:56:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a1a9a79d738178d062687d2fb2581bf42737e8fb","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-04-12 20:56:57.000000000","message":"Patch Set 1:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"2b799c2be34da7bb4ad2d7b0c4f4d4e062c9454b","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-12 21:39:29.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/652150/1 : FAILURE in 42m 28s","accounts_in_message":[],"_revision_number":1},{"id":"971c9a6ff77d3d0fcd60514de708e4d8512b23ac","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-12 22:56:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/652150/1/check/openstack-tox-pep8/21d92a0/ : SUCCESS in 9m 50s\n- openstack-tox-py27 http://logs.openstack.org/50/652150/1/check/openstack-tox-py27/d07eaa7/ : SUCCESS in 12m 12s\n- openstack-tox-py35 http://logs.openstack.org/50/652150/1/check/openstack-tox-py35/f3c45cf/ : SUCCESS in 14m 45s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/652150/1/check/build-openstack-sphinx-docs/4892880/html/ : SUCCESS in 6m 26s\n- tempest-full http://logs.openstack.org/50/652150/1/check/tempest-full/c9d1e6d/ : SUCCESS in 1h 31m 00s\n- neutron-grenade http://logs.openstack.org/50/652150/1/check/neutron-grenade/5ed96e3/ : SUCCESS in 57m 16s\n- tempest-full-py3 http://logs.openstack.org/50/652150/1/check/tempest-full-py3/c4a4eae/ : SUCCESS in 1h 22m 22s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/50/652150/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/74ce528/ : SUCCESS in 48m 23s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/50/652150/1/check/nova-cells-v1/8bdf702/ : SUCCESS in 48m 08s\n- nova-live-migration http://logs.openstack.org/50/652150/1/check/nova-live-migration/016bc24/ : SUCCESS in 43m 35s\n- nova-multiattach http://logs.openstack.org/50/652150/1/check/nova-multiattach/37163aa/ : SUCCESS in 1h 02m 23s\n- nova-next http://logs.openstack.org/50/652150/1/check/nova-next/456152d/ : SUCCESS in 1h 14m 36s\n- tempest-slow http://logs.openstack.org/50/652150/1/check/tempest-slow/a5398e5/ : SUCCESS in 1h 52m 08s\n- nova-tox-functional http://logs.openstack.org/50/652150/1/check/nova-tox-functional/2577e64/ : SUCCESS in 26m 02s\n- nova-tox-functional-py35 http://logs.openstack.org/50/652150/1/check/nova-tox-functional-py35/f068c15/ : SUCCESS in 19m 27s\n- neutron-grenade-multinode http://logs.openstack.org/50/652150/1/check/neutron-grenade-multinode/cb20a7e/ : SUCCESS in 1h 21m 23s\n- legacy-grenade-dsvm-neutron-multinode-live-migration http://logs.openstack.org/50/652150/1/check/legacy-grenade-dsvm-neutron-multinode-live-migration/6b7057b/ : FAILURE in 1h 01m 43s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/50/652150/1/check/devstack-plugin-ceph-tempest/62e1504/ : FAILURE in 1h 14m 12s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/50/652150/1/check/tempest-multinode-full/89936b0/ : SUCCESS in 1h 44m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"272f0bd8165dfc2de58cb4babf619f61f6ed1c17","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-04-12 23:19:42.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/50/652150/1/check/tempest-dsvm-full-xenial/5da8030/ : SUCCESS in 1h 10m 01s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/50/652150/1/check/tempest-dsvm-full-xenial-py3/c4bdf80/ : FAILURE in 1h 02m 16s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/50/652150/1/check/grenade-dsvm-xenial/053bc34/ : SUCCESS in 50m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d2775600a1e68ad4ea13d582c292826a69e24364","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-04-23 20:35:17.000000000","message":"Patch Set 1: Code-Review+2\n\nMerged to stable/rocky. Looks like a good thing to backport.","accounts_in_message":[],"_revision_number":1},{"id":"a7540976b10584da954d00c251c774b0e3c9fe1a","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-05-24 06:05:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"721cba68c13a6d5aa5693e4a1ea56f48559f7445","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 06:06:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4d250d081217c7acc73241d32e91af3edbbd0763","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 10:23:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/652150/1/gate/openstack-tox-pep8/1b48ad6/ : SUCCESS in 8m 52s\n- openstack-tox-py27 http://logs.openstack.org/50/652150/1/gate/openstack-tox-py27/56c4a09/ : SUCCESS in 13m 15s\n- openstack-tox-py35 http://logs.openstack.org/50/652150/1/gate/openstack-tox-py35/0c9c18a/ : SUCCESS in 13m 17s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/652150/1/gate/build-openstack-sphinx-docs/806ca28/html/ : SUCCESS in 8m 16s\n- tempest-full http://logs.openstack.org/50/652150/1/gate/tempest-full/183f6c0/ : SUCCESS in 1h 23m 37s\n- neutron-grenade http://logs.openstack.org/50/652150/1/gate/neutron-grenade/a36ea1c/ : SUCCESS in 58m 34s\n- tempest-full-py3 http://logs.openstack.org/50/652150/1/gate/tempest-full-py3/2b2e79f/ : SUCCESS in 1h 32m 09s\n- nova-cells-v1 http://logs.openstack.org/50/652150/1/gate/nova-cells-v1/5e76c0b/ : SUCCESS in 45m 42s\n- nova-live-migration http://logs.openstack.org/50/652150/1/gate/nova-live-migration/10cb628/ : SUCCESS in 43m 43s\n- nova-multiattach http://logs.openstack.org/50/652150/1/gate/nova-multiattach/e4e6068/ : SUCCESS in 52m 39s\n- nova-next http://logs.openstack.org/50/652150/1/gate/nova-next/e852170/ : SUCCESS in 1h 10m 56s\n- tempest-slow http://logs.openstack.org/50/652150/1/gate/tempest-slow/081a91e/ : SUCCESS in 1h 42m 23s\n- nova-tox-functional http://logs.openstack.org/50/652150/1/gate/nova-tox-functional/4b1a1b4/ : SUCCESS in 21m 02s\n- nova-tox-functional-py35 http://logs.openstack.org/50/652150/1/gate/nova-tox-functional-py35/111fb8d/ : SUCCESS in 18m 16s","accounts_in_message":[],"_revision_number":1},{"id":"9c302b4510f4a8d952a05849e8fbeb42dcfa9462","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 10:23:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c6a42cd3b38528bbf410b33c3bfc384600ae053f","revisions":{"c6a42cd3b38528bbf410b33c3bfc384600ae053f":{"kind":"REWORK","_number":1,"created":"2019-04-12 20:56:16.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/50/652150/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/652150/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/652150/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/652150/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/652150/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/652150/1"}}},"commit":{"parents":[{"commit":"f1554d1b527bbf09229273508ce1fb234caf6a66","subject":"prevent common kwargs from glance client failure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f1554d1b527bbf09229273508ce1fb234caf6a66"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-03-25 17:16:42.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-12 20:55:11.000000000","tz":-240},"subject":"Error out migration when confirm_resize fails","message":"Error out migration when confirm_resize fails\n\nIf anything fails and raises an exception during\nconfirm_resize, the migration status is stuck in\n\"confirming\" status even though the instance status\nmay be \"ERROR\".\n\nThis change adds the errors_out_migration decorator\nto the confirm_resize method to make sure the migration\nstatus is \"error\" if an error is raised.\n\nIn bug 1821594 it was the driver.confirm_migration\nmethod that raised some exception, so a unit test is\nadded here which simulates a similar scenario.\n\nThis only partially closes the bug because we are still\nleaking allocations on the source node resource provider\nsince _delete_allocation_after_move is not called. That\nwill be dealt with in a separate patch.\n\nConflicts:\n      nova/tests/unit/compute/test_compute_mgr.py\n\nNOTE(mriedem): The conflict is due to not having change\nIa05525058e47efb806cf8820410c8bc80eccca25 in Queens.\n\nChange-Id: Ic7d78ad43a2bad7f932c22c98944accbbed9e9e2\nPartial-Bug: #1821594\n(cherry picked from commit 408ef8f84a698f764aa5d769d6d01fd9340de2e5)\n(cherry picked from commit 972d4e0eb391e83fe8d3020ff95db0e6a840a224)\n(cherry picked from commit e3f69c8af0d13f0aa60e9a267f25050729f7766c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6a42cd3b38528bbf410b33c3bfc384600ae053f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6a42cd3b38528bbf410b33c3bfc384600ae053f"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}