)]}'
{"nova/tests/functional/regressions/test_bug_1825034.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d2e612f83b35fc28e560985bee20416fef4cdcb7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.start_service(\u0027compute\u0027)"},{"line_number":48,"context_line":"        # the image fake backend needed for image discovery"},{"line_number":49,"context_line":"        fake_image.stub_out_image_service(self)"},{"line_number":50,"context_line":"        self.addCleanup(fake_image.FakeImageService_reset)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _create_server(self):"},{"line_number":53,"context_line":"        server \u003d self.api.post_server({"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_5c658fb4","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":58},"updated":"2019-05-06 17:21:37.000000000","message":"/me shudders\n\nThis is awful. First of all how this \"reset\" is done; second that the stub_out_image_service helper isn\u0027t adding this cleanup itself.\n\nAnyway, totally unrelated to this patch.","commit_id":"624dbe60aadc0a12ab3c8274b047024a9b4597b5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"060ee40b003ed1bfe7031f883c152563e9640114","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # marker record."},{"line_number":70,"context_line":"        ctxt \u003d nova_context.get_admin_context()"},{"line_number":71,"context_line":"        virtual_interface.fill_virtual_interface_list(ctxt, max_count\u003d50)"},{"line_number":72,"context_line":"        # Now archive the deleted instance record."},{"line_number":73,"context_line":"        table_to_rows_archived, deleted_instance_uuids \u003d ("},{"line_number":74,"context_line":"            db_api.archive_deleted_rows(max_rows\u003d1000))"},{"line_number":75,"context_line":"        self.assertIn(\u0027instances\u0027, table_to_rows_archived)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_344d5672","line":72,"updated":"2019-04-23 13:02:03.000000000","message":"Do we need this step to assert that the marker was created?","commit_id":"624dbe60aadc0a12ab3c8274b047024a9b4597b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"593ec9c009e3cf0f6cd527c3ac6a67325fc1f790","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # marker record."},{"line_number":70,"context_line":"        ctxt \u003d nova_context.get_admin_context()"},{"line_number":71,"context_line":"        virtual_interface.fill_virtual_interface_list(ctxt, max_count\u003d50)"},{"line_number":72,"context_line":"        # Now archive the deleted instance record."},{"line_number":73,"context_line":"        table_to_rows_archived, deleted_instance_uuids \u003d ("},{"line_number":74,"context_line":"            db_api.archive_deleted_rows(max_rows\u003d1000))"},{"line_number":75,"context_line":"        self.assertIn(\u0027instances\u0027, table_to_rows_archived)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_6791dc99","line":72,"in_reply_to":"dfbec78f_1c05d777","updated":"2019-05-06 17:53:29.000000000","message":"\u003e If you\u0027re going to leave it in, you should include a comment.\n\nDone using your suggested wording from IRC.","commit_id":"624dbe60aadc0a12ab3c8274b047024a9b4597b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62ca1697a623f0aabe4cfcbeda6735471c527201","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # marker record."},{"line_number":70,"context_line":"        ctxt \u003d nova_context.get_admin_context()"},{"line_number":71,"context_line":"        virtual_interface.fill_virtual_interface_list(ctxt, max_count\u003d50)"},{"line_number":72,"context_line":"        # Now archive the deleted instance record."},{"line_number":73,"context_line":"        table_to_rows_archived, deleted_instance_uuids \u003d ("},{"line_number":74,"context_line":"            db_api.archive_deleted_rows(max_rows\u003d1000))"},{"line_number":75,"context_line":"        self.assertIn(\u0027instances\u0027, table_to_rows_archived)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_34dd5614","line":72,"in_reply_to":"ffb9cba7_344d5672","updated":"2019-04-23 13:12:47.000000000","message":"No, this functional test actually started as an attempt to recreate another bug 1824435 which involves archive but while testing it I discovered the API bug being recreated here. I left the archive stuff in here since I think it\u0027s still useful information to assert we know how the online data migration is working.","commit_id":"624dbe60aadc0a12ab3c8274b047024a9b4597b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d2e612f83b35fc28e560985bee20416fef4cdcb7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # marker record."},{"line_number":70,"context_line":"        ctxt \u003d nova_context.get_admin_context()"},{"line_number":71,"context_line":"        virtual_interface.fill_virtual_interface_list(ctxt, max_count\u003d50)"},{"line_number":72,"context_line":"        # Now archive the deleted instance record."},{"line_number":73,"context_line":"        table_to_rows_archived, deleted_instance_uuids \u003d ("},{"line_number":74,"context_line":"            db_api.archive_deleted_rows(max_rows\u003d1000))"},{"line_number":75,"context_line":"        self.assertIn(\u0027instances\u0027, table_to_rows_archived)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_1c05d777","line":72,"in_reply_to":"ffb9cba7_34dd5614","updated":"2019-05-06 17:21:37.000000000","message":"\u003e I left the archive\n \u003e stuff in here since I think it\u0027s still useful information to assert\n \u003e we know how the online data migration is working.\n\nHmph. It\u0027s really confusing for the reader, though. If you\u0027re going to leave it in, you should include a comment.\n\nOr I guess you could move the archive stuff to after the main assertion.\n\n(To be clear, future me, L71-79 isn\u0027t necessary. L73-79 undoes the damage done by L71 when the bug is present.)","commit_id":"624dbe60aadc0a12ab3c8274b047024a9b4597b5"}]}