)]}'
{"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1e841a9c68f8cd0dce9d14e7d68662f857a5ffe","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            os_traits.COMPUTE_IMAGE_TYPE_AMI,"},{"line_number":385,"context_line":"            os_traits.COMPUTE_IMAGE_TYPE_ARI,"},{"line_number":386,"context_line":"            os_traits.COMPUTE_IMAGE_TYPE_ISO,"},{"line_number":387,"context_line":"            os_traits.COMPUTE_IMAGE_TYPE_QCOW2,"},{"line_number":388,"context_line":"            os_traits.COMPUTE_IMAGE_TYPE_RAW,"},{"line_number":389,"context_line":"        ]"},{"line_number":390,"context_line":"    ])"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_066cc234","line":387,"range":{"start_line":387,"start_character":22,"end_line":387,"end_character":46},"updated":"2019-05-03 19:47:46.000000000","message":"OK and this is in here because force_raw_images\u003dTrue by default.","commit_id":"785eb5a217b1f492bea014382758d0e6d12bd63f"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1e841a9c68f8cd0dce9d14e7d68662f857a5ffe","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":965,"context_line":"        self.assertTrue(drvr.capabilities[\u0027supports_image_type_qcow2\u0027])"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    def test_driver_capabilities_qcow2_with_lvm(self):"},{"line_number":968,"context_line":"        self.flags(images_type\u003d\u0027lvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":969,"context_line":"        self.flags(force_raw_images\u003dFalse)"},{"line_number":970,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_0627e214","line":967,"range":{"start_line":967,"start_character":8,"end_line":967,"end_character":47},"updated":"2019-05-03 19:47:46.000000000","message":"nit: could have merged the tests with ddt or a loop since the only thing that changes is the images_type option value.","commit_id":"785eb5a217b1f492bea014382758d0e6d12bd63f"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"df0ca2d29e7bf6c29916baecfef40fc245fc58b1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # which bleeds over into other tests."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        requires_raw_image \u003d ("},{"line_number":297,"context_line":"            CONF.libvirt.images_type \u003d\u003d \u0027rbd\u0027 and"},{"line_number":298,"context_line":"            not CONF.force_raw_images"},{"line_number":299,"context_line":"        )"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_7a685020","line":297,"updated":"2019-04-17 15:24:43.000000000","message":"Also LVM once https://review.openstack.org/#/c/642667/ lands, which looks imminent.","commit_id":"71fa57cddff6b4e07aeb96d95fe5e53654b2aa9a"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"df0ca2d29e7bf6c29916baecfef40fc245fc58b1","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            \"supports_multiattach\": False,"},{"line_number":313,"context_line":"            \"supports_trusted_certs\": True,"},{"line_number":314,"context_line":"            # Supported image types"},{"line_number":315,"context_line":"            \"supports_image_type_aki\": True,"},{"line_number":316,"context_line":"            \"supports_image_type_ari\": True,"},{"line_number":317,"context_line":"            \"supports_image_type_ami\": True,"},{"line_number":318,"context_line":"            # FIXME(danms): I can see a future where people might want to"},{"line_number":319,"context_line":"            # configure certain compute nodes to not allow giant raw images"},{"line_number":320,"context_line":"            # to be booted (like nodes that are across a WAN)."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_baa2384a","line":317,"range":{"start_line":315,"start_character":0,"end_line":317,"end_character":44},"updated":"2019-04-17 15:24:43.000000000","message":"There\u0027s presumably jiggery pokery to be done here too for the raw-only backends (ceph and lvm)?","commit_id":"71fa57cddff6b4e07aeb96d95fe5e53654b2aa9a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"80355ad3896e529695a513abb97b3c359fd55fa1","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            \"supports_multiattach\": False,"},{"line_number":313,"context_line":"            \"supports_trusted_certs\": True,"},{"line_number":314,"context_line":"            # Supported image types"},{"line_number":315,"context_line":"            \"supports_image_type_aki\": True,"},{"line_number":316,"context_line":"            \"supports_image_type_ari\": True,"},{"line_number":317,"context_line":"            \"supports_image_type_ami\": True,"},{"line_number":318,"context_line":"            # FIXME(danms): I can see a future where people might want to"},{"line_number":319,"context_line":"            # configure certain compute nodes to not allow giant raw images"},{"line_number":320,"context_line":"            # to be booted (like nodes that are across a WAN)."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_4bc6e89c","line":317,"range":{"start_line":315,"start_character":0,"end_line":317,"end_character":44},"in_reply_to":"3fce034c_baa2384a","updated":"2019-04-17 16:59:04.000000000","message":"I dunno, don\u0027t these end up with us kinda generating a filesystem from scratch anyway? I would have expected these to be somewhat independent of the actual backend because of how we construct them. But, happy to take advice from someone that knows better than I.","commit_id":"71fa57cddff6b4e07aeb96d95fe5e53654b2aa9a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db4acb17c4e9933f10ebd8362812b9dbb0901eb2","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # This prevents the risk of one test setting a capability"},{"line_number":295,"context_line":"        # which bleeds over into other tests."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        raw_only \u003d (\u0027rbd\u0027, \u0027lvm\u0027)"},{"line_number":298,"context_line":"        requires_raw_image \u003d ("},{"line_number":299,"context_line":"            CONF.libvirt.images_type in raw_only and"},{"line_number":300,"context_line":"            not CONF.force_raw_images"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_1d973593","line":297,"range":{"start_line":297,"start_character":28,"end_line":297,"end_character":31},"updated":"2019-05-03 16:40:40.000000000","message":"Is this only true if https://review.opendev.org/#/c/642667/ lands? If so, do you need to rebase on it?\n\nHow does \"flat\" work in this list? I thought \"flat\" was a default but what it is depends on use_cow_images.\n\nAnyway, comments with this logic would be useful because I hate the interdependency between the images_type/force_raw_images/use_cow_images options and have to always re-learn this.","commit_id":"10822ba45cc415e82d15ae5bb8de54cd1c2c2ae5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1e841a9c68f8cd0dce9d14e7d68662f857a5ffe","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # This prevents the risk of one test setting a capability"},{"line_number":295,"context_line":"        # which bleeds over into other tests."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        # LVM and RBD require raw images. If we are not configured to"},{"line_number":298,"context_line":"        # force convert images into raw format, then we _require_ raw"},{"line_number":299,"context_line":"        # images only."},{"line_number":300,"context_line":"        raw_only \u003d (\u0027rbd\u0027, \u0027lvm\u0027)"},{"line_number":301,"context_line":"        requires_raw_image \u003d (CONF.libvirt.images_type in raw_only and"},{"line_number":302,"context_line":"                              not CONF.force_raw_images)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_8605127d","line":299,"range":{"start_line":297,"start_character":42,"end_line":299,"end_character":22},"updated":"2019-05-03 19:47:46.000000000","message":"Ah OK because if we\u0027re forced to convert, then we can\u0027t support qcow2, but if we\u0027re going to convert cows to raw, we can also support cows. See, the comment helps!","commit_id":"785eb5a217b1f492bea014382758d0e6d12bd63f"}]}