)]}'
{"id":"openstack%2Fnova~653514","triplet_id":"openstack%2Fnova~stable%2Fpike~Iefab05e84ccc0bf8f15bdbbf515a290d282dbc5d","project":"openstack/nova","branch":"stable/pike","topic":"bug/1792077","hashtags":[],"change_id":"Iefab05e84ccc0bf8f15bdbbf515a290d282dbc5d","subject":"libvirt: set device address tag only if setting disk unit","status":"MERGED","created":"2019-04-17 19:05:37.000000000","updated":"2019-04-24 16:45:36.000000000","submitted":"2019-04-24 16:45:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"653514-1556124336264-7a5aba1f","meta_rev_id":"11676f7731ef6a296631695afa2688e1600f1c2e","_number":653514,"virtual_id_number":653514,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-04-19 12:29:37.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2019-04-22 15:03:58.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-04-19 14:14:26.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-04-22 12:55:30.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2019-04-22 14:43:17.000000000","_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-04-22 14:44:36.000000000","_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-24 16:45:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-04-22 14:46:03.000000000","_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-24 13:01:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-23 12:16:13.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-24 13:01:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-19 12:29:37.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-19 14:14:26.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-22 12:55:30.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-22 14:43:17.000000000","updated_by":{"_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-22 14:44:36.000000000","updated_by":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"reviewer":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-22 14:46:03.000000000","updated_by":{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},"reviewer":{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},"state":"REVIEWER"},{"updated":"2019-04-22 15:03:58.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-04-23 12:16:13.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-04-24 13:01:36.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-04-24 16:45:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cd0e3c7f6d0c4fbdeef53e0b6f7c083f68be3b51","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-04-17 19:05:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6ceb0b0c37c8def285822c5e6e0ee311206450be","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-04-17 20:15:24.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/14/653514/1/check/tempest-dsvm-full-xenial/b305348/ : SUCCESS in 1h 08m 57s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/14/653514/1/check/tempest-dsvm-full-xenial-py3/054feb3/ : FAILURE in 1h 04m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9ca3541c3d3ec1ef0ee72381923b748046e17a36","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-17 20:42:24.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/653514/1 : FAILURE in 42m 59s","accounts_in_message":[],"_revision_number":1},{"id":"b45c9ffc8ec2d9baa473e85ddb79292c4434b26e","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-04-18 03:35:44.000000000","message":"Patch Set 1:\n\nTesting succeeded on ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenail-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/653514/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/0bf05b8 : SUCCESS in 1h 32m 16s","accounts_in_message":[],"_revision_number":1},{"id":"13638091b797c984787f0e0a12c6b2b901776d7c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-18 06:12:41.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/14/653514/1/check/openstack-tox-pep8/8a90472/ : SUCCESS in 10m 04s\n- openstack-tox-py27 http://logs.openstack.org/14/653514/1/check/openstack-tox-py27/a2d2452/ : FAILURE in 15m 23s\n- openstack-tox-py35 http://logs.openstack.org/14/653514/1/check/openstack-tox-py35/640f844/ : FAILURE in 14m 14s\n- build-openstack-sphinx-docs http://logs.openstack.org/14/653514/1/check/build-openstack-sphinx-docs/bcce13f/html/ : SUCCESS in 7m 07s\n- tempest-full http://logs.openstack.org/14/653514/1/check/tempest-full/1384d1d/ : FAILURE in 1h 31m 30s\n- neutron-grenade http://logs.openstack.org/14/653514/1/check/neutron-grenade/81d1120/ : SUCCESS in 51m 57s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/14/653514/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/66cd73e/ : FAILURE in 56m 09s (non-voting)\n- nova-live-migration http://logs.openstack.org/14/653514/1/check/nova-live-migration/fc672c2/ : SUCCESS in 41m 50s\n- tempest-slow http://logs.openstack.org/14/653514/1/check/tempest-slow/1659cf9/ : SUCCESS in 1h 50m 22s\n- nova-tox-functional http://logs.openstack.org/14/653514/1/check/nova-tox-functional/0cde75f/ : SUCCESS in 19m 44s\n- nova-tox-functional-py35 http://logs.openstack.org/14/653514/1/check/nova-tox-functional-py35/d39158a/ : SUCCESS in 18m 23s\n- neutron-grenade-multinode http://logs.openstack.org/14/653514/1/check/neutron-grenade-multinode/e55bee4/ : SUCCESS in 1h 00m 02s\n- legacy-grenade-dsvm-neutron-multinode-live-migration http://logs.openstack.org/14/653514/1/check/legacy-grenade-dsvm-neutron-multinode-live-migration/57dc47a/ : SUCCESS in 58m 40s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/14/653514/1/check/devstack-plugin-ceph-tempest/93f583f/ : SUCCESS in 1h 20m 24s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/14/653514/1/check/tempest-multinode-full/35be716/ : SUCCESS in 1h 43m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e1a05a236024a1e2571f522c4c1f72beaf37efdc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-18 15:34:52.000000000","message":"Patch Set 1: Code-Review-1\n\nUnit tests need to be fixed upstream.","accounts_in_message":[],"_revision_number":1},{"id":"819342c0b9d21b36dd40fe799a0711b9ab24c250","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-04-18 16:09:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2f12b6268f096b8ab0a383025624849576ae0b6d","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-04-18 17:15:17.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/14/653514/2/check/tempest-dsvm-full-xenial/8bc8049/ : SUCCESS in 1h 04m 44s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/14/653514/2/check/tempest-dsvm-full-xenial-py3/7df544f/ : FAILURE in 1h 01m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"febc2836f8eaa0d4f004face81a42bc08248d56e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-18 18:30:22.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/653514/2 : FAILURE in 44m 32s","accounts_in_message":[],"_revision_number":2},{"id":"145d1e1b319edb6a718a709c763e76ec8ae6e919","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-19 06:43:15.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/14/653514/2/check/openstack-tox-pep8/0d21e66/ : SUCCESS in 10m 38s\n- openstack-tox-py27 http://logs.openstack.org/14/653514/2/check/openstack-tox-py27/321acd7/ : SUCCESS in 12m 22s\n- openstack-tox-py35 http://logs.openstack.org/14/653514/2/check/openstack-tox-py35/54de8d9/ : SUCCESS in 13m 46s\n- build-openstack-sphinx-docs http://logs.openstack.org/14/653514/2/check/build-openstack-sphinx-docs/0c98002/html/ : SUCCESS in 6m 23s\n- tempest-full http://logs.openstack.org/14/653514/2/check/tempest-full/627fc3d/ : POST_FAILURE in 1h 34m 30s\n- neutron-grenade http://logs.openstack.org/14/653514/2/check/neutron-grenade/bb78eb2/ : SUCCESS in 1h 04m 58s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/14/653514/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/f432029/ : SUCCESS in 46m 12s (non-voting)\n- nova-live-migration http://logs.openstack.org/14/653514/2/check/nova-live-migration/20b7a5f/ : SUCCESS in 44m 58s\n- tempest-slow finger://ze05.openstack.org/90d447c3557b4bbe8b7d568829db4ebe : RETRY_LIMIT in 44m 19s\n- nova-tox-functional http://logs.openstack.org/14/653514/2/check/nova-tox-functional/6761f44/ : SUCCESS in 24m 30s\n- nova-tox-functional-py35 http://logs.openstack.org/14/653514/2/check/nova-tox-functional-py35/78d2e09/ : SUCCESS in 16m 44s\n- neutron-grenade-multinode http://logs.openstack.org/14/653514/2/check/neutron-grenade-multinode/8fb9ba3/ : SUCCESS in 1h 02m 03s\n- legacy-grenade-dsvm-neutron-multinode-live-migration http://logs.openstack.org/14/653514/2/check/legacy-grenade-dsvm-neutron-multinode-live-migration/a7532e0/ : SUCCESS in 58m 08s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/14/653514/2/check/devstack-plugin-ceph-tempest/1dbbce2/ : POST_FAILURE in 1h 17m 52s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/14/653514/2/check/tempest-multinode-full/5b8e734/ : SUCCESS in 1h 34m 50s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"77233c621f1684aae2da90111017e07cf804e3bc","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-04-19 12:29:37.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/14/653514/2/check/nova-out-of-tree-pvm/4da611b : FAILURE in 1m 23s\n- nova-in-tree-pvm http://184.172.12.213/14/653514/2/check/nova-in-tree-pvm/b2f9786 : FAILURE in 1h 06m 50s","accounts_in_message":[],"_revision_number":2},{"id":"e2db8fe47c5a9cd78e984460036dae3952a21f04","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-19 13:02:24.000000000","message":"Patch Set 2:\n\nrecheck infra","accounts_in_message":[],"_revision_number":2},{"id":"81bfcfeb4ea426dfdcab871742221f212d2a4605","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-19 14:03:51.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/653514/2 : FAILURE in 44m 35s","accounts_in_message":[],"_revision_number":2},{"id":"008743a388a6d5e7dda0b081a140a60115cf6739","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-04-19 14:14:26.000000000","message":"Patch Set 2:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/653514/2/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/c6b67e7 : FAILURE in 19m 48s","accounts_in_message":[],"_revision_number":2},{"id":"1e993985667772585ee544dadb6fbe3ba3269aac","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-22 12:54:44.000000000","message":"Patch Set 2:\n\nrecheck infra","accounts_in_message":[],"_revision_number":2},{"id":"01cc8904ee1017c58cba2f16e675592f25e9eb5b","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-04-22 12:55:30.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/14/653514/2/check/tempest-dsvm-full-xenial/ffce866/ : FAILURE in 9s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/14/653514/2/check/tempest-dsvm-full-xenial-py3/68dbdd9/ : FAILURE in 9s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"77cb72edc0fb9200912e3f58cf5812d0887fffad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-22 14:41:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/14/653514/2/check/openstack-tox-pep8/a8af829/ : SUCCESS in 8m 44s\n- openstack-tox-py27 http://logs.openstack.org/14/653514/2/check/openstack-tox-py27/6923116/ : SUCCESS in 11m 49s\n- openstack-tox-py35 http://logs.openstack.org/14/653514/2/check/openstack-tox-py35/233856a/ : SUCCESS in 12m 47s\n- build-openstack-sphinx-docs http://logs.openstack.org/14/653514/2/check/build-openstack-sphinx-docs/58fd020/html/ : SUCCESS in 6m 16s\n- tempest-full http://logs.openstack.org/14/653514/2/check/tempest-full/bd8cc2e/ : SUCCESS in 1h 42m 55s\n- neutron-grenade http://logs.openstack.org/14/653514/2/check/neutron-grenade/a39efa1/ : SUCCESS in 54m 34s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/14/653514/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/19f3cb5/ : SUCCESS in 45m 31s (non-voting)\n- nova-live-migration http://logs.openstack.org/14/653514/2/check/nova-live-migration/208f9e4/ : SUCCESS in 54m 59s\n- tempest-slow http://logs.openstack.org/14/653514/2/check/tempest-slow/f591c13/ : SUCCESS in 1h 41m 17s\n- nova-tox-functional http://logs.openstack.org/14/653514/2/check/nova-tox-functional/ce0ebbe/ : SUCCESS in 21m 23s\n- nova-tox-functional-py35 http://logs.openstack.org/14/653514/2/check/nova-tox-functional-py35/4d2597a/ : SUCCESS in 20m 48s\n- neutron-grenade-multinode http://logs.openstack.org/14/653514/2/check/neutron-grenade-multinode/fbb1b1f/ : SUCCESS in 1h 14m 35s\n- legacy-grenade-dsvm-neutron-multinode-live-migration http://logs.openstack.org/14/653514/2/check/legacy-grenade-dsvm-neutron-multinode-live-migration/f5ed952/ : SUCCESS in 53m 27s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/14/653514/2/check/devstack-plugin-ceph-tempest/b1e888a/ : SUCCESS in 1h 24m 43s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/14/653514/2/check/tempest-multinode-full/e18ba47/ : SUCCESS in 1h 36m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d3853a377c26e4ba0d56f49d42488ece9f2ed3b3","author":{"_account_id":24230,"name":"NetApp E-Series CI","email":"ng-openstack-eseries-ci@netapp.com","username":"netapp-eseries-ci","tags":["SERVICE_USER"]},"date":"2019-04-22 14:43:17.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- functional-nova-eseries-iSCSI http://13.56.179.158/logs/14/653514/2/upstream-eseries-check/functional-nova-eseries-iSCSI/fb07e6b/ : NOT_REGISTERED\n- functional-nova-eseries-FCP http://13.56.179.158/logs/14/653514/2/upstream-eseries-check/functional-nova-eseries-FCP/eaf2f51/ : NOT_REGISTERED\n\nComment \u0027run-netapp-eseries-ci\u0027 or \u0027netapp-eseries-ci-recheck\u0027 to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_Eseries_CI","accounts_in_message":[],"_revision_number":2},{"id":"69b542e65ef19283103cca36ea7e7601acb63ce9","author":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2019-04-22 14:44:36.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- functional-nova-cDOT-iSCSI http://13.56.179.158/logs/14/653514/2/upstream-check/functional-nova-cDOT-iSCSI/b453c9e/ : FAILURE in 55s\n- functional-nova-cDOT-NFS http://13.56.179.158/logs/14/653514/2/upstream-check/functional-nova-cDOT-NFS/2ad5f68/ : FAILURE in 1m 41s\n- functional-nova-cDOT-FCP http://13.56.179.158/logs/14/653514/2/upstream-check/functional-nova-cDOT-FCP/ba1242d/ : FAILURE in 41s\n\nComment \u0027run-netapp-ci\u0027 or \u0027netapp-ci-recheck\u0027 to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI","accounts_in_message":[],"_revision_number":2},{"id":"a7fe57e106880d1bb65940c5d8e9f18fd2cc164a","author":{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},"date":"2019-04-22 14:46:03.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- functional-nova-solidfire-iSCSI http://13.56.179.158/logs/14/653514/2/upstream-solidfire-check/functional-nova-solidfire-iSCSI/5839420/ : FAILURE in 2m 21s\n\nComment \u0027run-netapp-solidfire-ci\u0027 or \u0027netapp-solidfire-ci-recheck\u0027 or \u0027run solidfire\u0027 to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_SolidFire_CI","accounts_in_message":[],"_revision_number":2},{"id":"799d98335671ddab4d7f0e488d1251ef4b73c348","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-22 15:03:58.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/653514/2 : FAILURE in 49m 26s","accounts_in_message":[],"_revision_number":2},{"id":"8c17c06955fb2c7411e5751a64dcb6f66d3fadf7","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-23 12:16:13.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nLGTM, mostly clean backport from queens and the conflict is noted in the commit message. Just waiting for the queens backport to merge.","accounts_in_message":[],"_revision_number":2},{"id":"0881865d9859eee9baf37e9da89f5c786c080d2e","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-04-24 13:01:36.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"727fe78f21cf538786af3137bbb4c736d12fc675","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 13:02:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"72abd901538f652bc30fb21221165bd2eef349a9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 16:45:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/14/653514/2/gate/openstack-tox-pep8/1b51bbc/ : SUCCESS in 8m 27s\n- openstack-tox-py27 http://logs.openstack.org/14/653514/2/gate/openstack-tox-py27/f5dc6d5/ : SUCCESS in 15m 40s\n- openstack-tox-py35 http://logs.openstack.org/14/653514/2/gate/openstack-tox-py35/2942669/ : SUCCESS in 12m 20s\n- build-openstack-sphinx-docs http://logs.openstack.org/14/653514/2/gate/build-openstack-sphinx-docs/d8f1f39/html/ : SUCCESS in 6m 06s\n- tempest-full http://logs.openstack.org/14/653514/2/gate/tempest-full/7731019/ : SUCCESS in 1h 44m 56s\n- neutron-grenade http://logs.openstack.org/14/653514/2/gate/neutron-grenade/a68b43d/ : SUCCESS in 48m 38s\n- nova-live-migration http://logs.openstack.org/14/653514/2/gate/nova-live-migration/51934d1/ : SUCCESS in 41m 51s\n- tempest-slow http://logs.openstack.org/14/653514/2/gate/tempest-slow/e8ad273/ : SUCCESS in 1h 40m 19s\n- nova-tox-functional http://logs.openstack.org/14/653514/2/gate/nova-tox-functional/4ef8218/ : SUCCESS in 20m 19s\n- nova-tox-functional-py35 http://logs.openstack.org/14/653514/2/gate/nova-tox-functional-py35/4fc01e5/ : SUCCESS in 24m 03s","accounts_in_message":[],"_revision_number":2},{"id":"da9f6680b2264fdc36776b9cdc3654e59c88961c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 16:45:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b50b70a18286b20afa0dbf68bc4833ce5a6235ca","revisions":{"acc3e4d5409ca42ab1c998784ae77e2afe8eecc6":{"kind":"REWORK","_number":1,"created":"2019-04-17 19:05:37.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/14/653514/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/653514/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/653514/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/653514/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/653514/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/653514/1"}}},"commit":{"parents":[{"commit":"919108321180e36c45abf58f5659c07d0f5f69d7","subject":"Merge \"Do not persist RequestSpec.ignore_hosts\" into stable/pike","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/919108321180e36c45abf58f5659c07d0f5f69d7"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2018-10-19 22:06:20.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-04-17 19:02:15.000000000","tz":0},"subject":"libvirt: set device address tag only if setting disk unit","message":"libvirt: set device address tag only if setting disk unit\n\nIn Pike, we began setting disk unit values manually for the\n\u0027virtio-scsi\u0027 controller model in order to allow up to 256 devices [1].\nWe do this by setting the disk unit of the address tag manually for the\nguest config. If we do not set the address tag manually, libvirt would\nautogenerate it for us.\n\nA problem occurs when a user has a SCSI disk that is a volume or isn\u0027t\nusing the \u0027virtio-scsi\u0027 controller model because we\u0027re not guarding our\nmanual setting of the address tag in the guest config by the disk unit,\nin addition to the SCSI bus. This means that for a SCSI volume, we\ngenerate an address tag like \u0027\u003caddress type\u003d\"drive\" controller\u003d\"0\"/\u003e\u0027\nfor any SCSI volume, so a user with more than one device will get the\nfollowing error when they try to boot an instance:\n\n  Failed to start libvirt guest: libvirtError: unsupported\n    configuration: Found duplicate drive address for disk with target name\n    \u0027sda\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027\n\nThis updates the conditionals to only manually set the address tag if\nthe bus is SCSI _and_ the disk unit has been specified. Otherwise, let\nlibvirt autogenerate the address tag and take care of avoiding\ncollisions.\n\n[1] https://bugs.launchpad.net/nova/+bug/1686116\n\nCloses-Bug: #1792077\n\n Conflicts:\n\tnova/tests/unit/virt/libvirt/volume/test_volume.py\n\nNOTE(melwitt): Conflict is due to not having change\nIbfa64f18bbd2fb70db7791330ed1a64fe61c1355 in Pike.\n\nChange-Id: Iefab05e84ccc0bf8f15bdbbf515a290d282dbc5d\n(cherry picked from commit 48fd81648a7cadf2d147a6beabac067c28b288b0)\n(cherry picked from commit 7500c1910cf1cbe16ee48028b67aa919160f44da)\n(cherry picked from commit 72fdbb1b045b01d1ce6907066032ffdf5f3fae73)\n(cherry picked from commit 41c4c7e18562cad4049d3bea50bb4b3147964312)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/acc3e4d5409ca42ab1c998784ae77e2afe8eecc6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/acc3e4d5409ca42ab1c998784ae77e2afe8eecc6"}]},"branch":"refs/heads/stable/pike"},"b50b70a18286b20afa0dbf68bc4833ce5a6235ca":{"kind":"REWORK","_number":2,"created":"2019-04-18 16:09:46.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/14/653514/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/653514/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/653514/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/653514/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/653514/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/653514/2"}}},"commit":{"parents":[{"commit":"919108321180e36c45abf58f5659c07d0f5f69d7","subject":"Merge \"Do not persist RequestSpec.ignore_hosts\" into stable/pike","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/919108321180e36c45abf58f5659c07d0f5f69d7"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2018-10-19 22:06:20.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-04-18 16:07:22.000000000","tz":0},"subject":"libvirt: set device address tag only if setting disk unit","message":"libvirt: set device address tag only if setting disk unit\n\nIn Pike, we began setting disk unit values manually for the\n\u0027virtio-scsi\u0027 controller model in order to allow up to 256 devices [1].\nWe do this by setting the disk unit of the address tag manually for the\nguest config. If we do not set the address tag manually, libvirt would\nautogenerate it for us.\n\nA problem occurs when a user has a SCSI disk that is a volume or isn\u0027t\nusing the \u0027virtio-scsi\u0027 controller model because we\u0027re not guarding our\nmanual setting of the address tag in the guest config by the disk unit,\nin addition to the SCSI bus. This means that for a SCSI volume, we\ngenerate an address tag like \u0027\u003caddress type\u003d\"drive\" controller\u003d\"0\"/\u003e\u0027\nfor any SCSI volume, so a user with more than one device will get the\nfollowing error when they try to boot an instance:\n\n  Failed to start libvirt guest: libvirtError: unsupported\n    configuration: Found duplicate drive address for disk with target name\n    \u0027sda\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027\n\nThis updates the conditionals to only manually set the address tag if\nthe bus is SCSI _and_ the disk unit has been specified. Otherwise, let\nlibvirt autogenerate the address tag and take care of avoiding\ncollisions.\n\n[1] https://bugs.launchpad.net/nova/+bug/1686116\n\nCloses-Bug: #1792077\n\n Conflicts:\n     nova/tests/unit/virt/libvirt/volume/test_volume.py\n\nNOTE(melwitt): Conflict is due to not having change\nIbfa64f18bbd2fb70db7791330ed1a64fe61c1355 in Pike.\n\nChange-Id: Iefab05e84ccc0bf8f15bdbbf515a290d282dbc5d\n(cherry picked from commit 48fd81648a7cadf2d147a6beabac067c28b288b0)\n(cherry picked from commit 7500c1910cf1cbe16ee48028b67aa919160f44da)\n(cherry picked from commit 8703282508954596e1d041340878c636693d8f5f)\n(cherry picked from commit c8ad9f4e1949ce6fdada565cc6660fbac7f75d6c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b50b70a18286b20afa0dbf68bc4833ce5a6235ca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b50b70a18286b20afa0dbf68bc4833ce5a6235ca"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}