)]}'
{"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a66ee51c9c1163d227e5b1cda5621c0ffbb86f80","unresolved":false,"context_lines":[{"line_number":11284,"context_line":"    @mock.patch(\u0027nova.context.RequestContext.elevated\u0027)"},{"line_number":11285,"context_line":"    @mock.patch(\u0027nova.compute.api.API._record_action_start\u0027)"},{"line_number":11286,"context_line":"    @mock.patch.object(compute_utils, \u0027EventReporter\u0027)"},{"line_number":11287,"context_line":"    def test_lock_with_reason(self, mock_event, mock_record, mock_elevate,"},{"line_number":11288,"context_line":"                              mock_notify):"},{"line_number":11289,"context_line":"        mock_elevate.return_value \u003d self.context"},{"line_number":11290,"context_line":"        instance \u003d self._create_fake_instance_obj()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_3761a6aa","line":11287,"updated":"2019-04-25 14:05:43.000000000","message":"Won\u0027t the API samples functional tests in the API change next in the series already cover this? If so, I\u0027d probably just squash the changes and drop the unit tests here since the functional tests will cover this (without the mocks and such). What I\u0027d use unit tests for in this series is negative testing, i.e. trying to specify a locked_reason on the N-1 microversion and making sure it\u0027s a schema error, and trying to specify locked_reason with an invalid format or exceeding the length restriction, etc.","commit_id":"12b7afad2948977be5afe6b7fce9e6e1b1b0f2da"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"6841cc8e47f29a28cdfdab7c8f1bdb3332a7a8e1","unresolved":false,"context_lines":[{"line_number":11284,"context_line":"    @mock.patch(\u0027nova.context.RequestContext.elevated\u0027)"},{"line_number":11285,"context_line":"    @mock.patch(\u0027nova.compute.api.API._record_action_start\u0027)"},{"line_number":11286,"context_line":"    @mock.patch.object(compute_utils, \u0027EventReporter\u0027)"},{"line_number":11287,"context_line":"    def test_lock_with_reason(self, mock_event, mock_record, mock_elevate,"},{"line_number":11288,"context_line":"                              mock_notify):"},{"line_number":11289,"context_line":"        mock_elevate.return_value \u003d self.context"},{"line_number":11290,"context_line":"        instance \u003d self._create_fake_instance_obj()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_1a241bc6","line":11287,"in_reply_to":"ffb9cba7_3761a6aa","updated":"2019-05-03 16:36:13.000000000","message":"talked to Matt, he hates this being a separate patch, :)) I\u0027ll merge this with the one above this.\n\nfyi, I think I have added the negative testing with the new micro version in the api patch but then I will also add the negative tests with the previous micro-version like he has indicated just to check they fail but they can all be done in one patch.","commit_id":"12b7afad2948977be5afe6b7fce9e6e1b1b0f2da"}]}