)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"231938a82160bb995f0f49e02cacb09a72baa25b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware VMDK detach: get adapter type from instance VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Detach VMDK using adapter type from instance instead of shadow VM."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1835733"},{"line_number":12,"context_line":"Change-Id: I8668d57f6b302ad8cdc1e4af28cf6bb8145a738d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_d134d34c","line":9,"updated":"2020-03-18 09:46:21.000000000","message":"This really doesn\u0027t tell me why you are doing that, and what it fixes, etc.\n\n... not going to block on it though.","commit_id":"ec93474a84aff1c184a58fe436ea4a0842bd9825"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ef296595b0eebe0bccde5522cd815495cfdf9a8f","unresolved":false,"context_lines":[{"line_number":721,"context_line":"                vmdk_device \u003d device"},{"line_number":722,"context_line":"        elif device.__class__.__name__ in CONTROLLER_TO_ADAPTER_TYPE:"},{"line_number":723,"context_line":"            adapter_type_dict[device.key] \u003d CONTROLLER_TO_ADAPTER_TYPE["},{"line_number":724,"context_line":"                device.__class__.__name__]"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    if root_disk:"},{"line_number":727,"context_line":"        vmdk_device \u003d root_device"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_3e9e9d63","line":724,"updated":"2019-05-20 10:49:35.000000000","message":"nice cleanup","commit_id":"80bad66cbfbd736f3fcc12b40ac7affc9787fa0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e437fa7f030d389786e080b7d16ce55a8b59f5ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fa7e38b_bb19bf7a","updated":"2019-09-25 09:35:40.000000000","message":"Probably should have done this separately since it looks unrelated\n\nLater: Ah, I see you use it in the next file","commit_id":"4a358adac10c821dec43389939050c7439a84f79"}],"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e437fa7f030d389786e080b7d16ce55a8b59f5ee","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        device \u003d self._get_vmdk_backed_disk_device(vm_ref, data)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        hardware_devices \u003d self._session._call_method(vutil,"},{"line_number":520,"context_line":"                                                \"get_object_property\","},{"line_number":521,"context_line":"                                                vm_ref,"},{"line_number":522,"context_line":"                                                \"config.hardware.device\")"},{"line_number":523,"context_line":"        if hardware_devices.__class__.__name__ \u003d\u003d \"ArrayOfVirtualDevice\":"},{"line_number":524,"context_line":"            hardware_devices \u003d hardware_devices.VirtualDevice"},{"line_number":525,"context_line":"        adapter_type \u003d None"},{"line_number":526,"context_line":"        for hw_device in hardware_devices:"},{"line_number":527,"context_line":"            if hw_device.key \u003d\u003d device.controllerKey:"},{"line_number":528,"context_line":"                adapter_type \u003d vm_util.CONTROLLER_TO_ADAPTER_TYPE.get("},{"line_number":529,"context_line":"                    hw_device.__class__.__name__)"},{"line_number":530,"context_line":"                break"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        # IDE does not support disk hotplug"},{"line_number":533,"context_line":"        if adapter_type \u003d\u003d constants.ADAPTER_TYPE_IDE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_5ba76b0c","line":530,"range":{"start_line":519,"start_character":0,"end_line":530,"end_character":21},"updated":"2019-09-25 09:35:40.000000000","message":"Can we slot this into vm_util and maybe split the common stuff from this and \u0027get_vmdk_info\u0027 into a common function. As it stands, it seems like we\u0027re doing two very similar things in very different places and it\u0027s hard to grok","commit_id":"4a358adac10c821dec43389939050c7439a84f79"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"5ffb791bf2b00f936d33768440e17045b231e88c","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        device \u003d self._get_vmdk_backed_disk_device(vm_ref, data)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        hardware_devices \u003d self._session._call_method(vutil,"},{"line_number":520,"context_line":"                                                \"get_object_property\","},{"line_number":521,"context_line":"                                                vm_ref,"},{"line_number":522,"context_line":"                                                \"config.hardware.device\")"},{"line_number":523,"context_line":"        if hardware_devices.__class__.__name__ \u003d\u003d \"ArrayOfVirtualDevice\":"},{"line_number":524,"context_line":"            hardware_devices \u003d hardware_devices.VirtualDevice"},{"line_number":525,"context_line":"        adapter_type \u003d None"},{"line_number":526,"context_line":"        for hw_device in hardware_devices:"},{"line_number":527,"context_line":"            if hw_device.key \u003d\u003d device.controllerKey:"},{"line_number":528,"context_line":"                adapter_type \u003d vm_util.CONTROLLER_TO_ADAPTER_TYPE.get("},{"line_number":529,"context_line":"                    hw_device.__class__.__name__)"},{"line_number":530,"context_line":"                break"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        # IDE does not support disk hotplug"},{"line_number":533,"context_line":"        if adapter_type \u003d\u003d constants.ADAPTER_TYPE_IDE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ed2f7985","line":530,"range":{"start_line":519,"start_character":0,"end_line":530,"end_character":21},"in_reply_to":"3fa7e38b_5ba76b0c","updated":"2019-09-25 13:29:10.000000000","message":"Updated. There are also other places where the new function get_hardware_devices can replace the duplicated code but they are not related to the current change and that is why I have left them as they are.","commit_id":"4a358adac10c821dec43389939050c7439a84f79"}]}