)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"234d65550b3805067f168ad11d5d34e4a58480f4","unresolved":false,"context_lines":[{"line_number":4727,"context_line":"                # confirm_resize to cleanup the source node allocations held"},{"line_number":4728,"context_line":"                # by the migration record."},{"line_number":4729,"context_line":"                LOG.info(\u0027Deleting allocations for old flavor on source node \u0027"},{"line_number":4730,"context_line":"                         \u0027%s after finish_resize failure. You may be able to \u0027"},{"line_number":4731,"context_line":"                         \u0027recover the instance by hard rebooting it.\u0027,"},{"line_number":4732,"context_line":"                         migration.source_compute, instance\u003dinstance)"},{"line_number":4733,"context_line":"                self._delete_allocation_after_move("},{"line_number":4734,"context_line":"                    context, instance, migration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_d7cf1127","line":4731,"range":{"start_line":4730,"start_character":58,"end_line":4731,"end_character":70},"updated":"2019-06-19 16:27:50.000000000","message":"not sure this helpful comment is in the right place (it should rather be in some user docs) but meh, it\u0027s a nit.","commit_id":"ea297d6ffba81c5dc982afe6519de09ff3744cad"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"234d65550b3805067f168ad11d5d34e4a58480f4","unresolved":false,"context_lines":[{"line_number":3670,"context_line":""},{"line_number":3671,"context_line":"        # Ensure the allocation records still exist on the host."},{"line_number":3672,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(hostname)"},{"line_number":3673,"context_line":"        if failing_method \u003d\u003d \u0027_finish_resize\u0027:"},{"line_number":3674,"context_line":"            # finish_resize will drop the old flavor allocations."},{"line_number":3675,"context_line":"            self.assertFlavorMatchesUsage(source_rp_uuid, self.flavor2)"},{"line_number":3676,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_3799cd1e","line":3673,"updated":"2019-06-19 16:27:50.000000000","message":"honestly, I\u0027d have preferred a consistent approach where we would rollback the full migration back to the source node, but this is obviously not a trivial task as we don\u0027t exactly know what to rollback and in which state, so below definitely looks the best reasonable approach to me.","commit_id":"ea297d6ffba81c5dc982afe6519de09ff3744cad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"10c3e2487489f9cdd782203138c68befed78973b","unresolved":false,"context_lines":[{"line_number":3670,"context_line":""},{"line_number":3671,"context_line":"        # Ensure the allocation records still exist on the host."},{"line_number":3672,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(hostname)"},{"line_number":3673,"context_line":"        if failing_method \u003d\u003d \u0027_finish_resize\u0027:"},{"line_number":3674,"context_line":"            # finish_resize will drop the old flavor allocations."},{"line_number":3675,"context_line":"            self.assertFlavorMatchesUsage(source_rp_uuid, self.flavor2)"},{"line_number":3676,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_b51610a7","line":3673,"in_reply_to":"9fb8cfa7_3799cd1e","updated":"2019-06-19 21:52:01.000000000","message":"Rollbacks are near impossible to get right and it would be a big re-architecture (probably using a task state machine) to get it right, so yeah...","commit_id":"ea297d6ffba81c5dc982afe6519de09ff3744cad"}]}