)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"270722b42c3a7dfc70948e86b3ebcf36364b467b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If for some reason we don\u0027t have a valid endpoint to provide the"},{"line_number":10,"context_line":"Ironic client, we should at the very least provide the information"},{"line_number":11,"context_line":"it needs to make an informed decision."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I31fa1c6fb0b224fbb02f9ebf68abc6a3728e9389"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_9db54534","line":12,"updated":"2019-04-23 14:49:26.000000000","message":"This should be backported, so let\u0027s get a bug associated please.","commit_id":"b4ad9679b7fc7ec7a746bd6655b69e28334dd48e"}],"nova/virt/ironic/client_wrapper.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"270722b42c3a7dfc70948e86b3ebcf36364b467b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            if ironic_url is None:"},{"line_number":132,"context_line":"                LOG.warning(\"Could not discover ironic_url via keystoneauth1: \""},{"line_number":133,"context_line":"                            \"Adapter.get_endpoint %s\", ironic_url_none_reason)"},{"line_number":134,"context_line":"                # NOTE(eandersson): We pass in region here to make sure"},{"line_number":135,"context_line":"                # that the Ironic client can make an educated decision when"},{"line_number":136,"context_line":"                # we don\u0027t have a valid endpoint to pass on."},{"line_number":137,"context_line":"                kwargs[\u0027region_name\u0027] \u003d ironic_conf.region_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_3db8d9c6","line":134,"updated":"2019-04-23 14:49:26.000000000","message":"This is good as is, but I want to note for posterity some of the background/details.\n\nThis is tightly coupled to the ironicclient implementation, specifically [1]. The **kwargs to the get_client method is documented only as \"all the other params that are passed to keystoneauth\" [2]. This is vague and not completely true at least in terms of Adapter kwargs. It\u0027s also not a prescriptive/proscriptive interface, so ironicclient can change up the internals as it sees fit - as we saw very recently right next door with the addition of interface handling [3].\n\nBasically, it sucks how the ksa pieces of this puzzle are put together. It\u0027s brittle and will keep breaking in ways similar to this one, and we should fix it.\n\n[1] https://github.com/openstack/python-ironicclient/blob/060029ffcae8bbbd2315947cd059b701b5c31c39/ironicclient/client.py#L121\n[2] https://github.com/openstack/python-ironicclient/blob/060029ffcae8bbbd2315947cd059b701b5c31c39/ironicclient/client.py#L66\n[3] https://github.com/openstack/python-ironicclient/commit/d6eea403cbf0d11b06acbecc704f422a7e278462","commit_id":"b4ad9679b7fc7ec7a746bd6655b69e28334dd48e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f48b4acea4c3acedb83b76dda5c284768d9231a4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                # NOTE(eandersson): We pass in region here to make sure"},{"line_number":135,"context_line":"                # that the Ironic client can make an educated decision when"},{"line_number":136,"context_line":"                # we don\u0027t have a valid endpoint to pass on."},{"line_number":137,"context_line":"                kwargs[\u0027region_name\u0027] \u003d ironic_conf.region_name"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            cli \u003d ironic.client.get_client(IRONIC_API_VERSION[0],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_1b14fa9f","line":137,"range":{"start_line":137,"start_character":24,"end_line":137,"end_character":35},"updated":"2019-04-23 19:36:26.000000000","message":"Looks like this was handled since Ifc7b45d047c8882a41021e1604b74d17eac2e6e8 and that goes back to rocky so we should be good to backport at least that far, but it looks like before that there is an os_region_name kwarg (for queens) otherwise region_name would just be ignored. Reminder to myself for backports.","commit_id":"6eaa6db0ee01ee5a7b56bc3176914d85e697b96a"}]}