)]}'
{"nova/virt/hyperv/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19f810fb21aad4069c1064c42ac9595a60fe8173","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"@decorate_all_methods(convert_exceptions, exception_conversion_map)"},{"line_number":94,"context_line":"class HyperVDriver(driver.ComputeDriver):"},{"line_number":95,"context_line":"    capabilities \u003d {"},{"line_number":96,"context_line":"        \"has_imagecache\": True,"},{"line_number":97,"context_line":"        \"supports_evacuate\": False,"},{"line_number":98,"context_line":"        \"supports_migrate_to_same_host\": False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_a31794ed","line":95,"updated":"2019-04-25 16:41:58.000000000","message":"Since this is overwriting the dict from the parent class it\u0027s omitting a bunch of other unsupported image types:\n\nhttps://review.opendev.org/#/c/652710/3/nova/virt/driver.py@162\n\nI\u0027m not sure how that is going to be used to report the traits - does it happen generically somewhere and if so, is it OK if those keys are missing from the capabilities dict? Mostly a question for Dan.\n\nLooks like it should handle it though:\n\nhttps://review.opendev.org/#/c/652710/3/nova/virt/driver.py@1064","commit_id":"a68b0d446ffc066813f198a93503b835f3640521"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"678b3799c5eb188bfd2edebf6fdfd04f0e7dd513","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"@decorate_all_methods(convert_exceptions, exception_conversion_map)"},{"line_number":94,"context_line":"class HyperVDriver(driver.ComputeDriver):"},{"line_number":95,"context_line":"    capabilities \u003d {"},{"line_number":96,"context_line":"        \"has_imagecache\": True,"},{"line_number":97,"context_line":"        \"supports_evacuate\": False,"},{"line_number":98,"context_line":"        \"supports_migrate_to_same_host\": False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_e3902c51","line":95,"in_reply_to":"ffb9cba7_a31794ed","updated":"2019-04-25 16:44:35.000000000","message":"Yeah it seems fine to only mention the supported ones here. For the other drivers, I put them all there so that the people I\u0027m poking to validate the list would see some things as unsupported and jog their memory about what the full list is, assuming they won\u0027t be looking at the whole series.","commit_id":"a68b0d446ffc066813f198a93503b835f3640521"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96e3663fef925137d583d42b8a5a228a308159fa","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"@decorate_all_methods(convert_exceptions, exception_conversion_map)"},{"line_number":94,"context_line":"class HyperVDriver(driver.ComputeDriver):"},{"line_number":95,"context_line":"    capabilities \u003d {"},{"line_number":96,"context_line":"        \"has_imagecache\": True,"},{"line_number":97,"context_line":"        \"supports_evacuate\": False,"},{"line_number":98,"context_line":"        \"supports_migrate_to_same_host\": False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_a373144d","line":95,"in_reply_to":"ffb9cba7_e3902c51","updated":"2019-04-25 16:45:21.000000000","message":"\u003e Yeah it seems fine to only mention the supported ones here. For the\n \u003e other drivers, I put them all there so that the people I\u0027m poking\n \u003e to validate the list would see some things as unsupported and jog\n \u003e their memory about what the full list is, assuming they won\u0027t be\n \u003e looking at the whole series.\n\nOK good to know because I was just going to ask about that in the ironic one.","commit_id":"a68b0d446ffc066813f198a93503b835f3640521"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19f810fb21aad4069c1064c42ac9595a60fe8173","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"supports_trusted_certs\": False,"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # Supported image types"},{"line_number":105,"context_line":"        \"supports_image_type_vhd\": True,"},{"line_number":106,"context_line":"        \"supports_image_type_vhdx\": True,"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def __init__(self, virtapi):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_232c0446","line":106,"range":{"start_line":105,"start_character":8,"end_line":106,"end_character":41},"updated":"2019-04-25 16:41:58.000000000","message":"This looks right based on the DISK_FORMAT constants in the constants module. Plus I\u0027ll trust the hyperv driver guy to know. :)","commit_id":"a68b0d446ffc066813f198a93503b835f3640521"}]}