)]}'
{"nova/privsep/linux_net.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"53eabb1320bcf3d251e432d8ee46790fc7da00dc","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            processutils.execute(\u0027tunctl\u0027, \u0027-b\u0027, \u0027-t\u0027, dev)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if mac_address:"},{"line_number":206,"context_line":"            set_device_macaddr(dev, mac_address)"},{"line_number":207,"context_line":"        set_device_enabled(dev)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_2fb19290","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":31},"updated":"2019-05-04 15:41:08.000000000","message":"Is privsep set up to dtrt when nested/doubled?\n\nAt least from the point of view of starting, yes [1]. Pawing through the code, it looks like it\u0027ll result in separate subthreads each time you invoke a wrapped method. That seems non-ideal and a decent enough reason to leave the unwrapped versions of these methods, since that\u0027s really cheap.\n\n[1] https://opendev.org/openstack/oslo.privsep/src/branch/master/oslo_privsep/priv_context.py#L240-L241","commit_id":"c86d20a0e44b6117c56ef10434556a2413acd0b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c11c171195b2a9552f6b76560cc8a4fa9ad7f3d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            processutils.execute(\u0027tunctl\u0027, \u0027-b\u0027, \u0027-t\u0027, dev)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if mac_address:"},{"line_number":206,"context_line":"            set_device_macaddr(dev, mac_address)"},{"line_number":207,"context_line":"        set_device_enabled(dev)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_48fc7771","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":31},"in_reply_to":"dfbec78f_2fb19290","updated":"2019-06-26 14:41:49.000000000","message":"Done","commit_id":"c86d20a0e44b6117c56ef10434556a2413acd0b1"}]}