)]}'
{"etc/nova/nova.conf.sample":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8c77bf50895da80a59c7c23331b5d017e750a933","unresolved":false,"context_lines":[{"line_number":2737,"context_line":"# defined) this string is used for key derivation. (string"},{"line_number":2738,"context_line":"# value)"},{"line_number":2739,"context_line":"#memcache_secret_key\u003d\u003cNone\u003e"},{"line_number":2740,"context_line":""},{"line_number":2741,"context_line":"# (optional) indicate whether to set the X-Service-Catalog"},{"line_number":2742,"context_line":"# header. If False, middleware will not ask for service"},{"line_number":2743,"context_line":"# catalog on token validation and will not set the X-Service-"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAUH%2F%2BiQs%3D","side":"PARENT","line":2740,"updated":"2014-01-24 16:46:00.000000000","message":"this does not look related to this patch set","commit_id":"f579affb5058cdfef9ce606d62cf64345b87cf55"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"31ac0adb5d39eac2d99fdfc7fa914f99fe298ba3","unresolved":false,"context_lines":[{"line_number":2737,"context_line":"# defined) this string is used for key derivation. (string"},{"line_number":2738,"context_line":"# value)"},{"line_number":2739,"context_line":"#memcache_secret_key\u003d\u003cNone\u003e"},{"line_number":2740,"context_line":""},{"line_number":2741,"context_line":"# (optional) indicate whether to set the X-Service-Catalog"},{"line_number":2742,"context_line":"# header. If False, middleware will not ask for service"},{"line_number":2743,"context_line":"# catalog on token validation and will not set the X-Service-"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAUH%2F%2BX%2BQ%3D","side":"PARENT","line":2740,"in_reply_to":"AAAAUH%2F%2Bh6A%3D","updated":"2014-01-27 15:59:19.000000000","message":"I updated my venv and the file built correctly.","commit_id":"f579affb5058cdfef9ce606d62cf64345b87cf55"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"8e87f7ceb6f84540a7e66817a23bf1d35f220658","unresolved":false,"context_lines":[{"line_number":2737,"context_line":"# defined) this string is used for key derivation. (string"},{"line_number":2738,"context_line":"# value)"},{"line_number":2739,"context_line":"#memcache_secret_key\u003d\u003cNone\u003e"},{"line_number":2740,"context_line":""},{"line_number":2741,"context_line":"# (optional) indicate whether to set the X-Service-Catalog"},{"line_number":2742,"context_line":"# header. If False, middleware will not ask for service"},{"line_number":2743,"context_line":"# catalog on token validation and will not set the X-Service-"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAUH%2F%2Bh6A%3D","side":"PARENT","line":2740,"in_reply_to":"AAAAUH%2F%2BiQs%3D","updated":"2014-01-24 18:01:47.000000000","message":"So agreed, I didn\u0027t touch this.\n\nBut I look at master and this is in the nova.conf.sample but there is no such option defined anywhere?  Huh?","commit_id":"f579affb5058cdfef9ce606d62cf64345b87cf55"}],"nova/cmd/all.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ce10137c1b6f849b631a41fc56c14bdbf380bf62","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            server \u003d service.Service.create(binary\u003dbinary, topic\u003dtopic,"},{"line_number":89,"context_line":"                                            manager\u003dmanager)"},{"line_number":90,"context_line":"            workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.topic, None)"},{"line_number":91,"context_line":"            if not workers:"},{"line_number":92,"context_line":"                workers \u003d 1"},{"line_number":93,"context_line":"            launcher.launch_service(server, workers\u003dworkers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FrnY%3D","line":90,"updated":"2014-01-09 17:15:44.000000000","message":"Why did you not use \"workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.topic, 1)\"?","commit_id":"f7504e54feade0a361163300d66b2111887f5e2c"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"8b824958780f66722e3cd1dd9fdf1d15eaf4b94d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            server \u003d service.Service.create(binary\u003dbinary, topic\u003dtopic,"},{"line_number":89,"context_line":"                                            manager\u003dmanager)"},{"line_number":90,"context_line":"            workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.topic, None)"},{"line_number":91,"context_line":"            if not workers:"},{"line_number":92,"context_line":"                workers \u003d 1"},{"line_number":93,"context_line":"            launcher.launch_service(server, workers\u003dworkers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FrLY%3D","line":90,"in_reply_to":"AAAAUH%2F%2FrnY%3D","updated":"2014-01-09 18:49:06.000000000","message":"Done","commit_id":"f7504e54feade0a361163300d66b2111887f5e2c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b2e82cb7d29a1424e7dad95133f63f61260dd961","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            server \u003d service.Service.create(binary\u003dbinary, topic\u003dtopic,"},{"line_number":89,"context_line":"                                            manager\u003dmanager)"},{"line_number":90,"context_line":"            workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.topic, 1)"},{"line_number":91,"context_line":"            launcher.launch_service(server, workers\u003dworkers)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        except (Exception, SystemExit):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B3Tk%3D","line":90,"updated":"2014-01-21 10:16:10.000000000","message":"I wonder if we need to be more explicit, have a default setting, then have explicit ones for those we know about?\n\nIf we add a new service, the undefined config error will feel a bit odd.\n\nAlthough, you might want a unit test for that logic.","commit_id":"f4225d0ff635ff266221233f45e3a768690ed1ac"},{"author":{"_account_id":9084,"name":"Shantanu Tushar","email":"shaan7in@gmail.com","username":"shaan7"},"change_message_id":"63240d9624eec6ce83de96317e9166425cebc01a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            server \u003d service.Service.create(binary\u003dbinary, topic\u003dtopic,"},{"line_number":89,"context_line":"                                            manager\u003dmanager)"},{"line_number":90,"context_line":"            workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.topic, 1)"},{"line_number":91,"context_line":"            launcher.launch_service(server, workers\u003dworkers)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        except (Exception, SystemExit):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B3Ow%3D","line":90,"in_reply_to":"AAAAUH%2F%2B3Tk%3D","updated":"2014-01-21 10:27:12.000000000","message":"Around defaults for these configuration, the right place for these defaults are the Opts. I have a related patch here https://review.openstack.org/#/c/67266 .","commit_id":"f4225d0ff635ff266221233f45e3a768690ed1ac"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eaff0c4af83e4d76979adb3a69d9bc9b28209e17","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            server \u003d service.Service.create(binary\u003dbinary, topic\u003dtopic,"},{"line_number":87,"context_line":"                                            manager\u003dmanager)"},{"line_number":88,"context_line":"            workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.topic, 1)"},{"line_number":89,"context_line":"            launcher.launch_service(server, workers\u003dworkers)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        except (Exception, SystemExit):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FAxE%3D","line":88,"updated":"2014-02-17 16:50:54.000000000","message":"what about cmd/compute.py and similar ones? And does this duplicate what is already in service?","commit_id":"b91b99738c46fdb90a88f14199a934edbfdcb0c8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"449c739b79bd6ca1bbeacd8606f2ab0cac9221ea","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            server \u003d service.Service.create(binary\u003dbinary, topic\u003dtopic,"},{"line_number":87,"context_line":"                                            manager\u003dmanager)"},{"line_number":88,"context_line":"            workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.topic, 1)"},{"line_number":89,"context_line":"            launcher.launch_service(server, workers\u003dworkers)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        except (Exception, SystemExit):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2BtnY%3D","line":88,"in_reply_to":"AAAAUX%2F%2FAxE%3D","updated":"2014-02-19 16:26:56.000000000","message":"The code path is different as far as how services are constructed in cmd/compute.py (and similar) versus here.","commit_id":"b91b99738c46fdb90a88f14199a934edbfdcb0c8"}],"nova/service.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ce10137c1b6f849b631a41fc56c14bdbf380bf62","unresolved":false,"context_lines":[{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the network service\u0027),"},{"line_number":114,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the scheduler service\u0027),"},{"line_number":116,"context_line":"    ]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"cli_opts \u003d ["},{"line_number":119,"context_line":"        cfg.StrOpt(\u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Frmk%3D","line":116,"updated":"2014-01-09 17:15:44.000000000","message":"You have added 5 new options but I see only one used?","commit_id":"f7504e54feade0a361163300d66b2111887f5e2c"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"8b824958780f66722e3cd1dd9fdf1d15eaf4b94d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the network service\u0027),"},{"line_number":114,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the scheduler service\u0027),"},{"line_number":116,"context_line":"    ]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"cli_opts \u003d ["},{"line_number":119,"context_line":"        cfg.StrOpt(\u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FrLQ%3D","line":116,"in_reply_to":"AAAAUH%2F%2Frmk%3D","updated":"2014-01-09 18:49:06.000000000","message":"It depends which service is being started.","commit_id":"f7504e54feade0a361163300d66b2111887f5e2c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b2e82cb7d29a1424e7dad95133f63f61260dd961","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.IntOpt(\u0027network_workers\u0027,"},{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the network service\u0027),"},{"line_number":114,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the scheduler service\u0027),"},{"line_number":116,"context_line":"    ]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2B3TY%3D","line":115,"updated":"2014-01-21 10:16:10.000000000","message":"Are we missing one for cert?","commit_id":"f4225d0ff635ff266221233f45e3a768690ed1ac"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"6733e01e13f18b258a70cc9b6ca1dc2ad73aad39","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.IntOpt(\u0027network_workers\u0027,"},{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the network service\u0027),"},{"line_number":114,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the scheduler service\u0027),"},{"line_number":116,"context_line":"    ]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bz%2Bk%3D","line":115,"in_reply_to":"AAAAUH%2F%2B3TY%3D","updated":"2014-01-21 20:50:53.000000000","message":"Done","commit_id":"f4225d0ff635ff266221233f45e3a768690ed1ac"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"fe92432fac57baa852bd76234d367a131cb69fb5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    cfg.IntOpt(\u0027service_down_time\u0027,"},{"line_number":104,"context_line":"               default\u003d60,"},{"line_number":105,"context_line":"               help\u003d\u0027maximum time since last check-in for up service\u0027),"},{"line_number":106,"context_line":"    cfg.IntOpt(\u0027cells_workers\u0027,"},{"line_number":107,"context_line":"               help\u003d\u0027Number of workers for the cells service\u0027),"},{"line_number":108,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027Number of workers for the compute service\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bu20%3D","line":106,"updated":"2014-01-22 17:55:12.000000000","message":"I think a default setting of 1 makes sense.  To me it makes the config sample file a bit more intuitive, it\u0027s a bit odd that a setting of None starts up 1 worker.","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"4a2699f564da892d7220a171dfc97e7a38cb9f80","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    cfg.IntOpt(\u0027service_down_time\u0027,"},{"line_number":104,"context_line":"               default\u003d60,"},{"line_number":105,"context_line":"               help\u003d\u0027maximum time since last check-in for up service\u0027),"},{"line_number":106,"context_line":"    cfg.IntOpt(\u0027cells_workers\u0027,"},{"line_number":107,"context_line":"               help\u003d\u0027Number of workers for the cells service\u0027),"},{"line_number":108,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027Number of workers for the compute service\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BpKM%3D","line":106,"in_reply_to":"AAAAUH%2F%2Bu20%3D","updated":"2014-01-23 16:09:47.000000000","message":"Done","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"044331fdbc71d84909528a6ee05d64e14ebb7049","unresolved":false,"context_lines":[{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the network service\u0027),"},{"line_number":114,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the scheduler service\u0027),"},{"line_number":116,"context_line":"    ]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"cli_opts \u003d ["},{"line_number":119,"context_line":"        cfg.StrOpt(\u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp94%3D","line":116,"updated":"2014-01-23 13:58:34.000000000","message":"I still can\u0027t see a setting for cert, bit I think I like how we just default to 1, or whatever, instead.","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"fe92432fac57baa852bd76234d367a131cb69fb5","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        raise RuntimeError(_(\u0027serve() can only be called once\u0027))"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    if not workers:"},{"line_number":442,"context_line":"        workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.name, None)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    if workers \u003d\u003d 1:"},{"line_number":445,"context_line":"        # use simpler ServiceLauncher"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bu3I%3D","line":442,"updated":"2014-01-22 17:55:12.000000000","message":"1 seems like a useful default here.  If we get None here then we fall through to the else below.","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"044331fdbc71d84909528a6ee05d64e14ebb7049","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        raise RuntimeError(_(\u0027serve() can only be called once\u0027))"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    if not workers:"},{"line_number":442,"context_line":"        workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.name, None)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    if workers \u003d\u003d 1:"},{"line_number":445,"context_line":"        # use simpler ServiceLauncher"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp9w%3D","line":442,"in_reply_to":"AAAAUH%2F%2Bu3I%3D","updated":"2014-01-23 13:58:34.000000000","message":"+1","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"4a2699f564da892d7220a171dfc97e7a38cb9f80","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        raise RuntimeError(_(\u0027serve() can only be called once\u0027))"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    if not workers:"},{"line_number":442,"context_line":"        workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.name, None)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    if workers \u003d\u003d 1:"},{"line_number":445,"context_line":"        # use simpler ServiceLauncher"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BpJ4%3D","line":442,"in_reply_to":"AAAAUH%2F%2Bu3I%3D","updated":"2014-01-23 16:09:47.000000000","message":"Done","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"fe92432fac57baa852bd76234d367a131cb69fb5","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    if not workers:"},{"line_number":442,"context_line":"        workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.name, None)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    if workers \u003d\u003d 1:"},{"line_number":445,"context_line":"        # use simpler ServiceLauncher"},{"line_number":446,"context_line":"        _launcher \u003d service.launch(server)"},{"line_number":447,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bu3U%3D","line":444,"updated":"2014-01-22 17:55:12.000000000","message":"This seems to be a workaround for the poor \u0027if\u0027 check in service.launch().  I would like to see a patch raised to fix the issue in oslo.","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"044331fdbc71d84909528a6ee05d64e14ebb7049","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    if not workers:"},{"line_number":442,"context_line":"        workers \u003d getattr(CONF, \u0027%s_workers\u0027 % server.name, None)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    if workers \u003d\u003d 1:"},{"line_number":445,"context_line":"        # use simpler ServiceLauncher"},{"line_number":446,"context_line":"        _launcher \u003d service.launch(server)"},{"line_number":447,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp%2BM%3D","line":444,"in_reply_to":"AAAAUH%2F%2Bu3U%3D","updated":"2014-01-23 13:58:34.000000000","message":"Agreed, but I don\u0027t mind something to make this work while oslo merges a fix.","commit_id":"f7ad14aa24d7af4066554ce7154a8621b8f15e79"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"60e90b9751aadc2d919ec83b179de85a5e60d9b3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    cfg.IntOpt(\u0027service_down_time\u0027,"},{"line_number":104,"context_line":"               default\u003d60,"},{"line_number":105,"context_line":"               help\u003d\u0027Maximum time since last check-in for up service\u0027),"},{"line_number":106,"context_line":"    cfg.IntOpt(\u0027cells_workers\u0027, default\u003d1,"},{"line_number":107,"context_line":"               help\u003d\u0027Number of workers for the cells service\u0027),"},{"line_number":108,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027, default\u003d1,"},{"line_number":109,"context_line":"               help\u003d\u0027Number of workers for the compute service\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BPGE%3D","line":106,"updated":"2014-01-28 20:03:37.000000000","message":"I would personally prefer # of CPUs as the default if not specified in the config file.  I think that\u0027s the most sensible default.","commit_id":"3da7419eaf6259d2f12453e8f23e4b31f874cd5e"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"87a44fe6254a1319a1a6796c257ea631cafdfeda","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    cfg.IntOpt(\u0027service_down_time\u0027,"},{"line_number":104,"context_line":"               default\u003d60,"},{"line_number":105,"context_line":"               help\u003d\u0027Maximum time since last check-in for up service\u0027),"},{"line_number":106,"context_line":"    cfg.IntOpt(\u0027cells_workers\u0027, default\u003d1,"},{"line_number":107,"context_line":"               help\u003d\u0027Number of workers for the cells service\u0027),"},{"line_number":108,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027, default\u003d1,"},{"line_number":109,"context_line":"               help\u003d\u0027Number of workers for the compute service\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9zcQ%3D","line":106,"in_reply_to":"AAAAUH%2F%2BPGE%3D","updated":"2014-02-03 19:36:38.000000000","message":"Done","commit_id":"3da7419eaf6259d2f12453e8f23e4b31f874cd5e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"60e90b9751aadc2d919ec83b179de85a5e60d9b3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"               help\u003d\u0027Number of workers for the cells service\u0027),"},{"line_number":108,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027, default\u003d1,"},{"line_number":109,"context_line":"               help\u003d\u0027Number of workers for the compute service\u0027),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027conductor_workers\u0027, default\u003d1,"},{"line_number":111,"context_line":"               help\u003d\u0027Number of workers for the conductor service\u0027),"},{"line_number":112,"context_line":"    cfg.IntOpt(\u0027network_workers\u0027, default\u003d1,"},{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the network service\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BPGM%3D","line":110,"updated":"2014-01-28 20:03:37.000000000","message":"A workers option already exists for conductor in the [conductor] option group","commit_id":"3da7419eaf6259d2f12453e8f23e4b31f874cd5e"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"87a44fe6254a1319a1a6796c257ea631cafdfeda","unresolved":false,"context_lines":[{"line_number":107,"context_line":"               help\u003d\u0027Number of workers for the cells service\u0027),"},{"line_number":108,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027, default\u003d1,"},{"line_number":109,"context_line":"               help\u003d\u0027Number of workers for the compute service\u0027),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027conductor_workers\u0027, default\u003d1,"},{"line_number":111,"context_line":"               help\u003d\u0027Number of workers for the conductor service\u0027),"},{"line_number":112,"context_line":"    cfg.IntOpt(\u0027network_workers\u0027, default\u003d1,"},{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the network service\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F9zcM%3D","line":110,"in_reply_to":"AAAAUH%2F%2BPGM%3D","updated":"2014-02-03 19:36:38.000000000","message":"Done","commit_id":"3da7419eaf6259d2f12453e8f23e4b31f874cd5e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"60e90b9751aadc2d919ec83b179de85a5e60d9b3","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027, default\u003d1,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the scheduler service\u0027),"},{"line_number":116,"context_line":"    cfg.IntOpt(\u0027cert_workers\u0027, default\u003d1,"},{"line_number":117,"context_line":"               help\u003d\u0027Number of workers for the cert service\u0027),"},{"line_number":118,"context_line":"    ]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BPGY%3D","line":117,"updated":"2014-01-28 20:03:37.000000000","message":"I wonder if it\u0027s worth starting configuration groups for each service:\n\n    [compute]\n    workers\u003d\n\netc.\n\nTher\u0027s already a cells group.","commit_id":"3da7419eaf6259d2f12453e8f23e4b31f874cd5e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eaff0c4af83e4d76979adb3a69d9bc9b28209e17","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027, default\u003d1,"},{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the compute service.\u0027),"},{"line_number":114,"context_line":"    cfg.IntOpt(\u0027conductor_workers\u0027, default\u003d1,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the conductor service.\u0027),"},{"line_number":116,"context_line":"    cfg.IntOpt(\u0027network_workers\u0027, default\u003d1,"},{"line_number":117,"context_line":"               help\u003d\u0027Number of workers for the network service.\u0027),"},{"line_number":118,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027, default\u003d1,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FAxY%3D","line":115,"updated":"2014-02-17 16:50:54.000000000","message":"There is already a setting for this that is read in cmd/conductor.py.\n\nMaybe they should all be their own service section, and you can move the conductor one here? I am not certain though.","commit_id":"b91b99738c46fdb90a88f14199a934edbfdcb0c8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"449c739b79bd6ca1bbeacd8606f2ab0cac9221ea","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.IntOpt(\u0027compute_workers\u0027, default\u003d1,"},{"line_number":113,"context_line":"               help\u003d\u0027Number of workers for the compute service.\u0027),"},{"line_number":114,"context_line":"    cfg.IntOpt(\u0027conductor_workers\u0027, default\u003d1,"},{"line_number":115,"context_line":"               help\u003d\u0027Number of workers for the conductor service.\u0027),"},{"line_number":116,"context_line":"    cfg.IntOpt(\u0027network_workers\u0027, default\u003d1,"},{"line_number":117,"context_line":"               help\u003d\u0027Number of workers for the network service.\u0027),"},{"line_number":118,"context_line":"    cfg.IntOpt(\u0027scheduler_workers\u0027, default\u003d1,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2BuYs%3D","line":115,"in_reply_to":"AAAAUX%2F%2FAxY%3D","updated":"2014-02-19 16:26:56.000000000","message":"Good catch.  Some option group is probably worth doing here.\n\nOne thing I noticed - the workers option defined in nova.conductor.api is not even used in the nova/cmd/all script.  It only gets touched if conductor is started by itself.","commit_id":"b91b99738c46fdb90a88f14199a934edbfdcb0c8"}]}