)]}'
{"id":"openstack%2Fnova~655429","triplet_id":"openstack%2Fnova~stable%2Fstein~I34a3f8d4a496217eb01790e2d124111625bf5f85","project":"openstack/nova","branch":"stable/stein","topic":"bug/1825583","hashtags":[],"change_id":"I34a3f8d4a496217eb01790e2d124111625bf5f85","subject":"Fix {min|max}_version in ironic Adapter setup","status":"MERGED","created":"2019-04-24 13:31:25.000000000","updated":"2019-04-25 09:53:57.000000000","submitted":"2019-04-25 03:08:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"655429-1556161719552-6db76d6a","meta_rev_id":"14c459bd490035dc1889c596674a303e4c606b3c","_number":655429,"virtual_id_number":655429,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-04-24 15:47:25.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-04-24 13:33:07.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-04-25 03:08:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2019-04-24 22:28:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-24 14:15:18.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-24 20:02:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2019-04-24 22:28:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-24 13:33:07.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-24 14:15:18.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-04-24 15:47:25.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-04-24 20:02:50.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-04-24 22:28:19.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-04-25 03:08:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e16f10cb312d8d20f8f1972b23e6a64c3e98eaf6","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-04-24 13:31:25.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"00cb562d3a7009db518fcc630eed12cd521af6de","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-04-24 13:33:07.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/29/655429/1/check/tempest-dsvm-full-xenial/3cc5624/ : FAILURE in 10s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/29/655429/1/check/tempest-dsvm-full-xenial-py3/5f82ea1/ : FAILURE in 9s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/29/655429/1/check/grenade-dsvm-xenial/f808271/ : FAILURE in 10s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"392c5bbf6ed37e8bb2a68401c87391dbd9209b01","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-24 14:14:04.000000000","message":"Topic changed from bug/1825583-stable/stein to bug/1825583","accounts_in_message":[],"_revision_number":1},{"id":"54d61b517fbf54165804c4d6f498c07c1cc3354d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-24 14:15:18.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry pick from train and the change is merged there so this lgtm.","accounts_in_message":[],"_revision_number":1},{"id":"189a38e33dc9b537dd33ab306d52bcc9a1f4ae65","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-24 15:47:25.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/655429/1 : SUCCESS in 2h 15m 10s","accounts_in_message":[],"_revision_number":1},{"id":"64d62137da1c8795dc51c847c9a651f1dccbb9ee","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 19:38:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/29/655429/1/check/grenade-py3/e81355c/ : SUCCESS in 1h 10m 50s\n- tempest-full-py3 http://logs.openstack.org/29/655429/1/check/tempest-full-py3/e5bec61/ : SUCCESS in 1h 21m 34s\n- openstack-tox-cover http://logs.openstack.org/29/655429/1/check/openstack-tox-cover/b292efc/cover/ : SUCCESS in 14m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/29/655429/1/check/openstack-tox-lower-constraints/75ac1ba/ : SUCCESS in 10m 47s\n- openstack-tox-pep8 http://logs.openstack.org/29/655429/1/check/openstack-tox-pep8/488a822/ : SUCCESS in 9m 44s\n- openstack-tox-py27 http://logs.openstack.org/29/655429/1/check/openstack-tox-py27/eaffe0c/ : SUCCESS in 11m 43s\n- openstack-tox-py35 http://logs.openstack.org/29/655429/1/check/openstack-tox-py35/6b854b8/ : SUCCESS in 14m 13s\n- openstack-tox-py36 http://logs.openstack.org/29/655429/1/check/openstack-tox-py36/aeb7188/ : SUCCESS in 13m 54s\n- openstack-tox-py37 http://logs.openstack.org/29/655429/1/check/openstack-tox-py37/4d4aa29/ : SUCCESS in 13m 08s\n- openstack-tox-docs http://logs.openstack.org/29/655429/1/check/openstack-tox-docs/e6b9611/html/ : SUCCESS in 6m 06s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/29/655429/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/21bba85/ : FAILURE in 18m 55s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/29/655429/1/check/devstack-plugin-ceph-tempest/3770f81/ : SUCCESS in 1h 22m 41s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/29/655429/1/check/neutron-grenade-multinode/59527f1/ : SUCCESS in 1h 06m 11s\n- nova-grenade-live-migration http://logs.openstack.org/29/655429/1/check/nova-grenade-live-migration/49314ae/ : SUCCESS in 1h 50m 21s\n- nova-live-migration http://logs.openstack.org/29/655429/1/check/nova-live-migration/7de916b/ : SUCCESS in 51m 16s\n- nova-next http://logs.openstack.org/29/655429/1/check/nova-next/7e6c956/ : SUCCESS in 1h 43m 04s\n- nova-tox-functional http://logs.openstack.org/29/655429/1/check/nova-tox-functional/25cab56/ : SUCCESS in 21m 48s\n- nova-tox-functional-py35 http://logs.openstack.org/29/655429/1/check/nova-tox-functional-py35/7b5ffb0/ : SUCCESS in 18m 12s\n- tempest-multinode-full http://logs.openstack.org/29/655429/1/check/tempest-multinode-full/22b2420/ : SUCCESS in 1h 46m 01s (non-voting)\n- tempest-slow-py3 http://logs.openstack.org/29/655429/1/check/tempest-slow-py3/dc061db/ : SUCCESS in 2h 15m 34s","accounts_in_message":[],"_revision_number":1},{"id":"124b456410d274ad9310ce3f625fff8bb15863f3","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-04-24 20:02:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b2bbe4616dab3bcc8d54f3855fde6c4326f29097","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-04-24 22:28:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"ad2625b6f3bd544d7df14145b250006d32dbd525","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 22:29:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"55b7448889b302c3ee8edae516fa30e753ff450b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 22:56:32.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"299f8598e64f041457170f2b6268409690d5eb89","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-25 03:08:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/29/655429/1/gate/grenade-py3/610a420/ : SUCCESS in 58m 12s\n- tempest-full-py3 http://logs.openstack.org/29/655429/1/gate/tempest-full-py3/6f1532e/ : SUCCESS in 1h 38m 04s\n- openstack-tox-lower-constraints http://logs.openstack.org/29/655429/1/gate/openstack-tox-lower-constraints/2258497/ : SUCCESS in 10m 25s\n- openstack-tox-pep8 http://logs.openstack.org/29/655429/1/gate/openstack-tox-pep8/50aff0d/ : SUCCESS in 9m 43s\n- openstack-tox-py27 http://logs.openstack.org/29/655429/1/gate/openstack-tox-py27/30b3fcd/ : SUCCESS in 12m 13s\n- openstack-tox-py35 http://logs.openstack.org/29/655429/1/gate/openstack-tox-py35/cdec46b/ : SUCCESS in 13m 42s\n- openstack-tox-py36 http://logs.openstack.org/29/655429/1/gate/openstack-tox-py36/ef0912c/ : SUCCESS in 11m 43s\n- openstack-tox-py37 http://logs.openstack.org/29/655429/1/gate/openstack-tox-py37/fa3953f/ : SUCCESS in 10m 39s\n- openstack-tox-docs http://logs.openstack.org/29/655429/1/gate/openstack-tox-docs/6e1f7db/html/ : SUCCESS in 6m 07s\n- nova-grenade-live-migration http://logs.openstack.org/29/655429/1/gate/nova-grenade-live-migration/ff0a7e4/ : SUCCESS in 1h 02m 39s\n- nova-live-migration http://logs.openstack.org/29/655429/1/gate/nova-live-migration/8e36ec0/ : SUCCESS in 48m 36s\n- nova-tox-functional http://logs.openstack.org/29/655429/1/gate/nova-tox-functional/1c1c2c3/ : SUCCESS in 18m 23s\n- nova-tox-functional-py35 http://logs.openstack.org/29/655429/1/gate/nova-tox-functional-py35/c238301/ : SUCCESS in 19m 34s\n- nova-next http://logs.openstack.org/29/655429/1/gate/nova-next/a241219/ : SUCCESS in 1h 28m 03s\n- tempest-slow-py3 http://logs.openstack.org/29/655429/1/gate/tempest-slow-py3/12ed3b7/ : SUCCESS in 2h 19m 57s","accounts_in_message":[],"_revision_number":1},{"id":"095fb7e600061ea0332c73193ceb5b0b1666a367","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-25 03:08:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"14c459bd490035dc1889c596674a303e4c606b3c","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-04-25 09:53:57.000000000","message":"Patch Set 1:\n\nManual cherry pick required for this one.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e6ca3838d940dea417cdeffe22c656d222737a7e","revisions":{"e6ca3838d940dea417cdeffe22c656d222737a7e":{"kind":"REWORK","_number":1,"created":"2019-04-24 13:31:25.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/29/655429/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/655429/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/655429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/655429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/655429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/655429/1"}}},"commit":{"parents":[{"commit":"2888bc6dbf721efd23efe0bba322c2089753f8e4","subject":"Merge \"libvirt: set device address tag only if setting disk unit\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2888bc6dbf721efd23efe0bba322c2089753f8e4"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-04-19 20:35:21.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-04-24 13:31:25.000000000","tz":0},"subject":"Fix {min|max}_version in ironic Adapter setup","message":"Fix {min|max}_version in ironic Adapter setup\n\nChange If625411f40be0ba642baeb02950f568f43673655 introduced\nnova.utils.get_ksa_adapter, which accepts min_version and max_version\nkwargs to be passed through to the ksa Adapter constructor. These are\nsupposed to represent minimum and maximum *major* API versions,\nmin_version was erroneously set to *microversions* when setting up the\nAdapter for ironicclient. This commit changes it to a major version.\n(Microversion negotiation is done within ironicclient itself.)\n\nAlso, this bug went latent for several releases because a) it only seems\nto be triggered when region_name is given in the conf; but also b)\nironicclient has code to discover a reasonable endpoint if passed None.\nSo this change also adds a warning log if we try and fail to discover\nthe endpoint via ksa.\n\nChange-Id: I34a3f8d4a496217eb01790e2d124111625bf5f85\nCloses-Bug: #1825583\n(cherry picked from commit 13278be9f265e237fc68ee60acfacaa1df68522e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e6ca3838d940dea417cdeffe22c656d222737a7e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e6ca3838d940dea417cdeffe22c656d222737a7e"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}