)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1d50267156b0f86f76bc57ff5c24bb54655d970","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        self.compute_rpcapi \u003d compute_rpcapi.ComputeAPI()"},{"line_number":273,"context_line":"        self.compute_task_api \u003d conductor.ComputeTaskAPI()"},{"line_number":274,"context_line":"        self.servicegroup_api \u003d servicegroup.API()"},{"line_number":275,"context_line":"        self.host_api \u003d HostAPI(self.compute_rpcapi, self.servicegroup_api)"},{"line_number":276,"context_line":"        self.notifier \u003d rpc.get_notifier(\u0027compute\u0027, CONF.host)"},{"line_number":277,"context_line":"        if CONF.ephemeral_storage_encryption.enabled:"},{"line_number":278,"context_line":"            self.key_manager \u003d key_manager.API()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_a79ecfb5","line":275,"updated":"2019-04-24 23:16:47.000000000","message":"Yes this class now holds an instance of HostAPI but...","commit_id":"76714f38932177b72c38bf0b7cb29045692bc789"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ebeade2e2d712881741e094da61e3aefb56b4a0c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        self.compute_rpcapi \u003d compute_rpcapi.ComputeAPI()"},{"line_number":273,"context_line":"        self.compute_task_api \u003d conductor.ComputeTaskAPI()"},{"line_number":274,"context_line":"        self.servicegroup_api \u003d servicegroup.API()"},{"line_number":275,"context_line":"        self.host_api \u003d HostAPI(self.compute_rpcapi, self.servicegroup_api)"},{"line_number":276,"context_line":"        self.notifier \u003d rpc.get_notifier(\u0027compute\u0027, CONF.host)"},{"line_number":277,"context_line":"        if CONF.ephemeral_storage_encryption.enabled:"},{"line_number":278,"context_line":"            self.key_manager \u003d key_manager.API()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_e7e1272c","line":275,"range":{"start_line":275,"start_character":53,"end_line":275,"end_character":74},"updated":"2019-04-24 23:23:31.000000000","message":"name this kwarg","commit_id":"76714f38932177b72c38bf0b7cb29045692bc789"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1d50267156b0f86f76bc57ff5c24bb54655d970","unresolved":false,"context_lines":[{"line_number":1786,"context_line":""},{"line_number":1787,"context_line":"        if availability_zone:"},{"line_number":1788,"context_line":"            available_zones \u003d availability_zones.\\"},{"line_number":1789,"context_line":"                get_availability_zones(context.elevated(), self.host_api,"},{"line_number":1790,"context_line":"                                       get_only_available\u003dTrue)"},{"line_number":1791,"context_line":"            if forced_host is None and availability_zone not in \\"},{"line_number":1792,"context_line":"                    available_zones:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_47a59303","line":1789,"range":{"start_line":1789,"start_character":16,"end_line":1789,"end_character":38},"updated":"2019-04-24 23:16:47.000000000","message":"...before this, this method was always creating an instance of HostAPI every time it was called, which is pretty nutty.","commit_id":"76714f38932177b72c38bf0b7cb29045692bc789"}],"nova/tests/fixtures.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3693204cafcc156d94357148afbade2b18aed6f3","unresolved":false,"context_lines":[{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"        def fake_get_availability_zones("},{"line_number":2223,"context_line":"                *args, get_only_available\u003dFalse, **kwargs):"},{"line_number":2224,"context_line":"            # A 2-item tuple is returned if get_only_available\u003dFalse."},{"line_number":2225,"context_line":"            if not get_only_available:"},{"line_number":2226,"context_line":"                return self.zones, []"},{"line_number":2227,"context_line":"            return self.zones"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_63e19cd0","line":2224,"updated":"2019-04-25 16:48:24.000000000","message":"Why not make this signature match the method\u0027s exactly?","commit_id":"f64a92b3cb6440dd48a4df2dfb61dbf92eb805fd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"935f9f19662f443afd52dea3b0e57eb3f47435c7","unresolved":false,"context_lines":[{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"        def fake_get_availability_zones("},{"line_number":2223,"context_line":"                *args, get_only_available\u003dFalse, **kwargs):"},{"line_number":2224,"context_line":"            # A 2-item tuple is returned if get_only_available\u003dFalse."},{"line_number":2225,"context_line":"            if not get_only_available:"},{"line_number":2226,"context_line":"                return self.zones, []"},{"line_number":2227,"context_line":"            return self.zones"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_89d62ef1","line":2224,"in_reply_to":"ffb9cba7_63e19cd0","updated":"2019-04-25 21:34:18.000000000","message":"Because that\u0027s what caused it to fail in the first place - the other args/kwargs aren\u0027t used so rather than try to keep pace just ignore the stuff we don\u0027t care about.","commit_id":"f64a92b3cb6440dd48a4df2dfb61dbf92eb805fd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c869c356d03103e417582e9c4a3811293315887b","unresolved":false,"context_lines":[{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"        def fake_get_availability_zones("},{"line_number":2223,"context_line":"                *args, get_only_available\u003dFalse, **kwargs):"},{"line_number":2224,"context_line":"            # A 2-item tuple is returned if get_only_available\u003dFalse."},{"line_number":2225,"context_line":"            if not get_only_available:"},{"line_number":2226,"context_line":"                return self.zones, []"},{"line_number":2227,"context_line":"            return self.zones"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_89e06e98","line":2224,"in_reply_to":"ffb9cba7_89d62ef1","updated":"2019-04-25 22:17:31.000000000","message":"Right, so keeping the signatures matching is an extra check that all the callers are calling correctly.","commit_id":"f64a92b3cb6440dd48a4df2dfb61dbf92eb805fd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"580e2055478cf24119fc24ca80113a58d19331b5","unresolved":false,"context_lines":[{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"        def fake_get_availability_zones("},{"line_number":2223,"context_line":"                *args, get_only_available\u003dFalse, **kwargs):"},{"line_number":2224,"context_line":"            # A 2-item tuple is returned if get_only_available\u003dFalse."},{"line_number":2225,"context_line":"            if not get_only_available:"},{"line_number":2226,"context_line":"                return self.zones, []"},{"line_number":2227,"context_line":"            return self.zones"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_b2490b8c","line":2224,"in_reply_to":"ffb9cba7_89e06e98","updated":"2019-04-26 19:31:26.000000000","message":"Done","commit_id":"f64a92b3cb6440dd48a4df2dfb61dbf92eb805fd"}]}