)]}'
{"id":"openstack%2Fnova~655693","triplet_id":"openstack%2Fnova~stable%2Frocky~I34a3f8d4a496217eb01790e2d124111625bf5f85","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1825583","hashtags":[],"change_id":"I34a3f8d4a496217eb01790e2d124111625bf5f85","subject":"Fix {min|max}_version in ironic Adapter setup","status":"MERGED","created":"2019-04-25 13:38:57.000000000","updated":"2019-04-30 11:35:56.000000000","submitted":"2019-04-30 11:35:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"655693-1556624156652-332a2ac9","meta_rev_id":"c421d69d7b3602a01198c3ce6159a598cd3db4bb","_number":655693,"virtual_id_number":655693,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-04-25 14:17:28.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2019-04-25 15:31:56.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-04-30 11:35:56.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-26 06:53:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-04-30 09:26:38.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-04-25 13:46:40.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-04-30 09:26:38.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-25 13:46:40.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-04-25 14:17:28.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-25 15:31:56.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-04-26 06:53:34.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-04-30 09:26:38.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-04-30 11:35:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f51187f6f51ca9fcaa4eff7d788d8ad36f0c9b20","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-04-25 13:38:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ed3c5d5d5c9cf75320ee58fff6d5c70001b3c889","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-25 13:46:40.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM and the conflict is noted in the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"ae8afd2318ba18872875c3cea446cc1957e76292","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-04-25 14:17:28.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/93/655693/1/check/nova-out-of-tree-pvm/5b4b1bc : FAILURE in 21m 02s\n- nova-in-tree-pvm http://184.172.12.213/93/655693/1/check/nova-in-tree-pvm/dafa51f : FAILURE in 21m 34s","accounts_in_message":[],"_revision_number":1},{"id":"e07517b5476f4f0d4b3f8c0ee1ebec19290dbaf6","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-04-25 15:31:56.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/655693/1 : SUCCESS in 1h 52m 14s","accounts_in_message":[],"_revision_number":1},{"id":"072e284f5a875e7c070e8543ec13c53876723300","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-25 21:53:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/93/655693/1/check/openstack-tox-pep8/6a9c686/ : SUCCESS in 9m 45s\n- openstack-tox-py27 http://logs.openstack.org/93/655693/1/check/openstack-tox-py27/a4f0f48/ : SUCCESS in 13m 55s\n- openstack-tox-py35 http://logs.openstack.org/93/655693/1/check/openstack-tox-py35/85dfcee/ : SUCCESS in 14m 09s\n- build-openstack-sphinx-docs http://logs.openstack.org/93/655693/1/check/build-openstack-sphinx-docs/4fb984d/html/ : SUCCESS in 7m 14s\n- tempest-full http://logs.openstack.org/93/655693/1/check/tempest-full/23977ad/ : SUCCESS in 1h 34m 48s\n- neutron-grenade http://logs.openstack.org/93/655693/1/check/neutron-grenade/387cf75/ : SUCCESS in 1h 00m 38s\n- tempest-full-py3 http://logs.openstack.org/93/655693/1/check/tempest-full-py3/5071c86/ : SUCCESS in 1h 19m 59s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/93/655693/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/712a63b/ : SUCCESS in 47m 17s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/93/655693/1/check/nova-cells-v1/bb1d157/ : SUCCESS in 54m 46s\n- nova-grenade-live-migration http://logs.openstack.org/93/655693/1/check/nova-grenade-live-migration/a39f41a/ : SUCCESS in 1h 05m 20s (non-voting)\n- nova-live-migration http://logs.openstack.org/93/655693/1/check/nova-live-migration/fe2aced/ : SUCCESS in 47m 31s\n- nova-multiattach http://logs.openstack.org/93/655693/1/check/nova-multiattach/2b9372b/ : SUCCESS in 1h 07m 23s\n- nova-next http://logs.openstack.org/93/655693/1/check/nova-next/94a4a17/ : SUCCESS in 1h 24m 31s\n- tempest-slow http://logs.openstack.org/93/655693/1/check/tempest-slow/4593311/ : SUCCESS in 2h 07m 16s\n- nova-tox-functional http://logs.openstack.org/93/655693/1/check/nova-tox-functional/4f754dc/ : SUCCESS in 16m 52s\n- nova-tox-functional-py35 http://logs.openstack.org/93/655693/1/check/nova-tox-functional-py35/2b4350b/ : SUCCESS in 15m 03s\n- openstack-tox-lower-constraints http://logs.openstack.org/93/655693/1/check/openstack-tox-lower-constraints/0a320a7/ : SUCCESS in 13m 26s\n- neutron-grenade-multinode http://logs.openstack.org/93/655693/1/check/neutron-grenade-multinode/0de8ed1/ : SUCCESS in 55m 38s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/93/655693/1/check/devstack-plugin-ceph-tempest/7166703/ : SUCCESS in 1h 16m 53s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/93/655693/1/check/tempest-multinode-full/b03334d/ : SUCCESS in 1h 35m 57s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d6a326784b4ba1c8b8904c3a51dbe071b338f7ef","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-04-26 06:53:34.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"defc3eb564fb39758eac44b70e1a2ab7e9a1a454","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-04-30 09:26:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM, conflicts noted and correct.","accounts_in_message":[],"_revision_number":1},{"id":"99602f99337f679d50417432ae5b14a14f2ed21b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 09:27:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"01616040f1d32a68cea1150d3383b3de3006223b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 11:35:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"91dbcce9c5c3bb8a3a818e71fe50edf881215b8f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 11:35:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/93/655693/1/gate/openstack-tox-pep8/54df6c1/ : SUCCESS in 10m 13s\n- openstack-tox-py27 http://logs.openstack.org/93/655693/1/gate/openstack-tox-py27/7d8cad5/ : SUCCESS in 12m 15s\n- openstack-tox-py35 http://logs.openstack.org/93/655693/1/gate/openstack-tox-py35/67540bb/ : SUCCESS in 12m 49s\n- build-openstack-sphinx-docs http://logs.openstack.org/93/655693/1/gate/build-openstack-sphinx-docs/e4c22c3/html/ : SUCCESS in 6m 41s\n- tempest-full http://logs.openstack.org/93/655693/1/gate/tempest-full/c6d82eb/ : SUCCESS in 1h 33m 39s\n- neutron-grenade http://logs.openstack.org/93/655693/1/gate/neutron-grenade/e35e51d/ : SUCCESS in 54m 23s\n- tempest-full-py3 http://logs.openstack.org/93/655693/1/gate/tempest-full-py3/9fdb796/ : SUCCESS in 1h 20m 02s\n- nova-cells-v1 http://logs.openstack.org/93/655693/1/gate/nova-cells-v1/d82aaff/ : SUCCESS in 1h 03m 37s\n- nova-live-migration http://logs.openstack.org/93/655693/1/gate/nova-live-migration/8b9b641/ : SUCCESS in 43m 43s\n- nova-multiattach http://logs.openstack.org/93/655693/1/gate/nova-multiattach/c78b89b/ : SUCCESS in 58m 47s\n- nova-next http://logs.openstack.org/93/655693/1/gate/nova-next/cd073b9/ : SUCCESS in 1h 24m 44s\n- tempest-slow http://logs.openstack.org/93/655693/1/gate/tempest-slow/724b767/ : SUCCESS in 2h 02m 28s\n- nova-tox-functional http://logs.openstack.org/93/655693/1/gate/nova-tox-functional/10f55e0/ : SUCCESS in 16m 05s\n- nova-tox-functional-py35 http://logs.openstack.org/93/655693/1/gate/nova-tox-functional-py35/a37ac48/ : SUCCESS in 16m 42s\n- openstack-tox-lower-constraints http://logs.openstack.org/93/655693/1/gate/openstack-tox-lower-constraints/700b045/ : SUCCESS in 11m 33s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"35bda4ec385e4c2b3d4cee07467f5077b13b1dd9","revisions":{"35bda4ec385e4c2b3d4cee07467f5077b13b1dd9":{"kind":"REWORK","_number":1,"created":"2019-04-25 13:38:57.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/93/655693/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/655693/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/655693/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/655693/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/655693/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/655693/1"}}},"commit":{"parents":[{"commit":"d8c5a2f045b0c9f0ed7c610785badfeb5b94f144","subject":"Merge \"libvirt: set device address tag only if setting disk unit\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d8c5a2f045b0c9f0ed7c610785badfeb5b94f144"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-04-19 20:35:21.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-04-25 13:38:41.000000000","tz":-300},"subject":"Fix {min|max}_version in ironic Adapter setup","message":"Fix {min|max}_version in ironic Adapter setup\n\nChange If625411f40be0ba642baeb02950f568f43673655 introduced\nnova.utils.get_ksa_adapter, which accepts min_version and max_version\nkwargs to be passed through to the ksa Adapter constructor. These are\nsupposed to represent minimum and maximum *major* API versions,\nmin_version was erroneously set to *microversions* when setting up the\nAdapter for ironicclient. This commit changes it to a major version.\n(Microversion negotiation is done within ironicclient itself.)\n\nAlso, this bug went latent for several releases because a) it only seems\nto be triggered when region_name is given in the conf; but also b)\nironicclient has code to discover a reasonable endpoint if passed None.\nSo this change also adds a warning log if we try and fail to discover\nthe endpoint via ksa.\n\nConflicts:\n\tnova/tests/unit/virt/ironic/test_client_wrapper.py\nThis was just because the old microversion was 1.38 instead of 1.46. The\npatch still changes it to 1.0.\n\nChange-Id: I34a3f8d4a496217eb01790e2d124111625bf5f85\nCloses-Bug: #1825583\n(cherry picked from commit 13278be9f265e237fc68ee60acfacaa1df68522e)\n(cherry picked from commit e6ca3838d940dea417cdeffe22c656d222737a7e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/35bda4ec385e4c2b3d4cee07467f5077b13b1dd9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/35bda4ec385e4c2b3d4cee07467f5077b13b1dd9"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}