)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"668922dff5176bf247a8a02636a511e6ae28501d","unresolved":false,"context_lines":[{"line_number":1544,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1545,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1546,"context_line":"                if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1547,"context_line":"                    LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1548,"context_line":"                        \u0027known Libvirt issue, see the following bug for \u0027"},{"line_number":1549,"context_line":"                        \u0027details: https://bugzilla.redhat.com/1447297\u0027))"},{"line_number":1550,"context_line":"        except Exception:"},{"line_number":1551,"context_line":"            LOG.exception(_(\u0027Failed to attach volume at mountpoint: %s\u0027),"},{"line_number":1552,"context_line":"                          mountpoint, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_f4146c50","line":1549,"range":{"start_line":1547,"start_character":32,"end_line":1549,"end_character":71},"updated":"2019-04-25 13:52:23.000000000","message":"nit: the alignment here is a bit icky","commit_id":"a0c9957c70964c5c3980e23caebcfe9045cabd9c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"94c6663f023ce514e0de8681e52f7c6332976928","unresolved":false,"context_lines":[{"line_number":1544,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1545,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1546,"context_line":"                if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1547,"context_line":"                    LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1548,"context_line":"                        \u0027known Libvirt issue, see the following bug for \u0027"},{"line_number":1549,"context_line":"                        \u0027details: https://bugzilla.redhat.com/1447297\u0027))"},{"line_number":1550,"context_line":"        except Exception:"},{"line_number":1551,"context_line":"            LOG.exception(_(\u0027Failed to attach volume at mountpoint: %s\u0027),"},{"line_number":1552,"context_line":"                          mountpoint, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_f7f30e09","line":1549,"range":{"start_line":1547,"start_character":32,"end_line":1549,"end_character":71},"in_reply_to":"ffb9cba7_f4146c50","updated":"2019-04-25 14:04:13.000000000","message":"Done","commit_id":"a0c9957c70964c5c3980e23caebcfe9045cabd9c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"94c6663f023ce514e0de8681e52f7c6332976928","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"            LOG.exception(_(\u0027Failed to attach volume at mountpoint: %s\u0027),"},{"line_number":1552,"context_line":"                          mountpoint, instance\u003dinstance)"},{"line_number":1553,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1554,"context_line":"                self._disconnect_volume(context, connection_info, instance,"},{"line_number":1555,"context_line":"                                        encryption\u003dencryption)"},{"line_number":1556,"context_line":""},{"line_number":1557,"context_line":"    def _swap_volume(self, guest, disk_path, conf, resize_to):"},{"line_number":1558,"context_line":"        \"\"\"Swap existing disk with a new block device.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_d7d84a80","line":1555,"range":{"start_line":1554,"start_character":0,"end_line":1555,"end_character":62},"updated":"2019-04-25 14:04:13.000000000","message":"Shouldn\u0027t we also be calling this above?","commit_id":"a0c9957c70964c5c3980e23caebcfe9045cabd9c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"70da237b5f99f017b0515746e98c84f3411116fd","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"            LOG.exception(_(\u0027Failed to attach volume at mountpoint: %s\u0027),"},{"line_number":1552,"context_line":"                          mountpoint, instance\u003dinstance)"},{"line_number":1553,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1554,"context_line":"                self._disconnect_volume(context, connection_info, instance,"},{"line_number":1555,"context_line":"                                        encryption\u003dencryption)"},{"line_number":1556,"context_line":""},{"line_number":1557,"context_line":"    def _swap_volume(self, guest, disk_path, conf, resize_to):"},{"line_number":1558,"context_line":"        \"\"\"Swap existing disk with a new block device.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_f7b22ee6","line":1555,"range":{"start_line":1554,"start_character":0,"end_line":1555,"end_character":62},"in_reply_to":"ffb9cba7_d7d84a80","updated":"2019-04-25 14:16:16.000000000","message":"Hmm, yeah maybe? I don\u0027t know if we can get libvirtError after attaching the device or not, like from _build_device_metadata, but if _disconnect_volume is idempotent then it\u0027s probably safest to try and disconnect if something failed during the attach. You could also tee that up as a separate change to keep the diff small.","commit_id":"a0c9957c70964c5c3980e23caebcfe9045cabd9c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dde209fb1b309b285fb61304038ac49667523fa9","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"                                  \u0027for details: \u0027"},{"line_number":1550,"context_line":"                                  \u0027https://bugzilla.redhat.com/1447297\u0027))"},{"line_number":1551,"context_line":"                else:"},{"line_number":1552,"context_line":"                    LOG.exception(_(\u0027Failed to attach volume at mountpoint: \u0027"},{"line_number":1553,"context_line":"                                    \u0027%s\u0027), mountpoint, instance\u003dinstance)"},{"line_number":1554,"context_line":"        except Exception:"},{"line_number":1555,"context_line":"            LOG.exception(_(\u0027Failed to attach volume at mountpoint: %s\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_bac7b245","line":1552,"range":{"start_line":1552,"start_character":34,"end_line":1552,"end_character":35},"updated":"2019-04-26 01:49:50.000000000","message":"These don\u0027t need to be marked for translation, they don\u0027t get translated anyway.","commit_id":"bc57ae50734fa6a70115b6369e867079fb5eb4b8"}]}