)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1a3ec26d7ab1fb1adaf5cdcfef4787ee1e20aefe","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a static list, so a test is fairly pointless."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related to blueprint bp/request-filter-image-types"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If4fb4d3aa002c70ff0d1aa56de8773a2685957aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_c395e841","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":24},"updated":"2019-04-25 16:51:08.000000000","message":"nit: this breaks the link.","commit_id":"f7911de87fd139d29efb1679df18684903308e60"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1a3ec26d7ab1fb1adaf5cdcfef4787ee1e20aefe","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                    \"supports_image_type_aki\": False,"},{"line_number":166,"context_line":"                    \"supports_image_type_ami\": False,"},{"line_number":167,"context_line":"                    \"supports_image_type_ari\": False,"},{"line_number":168,"context_line":"                    \"supports_image_type_iso\": False,"},{"line_number":169,"context_line":"                    \"supports_image_type_qcow2\": False,"},{"line_number":170,"context_line":"                    \"supports_image_type_raw\": True,"},{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_632f5cf6","line":168,"range":{"start_line":168,"start_character":21,"end_line":168,"end_character":44},"updated":"2019-04-25 16:51:08.000000000","message":"Not sure about this one:\n\nhttps://docs.openstack.org/ironic/stein/admin/interfaces/boot.html?highlight\u003diso","commit_id":"f7911de87fd139d29efb1679df18684903308e60"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1a3ec26d7ab1fb1adaf5cdcfef4787ee1e20aefe","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                    \"supports_image_type_ami\": False,"},{"line_number":167,"context_line":"                    \"supports_image_type_ari\": False,"},{"line_number":168,"context_line":"                    \"supports_image_type_iso\": False,"},{"line_number":169,"context_line":"                    \"supports_image_type_qcow2\": False,"},{"line_number":170,"context_line":"                    \"supports_image_type_raw\": True,"},{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"},{"line_number":172,"context_line":"                    \"supports_image_type_vhd\": False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_432c9801","line":169,"range":{"start_line":169,"start_character":20,"end_line":169,"end_character":55},"updated":"2019-04-25 16:51:08.000000000","message":"Hmm, I\u0027m not sure if this is meant to be taken literally from the ironic docs, but probably not (probably just copied from somewhere):\n\nhttps://docs.openstack.org/ironic/stein/admin/drivers/ansible.html?highlight\u003ddisk_format\n\nSome other parts in the docs seem to suggest it\u0027s just raw that\u0027s supported:\n\nhttps://docs.openstack.org/ironic/stein/install/refarch/common.html?highlight\u003draw#disk-space\n\nhttps://docs.openstack.org/ironic/stein/configuration/config.html?highlight\u003draw#agent.stream_raw_images","commit_id":"f7911de87fd139d29efb1679df18684903308e60"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b4f9ccb555e2ed95857c53c057baf899c141639e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                    \"supports_image_type_ami\": False,"},{"line_number":167,"context_line":"                    \"supports_image_type_ari\": False,"},{"line_number":168,"context_line":"                    \"supports_image_type_iso\": False,"},{"line_number":169,"context_line":"                    \"supports_image_type_qcow2\": False,"},{"line_number":170,"context_line":"                    \"supports_image_type_raw\": True,"},{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"},{"line_number":172,"context_line":"                    \"supports_image_type_vhd\": False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_e3ccac62","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":55},"updated":"2019-04-25 16:48:53.000000000","message":"We definitely support qcow2.","commit_id":"f7911de87fd139d29efb1679df18684903308e60"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3e221a809a151a79bb24fbafcf5fe3778bb723e2","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                    \"supports_image_type_ami\": False,"},{"line_number":167,"context_line":"                    \"supports_image_type_ari\": False,"},{"line_number":168,"context_line":"                    \"supports_image_type_iso\": False,"},{"line_number":169,"context_line":"                    \"supports_image_type_qcow2\": False,"},{"line_number":170,"context_line":"                    \"supports_image_type_raw\": True,"},{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"},{"line_number":172,"context_line":"                    \"supports_image_type_vhd\": False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_43649822","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":55},"in_reply_to":"ffb9cba7_23608432","updated":"2019-04-25 17:02:09.000000000","message":"Yeah, we should probably document that. But I have a devstack environment right now with two instances deployed from qcow2 images :)\n\nWhat https://docs.openstack.org/ironic/stein/install/refarch/common.html?highlight\u003draw#disk-space is talking about is that we convert everything to raw under the hood.","commit_id":"f7911de87fd139d29efb1679df18684903308e60"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c3c1a17ddf25176f601a803a005082bd85b457fa","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                    \"supports_image_type_ami\": False,"},{"line_number":167,"context_line":"                    \"supports_image_type_ari\": False,"},{"line_number":168,"context_line":"                    \"supports_image_type_iso\": False,"},{"line_number":169,"context_line":"                    \"supports_image_type_qcow2\": False,"},{"line_number":170,"context_line":"                    \"supports_image_type_raw\": True,"},{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"},{"line_number":172,"context_line":"                    \"supports_image_type_vhd\": False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_23608432","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":55},"in_reply_to":"ffb9cba7_e3ccac62","updated":"2019-04-25 16:55:21.000000000","message":"\u003e We definitely support qcow2.\n\nHeh, I didn\u0027t see anything about qcow in the ironic docs.\n\nhttps://docs.openstack.org/ironic/stein/search.html?q\u003dqcow\n\nTo be fair, there isn\u0027t much in the nova docs either besides a config option:\n\nhttps://docs.openstack.org/nova/stein/configuration/config.html?highlight\u003dcow","commit_id":"f7911de87fd139d29efb1679df18684903308e60"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b4f9ccb555e2ed95857c53c057baf899c141639e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    \"supports_image_type_iso\": False,"},{"line_number":169,"context_line":"                    \"supports_image_type_qcow2\": False,"},{"line_number":170,"context_line":"                    \"supports_image_type_raw\": True,"},{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"},{"line_number":172,"context_line":"                    \"supports_image_type_vhd\": False,"},{"line_number":173,"context_line":"                    \"supports_image_type_vhdx\": False,"},{"line_number":174,"context_line":"                    \"supports_image_type_vmdk\": False,"},{"line_number":175,"context_line":"                    }"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # This driver is capable of rebalancing nodes between computes."}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_23b644db","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":54},"updated":"2019-04-25 16:48:53.000000000","message":"I guess we support anything that qemu-img supports, but this is probably fine.","commit_id":"f7911de87fd139d29efb1679df18684903308e60"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"098bb238a4730b0f2dedb92acbb9ac3a5d4bb8d0","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    \"supports_image_type_iso\": False,"},{"line_number":169,"context_line":"                    \"supports_image_type_qcow2\": False,"},{"line_number":170,"context_line":"                    \"supports_image_type_raw\": True,"},{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"},{"line_number":172,"context_line":"                    \"supports_image_type_vhd\": False,"},{"line_number":173,"context_line":"                    \"supports_image_type_vhdx\": False,"},{"line_number":174,"context_line":"                    \"supports_image_type_vmdk\": False,"},{"line_number":175,"context_line":"                    }"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # This driver is capable of rebalancing nodes between computes."}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_2318847f","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":54},"in_reply_to":"ffb9cba7_23b644db","updated":"2019-04-25 17:09:39.000000000","message":"Okay, I grep\u0027d the driver code and didn\u0027t find really any mention of qemu supported things, so I assumed.","commit_id":"f7911de87fd139d29efb1679df18684903308e60"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a785a2568798299ed3302b8df9b0b8f5379869d4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                    \"supports_image_type_vdi\": False,"},{"line_number":172,"context_line":"                    \"supports_image_type_vhd\": False,"},{"line_number":173,"context_line":"                    \"supports_image_type_vhdx\": False,"},{"line_number":174,"context_line":"                    \"supports_image_type_vmdk\": False,"},{"line_number":175,"context_line":"                    }"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # This driver is capable of rebalancing nodes between computes."}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_bd8c54d7","line":174,"updated":"2019-04-30 13:03:13.000000000","message":"As Dmitry mentioned, we support anything that `qemu-img convert` supports. We convert here: https://opendev.org/openstack/ironic-lib/src/branch/master/ironic_lib/disk_utils.py#L342\n\nI\u0027m fine with this to start, though, if someone wants to prove that vmdk and such work, they can submit a patch.","commit_id":"6fc1049ee866944f100522968ebece8e29efc790"}]}