)]}'
{"nova/tests/api/ec2/test_cloud.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"fa65670c6a32260c3481a282fc6fb5336fa6b3a6","unresolved":false,"context_lines":[{"line_number":2958,"context_line":"            \u0027compute:attach_volume\u0027:"},{"line_number":2959,"context_line":"                common_policy.parse_rule(\"project_id:non_fake\")"},{"line_number":2960,"context_line":"        }"},{"line_number":2961,"context_line":"        common_policy.set_rules(common_policy.Rules(rules))"},{"line_number":2962,"context_line":""},{"line_number":2963,"context_line":"        self._restart_compute_service(periodic_interval_max\u003d0.3)"},{"line_number":2964,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Bna4%3D","line":2961,"updated":"2014-02-20 07:15:26.000000000","message":"I guess ff you move this to before line 2978, then you just need fake \u0027compute:get\u0027 and \u0027compute:attach_volume\u0027. But it\u0027s ok. You can update it when you have to update patch.","commit_id":"79e8a9e1c19475b6a21947b16b55b6b3128fc0eb"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"3fa780daa4ae79262c3a59c068cf2ec1b6503637","unresolved":false,"context_lines":[{"line_number":2958,"context_line":"            \u0027compute:attach_volume\u0027:"},{"line_number":2959,"context_line":"                common_policy.parse_rule(\"project_id:non_fake\")"},{"line_number":2960,"context_line":"        }"},{"line_number":2961,"context_line":"        common_policy.set_rules(common_policy.Rules(rules))"},{"line_number":2962,"context_line":""},{"line_number":2963,"context_line":"        self._restart_compute_service(periodic_interval_max\u003d0.3)"},{"line_number":2964,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BmSU%3D","line":2961,"in_reply_to":"AAAAUX%2F%2Bna4%3D","updated":"2014-02-20 09:30:04.000000000","message":"Yes, you are right, the rlues has loaded the fake_policy, here has to set the policy again. but i think it \u0027s ok.","commit_id":"79e8a9e1c19475b6a21947b16b55b6b3128fc0eb"}],"nova/tests/api/openstack/compute/contrib/test_volumes.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7dfc015db3ff3b4417c9bcca5e6e3c5d4bf6c1dc","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def test_detach_policy_failed(self):"},{"line_number":361,"context_line":"        rules \u003d {"},{"line_number":362,"context_line":"            \u0027compute:get\u0027: common_policy.parse_rule(\u0027\u0027),"},{"line_number":363,"context_line":"            \u0027compute_extension:volumes\u0027: common_policy.parse_rule(\u0027\u0027),"},{"line_number":364,"context_line":"            \u0027compute_extension:volume_attachments:delete\u0027:"},{"line_number":365,"context_line":"                common_policy.parse_rule(\"project_id:non_fake\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BwAs%3D","line":362,"updated":"2014-01-22 14:48:17.000000000","message":"is it need? looks to me last rule might be enough ....","commit_id":"bbc4f788b1fd79c0c80c8ce6b867765e920d6c4d"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"74c0bd45fe4b16fc7e9bb76d6e2f3ba88d9f4217","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def test_detach_policy_failed(self):"},{"line_number":361,"context_line":"        rules \u003d {"},{"line_number":362,"context_line":"            \u0027compute:get\u0027: common_policy.parse_rule(\u0027\u0027),"},{"line_number":363,"context_line":"            \u0027compute_extension:volumes\u0027: common_policy.parse_rule(\u0027\u0027),"},{"line_number":364,"context_line":"            \u0027compute_extension:volume_attachments:delete\u0027:"},{"line_number":365,"context_line":"                common_policy.parse_rule(\"project_id:non_fake\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bs4o%3D","line":362,"in_reply_to":"AAAAUH%2F%2BwAs%3D","updated":"2014-01-23 01:42:47.000000000","message":"I think it\u0027s need here, it changes the check rules, should contain all the necessary rules. the get is used in the detach. and if we move the check of get to api layer, don\u0027t need to change here again.","commit_id":"bbc4f788b1fd79c0c80c8ce6b867765e920d6c4d"}]}