)]}'
{"nova/tests/unit/privsep/test_libvirt.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"877392a6003a305421fcc89084daa106e6e42d6a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # NOTE(mikal): we can\u0027t assert that values from fcntl are passed"},{"line_number":150,"context_line":"            # here because we can\u0027t import fcntl in these tests because it"},{"line_number":151,"context_line":"            # is not present on Microsoft Windows."},{"line_number":152,"context_line":"            mock_fcntl.assert_has_calls("},{"line_number":153,"context_line":"                mock.call(mock.ANY, mock.ANY),"},{"line_number":154,"context_line":"                mock.call(mock.ANY, mock.ANY, 32769 | os.O_NONBLOCK))"},{"line_number":155,"context_line":"            self.assertTrue(mock.call(\u0027/fake/path\u0027, \u0027r\u0027) in"},{"line_number":156,"context_line":"                            mock_open.mock_calls)"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_1d86d167","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":69},"updated":"2019-04-29 10:13:42.000000000","message":"This should be a list","commit_id":"fbafd3430710a60a6431728e55bde47f930ae259"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"16f3a18daeeee7c72ae724dc57313d6f30ec159d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # NOTE(mikal): we can\u0027t assert that values from fcntl are passed"},{"line_number":150,"context_line":"            # here because we can\u0027t import fcntl in these tests because it"},{"line_number":151,"context_line":"            # is not present on Microsoft Windows."},{"line_number":152,"context_line":"            mock_fcntl.assert_has_calls("},{"line_number":153,"context_line":"                [mock.call(mock.ANY, mock.ANY),"},{"line_number":154,"context_line":"                 mock.call(mock.ANY, mock.ANY, 32769 | os.O_NONBLOCK)])"},{"line_number":155,"context_line":"            self.assertTrue(mock.call(\u0027/fake/path\u0027, \u0027r\u0027) in"},{"line_number":156,"context_line":"                            mock_open.mock_calls)"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_5c9be164","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":71},"updated":"2019-04-30 01:52:49.000000000","message":"AssertionError: Calls not found.\nExpected: [call(\u0026lt;ANY\u0026gt;, \u0026lt;ANY\u0026gt;), call(\u0026lt;ANY\u0026gt;, \u0026lt;ANY\u0026gt;, 34817)]\nActual: []\n\n@Eric, now changed to list, but it failes, could you please tell me how to modify?","commit_id":"c636d29774b2e59d97ac0265711022c72f857abe"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8ee52b3169a266cd1fd1bebed3101e2887c60240","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # NOTE(mikal): we can\u0027t assert that values from fcntl are passed"},{"line_number":150,"context_line":"            # here because we can\u0027t import fcntl in these tests because it"},{"line_number":151,"context_line":"            # is not present on Microsoft Windows."},{"line_number":152,"context_line":"            mock_fcntl.assert_has_calls("},{"line_number":153,"context_line":"                [mock.call(mock.ANY, mock.ANY),"},{"line_number":154,"context_line":"                 mock.call(mock.ANY, mock.ANY, 32769 | os.O_NONBLOCK)])"},{"line_number":155,"context_line":"            self.assertTrue(mock.call(\u0027/fake/path\u0027, \u0027r\u0027) in"},{"line_number":156,"context_line":"                            mock_open.mock_calls)"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_ecaf78e0","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":71},"in_reply_to":"ffb9cba7_5c9be164","updated":"2019-04-30 17:48:01.000000000","message":"I had to poke at this for a while. It turns out the mocking of __import__ was too broad, and ended up breaking a bunch of stuff down the chain. Somehow (I still haven\u0027t figured out exactly how) L145 and L147 were being skipped completely, so by the time we got here, it was true that fcntl hadn\u0027t been called at all.\n\nI did the necessary to make the import mock specific to fcntl. And while I was in there, I crisped up a few more aspects of the test, including working around mikal\u0027s noted limitation - i.e. now we\u0027re asserting the appropriate call paths through fcntl.","commit_id":"c636d29774b2e59d97ac0265711022c72f857abe"}]}