)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"df5f16a30bb1a7fd4d2a400ae1e80ec99d961972","unresolved":false,"context_lines":[{"line_number":11,"context_line":"policy check from compute api and add related tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially implements bp v3-api-policy"},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id5e0a2016b12b41877cf18a69fc2001df6d671fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2B95Q%3D","line":14,"updated":"2014-01-20 09:59:50.000000000","message":"I think because of the changes around policy.json files this probably needs UpgradeImpact too?","commit_id":"e7322c593a2b970f9b9262afd26f070a68897333"}],"nova/api/ec2/cloud.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"df5f16a30bb1a7fd4d2a400ae1e80ec99d961972","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        instance_uuid \u003d ec2utils.ec2_inst_id_to_uuid(context, ec2_id)"},{"line_number":763,"context_line":"        instance \u003d self.compute_api.get(context, instance_uuid)"},{"line_number":764,"context_line":"        extensions.check_compute_policy(context, \u0027get_console_output\u0027,"},{"line_number":765,"context_line":"                                            instance)"},{"line_number":766,"context_line":"        output \u003d self.compute_api.get_console_output(context, instance)"},{"line_number":767,"context_line":"        now \u003d timeutils.utcnow()"},{"line_number":768,"context_line":"        return {\"InstanceId\": ec2_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B948%3D","line":765,"updated":"2014-01-20 09:59:50.000000000","message":"indent is kind of odd","commit_id":"e7322c593a2b970f9b9262afd26f070a68897333"}],"nova/api/openstack/compute/contrib/console_output.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7795b6aa2bdc21f1e1d69acddd2ef398370c0f75","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            instance \u003d self.compute_api.get(context, id)"},{"line_number":43,"context_line":"            extensions.check_compute_policy(context, \u0027get_console_output\u0027,"},{"line_number":44,"context_line":"                                            instance)"},{"line_number":45,"context_line":"        except exception.NotFound:"},{"line_number":46,"context_line":"            raise webob.exc.HTTPNotFound(_(\u0027Instance not found\u0027))"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BnXA%3D","line":44,"updated":"2014-02-20 07:24:51.000000000","message":"move this out of try block is better","commit_id":"614d07d7ed39541fb21c47f60595fdbc87577a01"}],"nova/api/openstack/compute/plugins/v3/console_output.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"df5f16a30bb1a7fd4d2a400ae1e80ec99d961972","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from nova import exception"},{"line_number":26,"context_line":"from nova.openstack.common.gettextutils import _"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ALIAS \u003d \"console-output\""},{"line_number":29,"context_line":"authorize \u003d extensions.extension_authorizer(\u0027compute\u0027, \"v3:\" + ALIAS)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B94I%3D","line":28,"updated":"2014-01-20 09:59:50.000000000","message":"Should you be using core_authorizer instead?","commit_id":"e7322c593a2b970f9b9262afd26f070a68897333"}],"nova/compute/api.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7795b6aa2bdc21f1e1d69acddd2ef398370c0f75","unresolved":false,"context_lines":[{"line_number":2632,"context_line":"                instance\u003dinstance, console_type\u003dconsole_type)"},{"line_number":2633,"context_line":"        return connect_info"},{"line_number":2634,"context_line":""},{"line_number":2635,"context_line":"    @wrap_check_policy"},{"line_number":2636,"context_line":"    @check_instance_host"},{"line_number":2637,"context_line":"    def get_rdp_console(self, context, instance, console_type):"},{"line_number":2638,"context_line":"        \"\"\"Get a url to an instance Console.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BnVk%3D","side":"PARENT","line":2635,"updated":"2014-02-20 07:24:51.000000000","message":"this function is get_rdp_console, you should delete for get_console_output","commit_id":"7d95d729a349631685bb712aebd13c4decc53a5d"}],"nova/tests/api/ec2/test_cloud.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"df5f16a30bb1a7fd4d2a400ae1e80ec99d961972","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"        #              for unit tests."},{"line_number":1718,"context_line":"        rv \u003d self.cloud.terminate_instances(self.context, [instance_id])"},{"line_number":1719,"context_line":""},{"line_number":1720,"context_line":"    def test_console_output_policy_faild(self):"},{"line_number":1721,"context_line":"        instance_id \u003d self._run_instance("},{"line_number":1722,"context_line":"            image_id\u003d\u0027ami-1\u0027,"},{"line_number":1723,"context_line":"            instance_type\u003dCONF.default_flavor,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B938%3D","line":1720,"updated":"2014-01-20 09:59:50.000000000","message":"faild -\u003e failed?","commit_id":"e7322c593a2b970f9b9262afd26f070a68897333"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7795b6aa2bdc21f1e1d69acddd2ef398370c0f75","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":1751,"context_line":"            self.assertIn(\"compute:get_console_output\", e.format_message())"},{"line_number":1752,"context_line":"        else:"},{"line_number":1753,"context_line":"            self.fail(\"Exception PolicyNotAuthorized not raised\")"},{"line_number":1754,"context_line":"        # TODO(soren): We need this until we can stop polling in the rpc code"},{"line_number":1755,"context_line":"        #              for unit tests."},{"line_number":1756,"context_line":"        rv \u003d self.cloud.terminate_instances(self.context, [instance_id])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BnWc%3D","line":1753,"updated":"2014-02-20 07:24:51.000000000","message":"how about use assertRaise directly?","commit_id":"614d07d7ed39541fb21c47f60595fdbc87577a01"}]}
