)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ebd71ea9d5b0b956cc630a26ff56a6dec0c3da52","unresolved":false,"context_lines":[{"line_number":7049,"context_line":"                phase\u003dfields.NotificationPhase.END)"},{"line_number":7050,"context_line":""},{"line_number":7051,"context_line":"    def _remove_remote_volume_connections(self, context, dest, bdms, instance,"},{"line_number":7052,"context_line":"                                          ignore_errors\u003dTrue):"},{"line_number":7053,"context_line":"        \"\"\"Rollback remote volume connections on the dest\"\"\""},{"line_number":7054,"context_line":"        for bdm in bdms:"},{"line_number":7055,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_112e1543","line":7052,"range":{"start_line":7052,"start_character":42,"end_line":7052,"end_character":60},"updated":"2019-05-21 10:13:04.000000000","message":"Nothing is using this. Is it coming later?","commit_id":"64089f0d12695d2a0ca62fb33d839d2af91f210b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d8ee67181264b8204fde2953b2d8399cee69dc44","unresolved":false,"context_lines":[{"line_number":7049,"context_line":"                phase\u003dfields.NotificationPhase.END)"},{"line_number":7050,"context_line":""},{"line_number":7051,"context_line":"    def _remove_remote_volume_connections(self, context, dest, bdms, instance,"},{"line_number":7052,"context_line":"                                          ignore_errors\u003dTrue):"},{"line_number":7053,"context_line":"        \"\"\"Rollback remote volume connections on the dest\"\"\""},{"line_number":7054,"context_line":"        for bdm in bdms:"},{"line_number":7055,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_f187c1d6","line":7052,"range":{"start_line":7052,"start_character":42,"end_line":7052,"end_character":60},"in_reply_to":"bfb3d3c7_112e1543","updated":"2019-05-21 10:29:01.000000000","message":"No, I think this was previously used but never cleaned up. Happy to remove here given this is a refactor.","commit_id":"64089f0d12695d2a0ca62fb33d839d2af91f210b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"26731275c5ebc917fd9829d027087cff9343eda6","unresolved":false,"context_lines":[{"line_number":7049,"context_line":"                phase\u003dfields.NotificationPhase.END)"},{"line_number":7050,"context_line":""},{"line_number":7051,"context_line":"    def _remove_remote_volume_connections(self, context, dest, bdms, instance,"},{"line_number":7052,"context_line":"                                          ignore_errors\u003dTrue):"},{"line_number":7053,"context_line":"        \"\"\"Rollback remote volume connections on the dest\"\"\""},{"line_number":7054,"context_line":"        for bdm in bdms:"},{"line_number":7055,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_308470b1","line":7052,"range":{"start_line":7052,"start_character":42,"end_line":7052,"end_character":60},"in_reply_to":"bfb3d3c7_319a3914","updated":"2019-05-21 13:37:35.000000000","message":"Hmm, I\u0027d personally rather strip this out for now until the follow up that uses it is up. It\u0027s easy to re-add this when needed in the future","commit_id":"64089f0d12695d2a0ca62fb33d839d2af91f210b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8536a03551d2a014b4f13fdadebd6b514e48cb5f","unresolved":false,"context_lines":[{"line_number":7049,"context_line":"                phase\u003dfields.NotificationPhase.END)"},{"line_number":7050,"context_line":""},{"line_number":7051,"context_line":"    def _remove_remote_volume_connections(self, context, dest, bdms, instance,"},{"line_number":7052,"context_line":"                                          ignore_errors\u003dTrue):"},{"line_number":7053,"context_line":"        \"\"\"Rollback remote volume connections on the dest\"\"\""},{"line_number":7054,"context_line":"        for bdm in bdms:"},{"line_number":7055,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_319a3914","line":7052,"range":{"start_line":7052,"start_character":42,"end_line":7052,"end_character":60},"in_reply_to":"bfb3d3c7_f187c1d6","updated":"2019-05-21 10:36:42.000000000","message":"Argh sorry my brain is still on PTO, this was something I *added* in this refactor changing the original behaviour to ignore errors by default. At the time I think I had plans to wire this call into other flows where we would actually care about errors etc so I\u0027d like to leave this in for now.","commit_id":"64089f0d12695d2a0ca62fb33d839d2af91f210b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ebd71ea9d5b0b956cc630a26ff56a6dec0c3da52","unresolved":false,"context_lines":[{"line_number":7098,"context_line":"            except Exception:"},{"line_number":7099,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":7100,"context_line":"                    LOG.exception(\"Exception while attempting to rollback \""},{"line_number":7101,"context_line":"                                  \"bdm for volume %s.\", bdm.volume_id,"},{"line_number":7102,"context_line":"                                  instance\u003dinstance)"},{"line_number":7103,"context_line":""},{"line_number":7104,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_d1271d64","line":7101,"range":{"start_line":7101,"start_character":35,"end_line":7101,"end_character":38},"updated":"2019-05-21 10:13:04.000000000","message":"BDM? (do we ever capitalise this?)","commit_id":"64089f0d12695d2a0ca62fb33d839d2af91f210b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d8ee67181264b8204fde2953b2d8399cee69dc44","unresolved":false,"context_lines":[{"line_number":7098,"context_line":"            except Exception:"},{"line_number":7099,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":7100,"context_line":"                    LOG.exception(\"Exception while attempting to rollback \""},{"line_number":7101,"context_line":"                                  \"bdm for volume %s.\", bdm.volume_id,"},{"line_number":7102,"context_line":"                                  instance\u003dinstance)"},{"line_number":7103,"context_line":""},{"line_number":7104,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_11c7f514","line":7101,"range":{"start_line":7101,"start_character":35,"end_line":7101,"end_character":38},"in_reply_to":"bfb3d3c7_d1271d64","updated":"2019-05-21 10:29:01.000000000","message":"Yeah valid, we aren\u0027t consistent but I\u0027ll capitalise this now.","commit_id":"64089f0d12695d2a0ca62fb33d839d2af91f210b"}]}